Flaw in Program

[Maureen Charlton]

I've just started introducing myself to the Head First Java book. On page 14 there is a program as follows:

  
//Program written by Maureen Charlton 28th January 2006
//Program page 14 of Head Start Java Book
 

public class BeerSong
{
  public static void main (String [] args)
  {
 
  int beerNum =99;
  String word = "bottles";
 
    while (beerNum >0)
    {  
      if (beerNum == 1)
      {
 
        word = "bottle"; //singular, as in ONE bottle.
 
      }//end if statement
 
      System.out.println(beerNum + " " + word + " " + "of beer on the wall");
      System.out.println(beerNum + " " + word + " of beer.");
      System.out.println("Take one down.");
      System.out.println("Pass it around.");
      beerNum = beerNum - 1;
 
      if (beerNum >0)
      {
        System.out.println(beerNum + " " + word + " of beer on the wall");
      }//end second if statement
      else
      {
        System.out.println("No more bottles of been on the wall");
      }//end else statement
 
     }//end while loop
 
  }//end main program
}//end class BeerSong
 

In the book it states that there is a flaw in the program but I can't see where it is as the output to screen I get is (which starts from 99 but I can't copy that far up from DOS screen):

6 bottles of beer on the wall
6 bottles of beer on the wall
6 bottlesof beer.
Take one down.
Pass it around.
5 bottles of beer on the wall
5 bottles of beer on the wall
5 bottlesof beer.
Take one down.
Pass it around.
4 bottles of beer on the wall
4 bottles of beer on the wall
4 bottlesof beer.
Take one down.
Pass it around.
3 bottles of beer on the wall
3 bottles of beer on the wall
3 bottlesof beer.
Take one down.
Pass it around.
2 bottles of beer on the wall
2 bottles of beer on the wall
2 bottlesof beer.
Take one down.
Pass it around.
1 bottles of beer on the wall
1 bottle of beer on the wall
1 bottleof beer.
Take one down.
Pass it around.
No more bottles of been on the wall

C:\Java>

Can anyone highlight what the flaw is?

[Dani Atrei]

1 bottles of beer on the wall

The output isn't perfect, I think that's all

Dan

[Maureen Charlton]

Ah! Because a while loop has been used it will go through it once and use the singular bottle. The if statement should of been outside the while loop then.

Thank you!

[Layne Lund]

Originally posted by Maureen Charlton:
Ah! Because a while loop has been used it will go through it once and use the singular bottle. The if statement should of been outside the while loop then.

Thank you!

I don't think that will fix the problem, either. But you should try it and see what happens.

Layne