1) Expression can be simplified.
2) Avoid inline conditions.
3) Missing package-info.java file.
4) Redundant throws: 'xxx' is unchecked exception.
Cheers, Roberto Perillo
SCJP, SCWCD, SCJD, SCBCD
Cheers, Roberto Perillo
SCJP, SCWCD, SCJD, SCBCD
Roberto Perillo wrote:I honestly don't believe that you'll lose points if they find one or two mistakes regarding code conventions.
Roel De Nijs wrote:But you won't lose points because you added 1 blank line instead of 2. Just use a formatter, tweak it a bit and you'll be fine!
Cheers, Roberto Perillo
SCJP, SCWCD, SCJD, SCBCD