While problem with assignement on String array

[Antony Amicone]

i have a while that run correctly,
when i insert an assignment in it, it stop to work, and give me just the first iteration, stopping on the assignement
no error displayed, just the while stop

  r = new Recipes(recipeName,recipeHowTo,ingredients,level,servings,timeToEat);
            int c = 0;
            while ( c < jList1.getModel().getSize() ) {
             System.out.println(c+"<"+jList1.getModel().getSize());
             System.out.println(jList1.getModel().getElementAt(c));
             r.setIngredient(""+jList1.getModel().getElementAt(c),c);  //if i remove this, the while works but i need it!
             c++;
            }  

the class where i call method for get and set array

  /*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */

package desktopapplication1;

/**
 *
 * @author Antonio
 */
public class Recipes {
private String recipeName = "";
private String recipeHowTo = "";
private String ingredients[];
private int servings;
private int level;
private int timeToEat;
private String imgPath = "";

public Recipes(String a,String a1,String[] a2,int a3, int a4, int a5){
    recipeName = a;
    recipeHowTo = a1;
    ingredients = a2;
    servings = a3;
    level = a4;
    timeToEat = a5;
}

public String getRecipeName(){
    return recipeName;
}

public void setRecipeName(String x){
    recipeName = x;
}

public String getRecipeHowTo(){
    return recipeHowTo;
}

public void setRecipeHowTo(String x){
    recipeHowTo = x;
}

public String[] getIngredients(){
    return ingredients;
}

public void setIngredients(String[] x){
    ingredients = x;
}

public int getServings(){
    return servings;
}

public void setServings(int x){
    servings = x;
}

public int getLevel(){
    return level;
}

public void setLevel(int x){
    level = x;
}

public int getTimeToEat(){
    return timeToEat;
}

public void setTimeToEat(int x){
    timeToEat = x;
}

public String getIngredient(int x){
    return ingredients[x];
}

public void setIngredient(String x,int xx){
    ingredients[xx] = x;
}

}
  

[Campbell Ritchie]

What assignment? I can't see any assignments in that while loop.
What is the size returned from your model?

[Antony Amicone]

Campbell Ritchie wrote:What assignment? I can't see any assignments in that while loop.
What is the size returned from your model?

i assign a value with a method setIngredient(string,int)

what you mean with the size of model? oh just got it:P ( edit ) i try with many size, i have a list with the add and remove button, so sometimes i add 3 elements, sometimes 4 and so on

[Jan Hoppmann]

Antony Amicone wrote:what you mean with the size of model?

He wants to know what jList1.getModel().getSize() returns. I assume it's greater than one?

[Antony Amicone]

if i put 4 element in my array i have a stamp like that

0<4
water 1oz 2lt

cause it stop at first iteration, if i remove that assignment, i have all the while with correct stamp

[Campbell Ritchie]

After the c++; call and before the end of the loop, add some debugging lines, to print out the value of c and the present size (as previously mentioned).

[Antony Amicone]

i added 4 ingredients, and pressed the button

test Insert here your recipe null 5 4 15
0<4
aaaaa 1.1oz 33.0gr

this is the result, if i remove the assignment the while print everything...... but i think the while is corrected

[Antony Amicone]

Antony Amicone wrote:i added 4 ingredients, and pressed the button

test Insert here your recipe null 5 4 15
0<4
aaaaa 1.1oz 33.0gr

this is the result, if i remove the assignment the while print everything...... but i think the while is corrected

i'm trying many test, but he just stop at the method for the assignment, did i make scope error or something like that? i dont think so

[Campbell Ritchie]

As I said before, add some debugging after c++; and before the end of the loop. There is no obvious reason in what you posted for your loop stopping. You need to work out for yourself what is going on.

[Antony Amicone]

Campbell Ritchie wrote:As I said before, add some debugging after c++; and before the end of the loop. There is no obvious reason in what you posted for your loop stopping. You need to work out for yourself what is going on.

done and i posted the result

try{
            System.out.println(recipeName+" "+recipeHowTo+" "+ingredients+" "+level+" "+servings+" "+timeToEat);
            r = new Recipes(recipeName,recipeHowTo,ingredients,level,servings,timeToEat);
            int c = 0;
            while ( c < jList1.getModel().getSize() ) {
             System.out.println(c+"<"+jList1.getModel().getSize());
             System.out.println(jList1.getModel().getElementAt(c));
             //ingredients[c] = (String)jList1.getModel().getElementAt(c);
             r.setIngredient(""+jList1.getModel().getElementAt(c),c);
             c++;
             System.out.println("AFTER C++"+c+"<"+jList1.getModel().getSize());
             System.out.println(jList1.getModel().getElementAt(c));

            }

same result, it doesnt arrive after c++ it stops setIngredient

[Jan Hoppmann]

Try debugging if you have a tool that supports it (e. g. Eclipse), so you can better understand what happens.

[Antony Amicone]

Jan Hoppmann wrote:Try debugging if you have a tool that supports it (e. g. Eclipse), so you can better understand what happens.

i use netbeans, it can debug but never done, what should i do?

[Campbell Ritchie]

Double-click the left of the line with c++; in.

You will get a breakpoint, which is a little red blob next to the line number.

Execute your application in debug mode.

It will stop when it reaches the breakpoint.

You should be able to inspect the state of all objects, so you can find whether there has been any change in the size field in your List.

You can also see the local variables, so you can see the value of c.

You can use step into to go into a method call (probably what you want at present).

You can use step across to call a method without inspecting the details of what is happening.

You can use step return to complete the method you are running at the moment.

You may be able to use f6 f7 and f8 for these step instructions.

You want to see whether the value of size and the value of c are what you expect. Step across might be called step over or similar.

They use a very very different system for debugging on Eclipse . . .





. . . Eclipse breakpoints are blue

[Antony Amicone]

this is result for debugging

test11111111 Insert here your recipe null 5 4 15
0<2
555 0.1oz 5.2gr

[Campbell Ritchie]

That doesn't show the size, nor does it show the value of c at the end of the loop.

And why are you allowing null values?

[Antony Amicone]

Campbell Ritchie wrote:That doesn't show the size, nor does it show the value of c at the end of the loop.

And why are you allowing null values?

so where i have to see size and c value?

the value null is ok in that field

[Antony Amicone]

it says in the output

LineBreakpoint NewJDialog.java : 184 successfully submitted.

i have a thing bout String out of bound -5 in another window, but there is written issue submitted, i never submitted

[Antony Amicone]

Antony Amicone wrote:it says in the output

LineBreakpoint NewJDialog.java : 184 successfully submitted.

i have a thing bout String out of bound -5 in another window, but there is written issue submitted, i never submitted

could be cause i dont set any size to the array in the class? but i tryed to correct putting the private ingredients as = new ingredients[20];

[Campbell Ritchie]

Don't know. I cannot see any reason in what you have posted why your loop could terminate after 1 iteration, unless the size is 1. You say it is 4, so maybe the size has changed.
I can't remember how to run an application on NetBeans in debug mode, but that is what you have to do, then you need to find how to inspect all your objects. You look for the jList1 object.

You never said the code was inside a try. Read this and this. What are you putting in your catch? If you have an empty catch, that would be very dangerous, ( ) because you would simply obscure an Exception and not know it is happening. If you are suffering an OutOfBoundsException, you need to know why.

[Antony Amicone]

try{
            System.out.println(recipeName+" "+recipeHowTo+" "+ingredients+" "+level+" "+servings+" "+timeToEat);
            r = new Recipes(recipeName,recipeHowTo,ingredients,level,servings,timeToEat);
            int c = 0;
            while ( c < jList1.getModel().getSize() ) {
             System.out.println(c+"<"+jList1.getModel().getSize());
             System.out.println(jList1.getModel().getElementAt(c));
             //ingredients[c] = (String)jList1.getModel().getElementAt(c);
             r.setIngredient(""+jList1.getModel().getElementAt(c),c);
             c++;

            }

            File f = new File("c:\\"+recipeName+".rcp");
            BufferedWriter ff = new BufferedWriter(new FileWriter(f));
            System.out.println(r.getRecipeName());
            ff.write(r.getRecipeName());
            ff.newLine();
            ff.write(r.getRecipeHowTo());
            ff.newLine();
            ff.write("INGREDIENTS");
            ff.newLine();
            int c1 = 0;System.out.println(r.getIngredients().length);
            while ( c1 < r.getIngredients().length ){
                System.out.println("write while"+r.getIngredient(c1));
                ff.write(r.getIngredient(c1));
                System.out.println("write while1");
                c1++;
            }
            ff.close();

            System.out.println("aaaaaaaaaaaaaaaaaaaaaaaaaa");
            System.out.println("ingrendienti: "+r.getIngredients().length);

        }catch(Exception e){
            e.printStackTrace();
        }

now works ;) ty to all