It prints me pointer repeatedly

[shawn peter]

This is my main class.It works fine.But when i moving it repeatdly prints the current location pointer.I mean after i move to new location it doesn't remove old location pointer.It prints me pointer in both location.So when i move with phone it shows me the pointer as a line.How to remove the old Pointer ?

package com.virtual.yourlocation;  
  
import java.io.IOException;  
import java.util.List;  
  
import com.google.android.maps.GeoPoint;  
import com.google.android.maps.MapActivity;  
import com.google.android.maps.MapController;  
import com.google.android.maps.MapView;  
import com.google.android.maps.Overlay;  
import com.google.android.maps.OverlayItem;  
import android.app.Activity;  
import android.content.Intent;  
import android.graphics.drawable.Drawable;  
import android.location.Address;  
import android.location.Criteria;  
import android.location.Geocoder;  
import android.location.Location;  
import android.location.LocationListener;  
import android.location.LocationManager;  
import android.os.Bundle;  
import android.view.View;  
import android.view.View.OnClickListener;  
import android.widget.Button;  
import android.widget.TextView;  
  
public class ShowYourLocation extends MapActivity implements LocationListener,OnClickListener{  
    /** Called when the activity is first created. */  
     
private LocationManager locationManager;  
      
    private static  double latitudeE6 = 0.0;  
    private static  double longitudeE6 = 0.0;  
    private MapController mapController;  
    private OverlayItem overlayitem1;     
    private Geocoder geocoder;  
    private MapView mapView;      
    private Intent item;  
      
    @Override  
    public void onCreate(Bundle savedInstanceState) {  
        super.onCreate(savedInstanceState);  
        setContentView(R.layout.main);  
          
        Button copyrights=(Button)findViewById(R.id.B_Copyrights);  
        copyrights.setOnClickListener(this);  
          
        Button satalite=(Button)findViewById(R.id.B_Satilite);  
        satalite.setOnClickListener(this);  
          
        Button street=(Button)findViewById(R.id.B_Street);  
        street.setOnClickListener(this);  
          
        TextView error=(TextView)findViewById(R.id.Error);  
          
        mapView = (MapView) findViewById(R.id.map_view);  
        mapView.setBuiltInZoomControls(true);  
        //mapView.getController();  
        mapView.setClickable(true);  
          
        locationManager = (LocationManager) getSystemService(LOCATION_SERVICE);  
        Criteria criteria = new Criteria();  
        criteria.setPowerRequirement(Criteria.POWER_HIGH);  
        criteria.setAccuracy(Criteria.ACCURACY_FINE);         
        String bestprovider = locationManager.getBestProvider(criteria,false);        
        Location lastknownlocation = locationManager.getLastKnownLocation(bestprovider);  
          
         
        if(lastknownlocation!=null){  
            longitudeE6=lastknownlocation.getLongitude()*1e6;  
            latitudeE6 =lastknownlocation.getLatitude()*1e6;  
              
             locationManager.requestLocationUpdates(bestprovider,5, 0.2f, this);  
               
            
  
    @Override  
    public void onClick(View v) {  
          
  
        if(v.getId() == R.id.B_Copyrights)  
        {  
            item = new Intent(getApplicationContext(), Copyrights.class);  
            startActivity(item);  
        }  
        if(v.getId()==R.id.B_Satilite){  
            mapView.setSatellite(true);  
            mapView.setTraffic(false);  
            mapView.invalidate();  
        }  
        if(v.getId()==R.id.B_Street){  
            mapView.setTraffic(true);  
            mapView.setSatellite(false);  
            mapView.invalidate();  
        }  
          
    }  
  
    @Override  
    public void onLocationChanged(Location location) {  
        longitudeE6=location.getLongitude()*1e6;  
        latitudeE6=location.getLatitude()*1e6;
  
       List<Overlay> mapOverlays = mapView.getOverlays();  
                Drawable drawable = this.getResources().getDrawable(R.drawable.icon);  
                CustomItemizedOverlay itemizedOverlay = new CustomItemizedOverlay(  
                        drawable, this);  
                //GeoPoint point = new GeoPoint((int)latitudeE6, (int)longitudeE6);  
                  
                GeoPoint point = new GeoPoint((int)latitudeE6,(int)longitudeE6);  
                //OverlayItem overlayitem = new OverlayItem(point, "Hello","I'm in From Wadduwa, Sri lanka!");  
  
                geocoder = new Geocoder(this);  
                List<Address> addresses;  
                try {  
                    addresses = geocoder.getFromLocation(latitudeE6/1e6,longitudeE6/1e6,1);  
                  
                for (Address address: addresses){  
                    String Country=address.getCountryName();  
                    overlayitem1 = new OverlayItem(point, address.getCountryName(), address.getAddressLine(0));  
                    //locationdetails += "Address is "+address.getAddressLine(0)+" ,"+address.getCountryName();  
                }  
                } catch (IOException e) {  
                    // TODO Auto-generated catch block  
                    e.printStackTrace();  
                }  
                  
                //itemizedOverlay.addOverlay(overlayitem);  
                itemizedOverlay.addOverlay(overlayitem1);  
                mapOverlays.add(itemizedOverlay);  
                mapController = mapView.getController();  
                mapController.animateTo(point);  
                  
                mapController.setZoom(14);  
                  
                error.setText("");  
              
            }  
      
        }  
                  
        
      
          
    }  
  
    @Override  
    public void onProviderDisabled(String arg0) {  
        // TODO Auto-generated method stub  
          
    }  
  
    @Override  
    public void onProviderEnabled(String arg0) {  
        // TODO Auto-generated method stub  
          
    }  
  
    @Override  
    public void onStatusChanged(String arg0, int arg1, Bundle arg2) {  
        // TODO Auto-generated method stub  
          
    }  
  
  
    @Override  
    protected boolean isRouteDisplayed() {  
        // TODO Auto-generated method stub  
        return false;  
    }  
      
} 

[Tim Moores]

I only see the code adding overlays; where are any being removed?

[shawn peter]

So what about if i make the variables Drawable drawable,CustomItemizedOverlay itemizedOverlay gloabal?
Is it correct ?

[Tim Moores]

I'm not sure what their visibility has to do with adding vs. removing overlays?

[shawn peter]

is it ok removing overlay starting onlocationchange method.So each time location change it removes tha old overlay nad print a new one.is it correct ?

mapOverlays.remove(overlayitem1);

[Tim Moores]

Does it work?

[shawn peter]

unable to check.Because i am at now home.So i have to walk now as i don't have Bike now.
I can test tomorrow morning when i am travelling to office.Anyway can you tell me is it the correct way ?