Exception in if statement: if/else vs. if - which is better?

[Derek Canaan]

Hi everyone,
Need your opinion on this:

1    if (condition) {
2        throw new Exception("blah..");
3    } else {
4        doSomething();
5    }
    
1    if (condition) {
2        throw new Exception("blah..");
3    }
4    doSomething();  

Which is more preferred and why?
thanks,
derek

[Jacques Bosch]

My gut feeling is that this one is better:

1    if (condition) {
2        throw new Exception("blah..");
3    }
4    doSomething();  

Why? Because exceptions is for when normal flow of execution fails. I.e. Something is wrong, and we can't continue.
But if nothing is wrong, just carry on as if there was no check.
Maybe I'm wrong.

[George Marinkovich]

Hi Derek,

1    if (condition) {
2        throw new Exception("blah..");
3    }
4    doSomething();

I like the version above better. It's debatable, but I find this version to be simpler.
Hope this helps,
George
[ February 10, 2004: Message edited by: George Marinkovich ]

[Derek Canaan]

Hi Jacques and George,
Just as you do, I like the shorter version too. It's also less clouded. And I like Jacques' reasoning too
Thanks guys,
Derek