Problem in code need help

[Louis Paumier]

Hi I am new to java and for my first assignment in my java class we were to write a program which generated 4 semi randomly placed rectangles with semi random colors and sizes. Then when two rectangles are clicked on they are to switch places. I am using a constructor to construct all four rectangles and this portion of the code is working just as it is supposed to. However, the portion to switch the rectangles is not working and after looking at it for literally hours I can not figure out why. I am not completely new to programming as I have been in other courses as well but for some reason I am stumped. If you could please at least point me in the direction of my problem that would be great. I don't expect someone to tell me explicitly the problem but any help would be greatly appreciated as my assignment is due tommorrow. Thanks ahead of time.

The following is my code the second section being the constructor and the first being the class to switch the rectangles and such:

import objectdraw.*;
public class Rectangle extends WindowController {

private RectangleTester rect1, rect2, rect3, rect4;


int randomWidth = (int) (Math.random()*50);
int randomHeight = (int) (Math.random()*100);
int randomX = (int) (Math.random()*200);
int randomY = (int) (Math.random()*300);
boolean firstClick = true;

public void begin() 
{
rect1 = new RectangleTester(randomX = (int) (Math.random()*75) + 100,
                    randomY = (int) (Math.random()*300),
                    randomWidth = (int) (Math.random()*50) + 25,
                    randomHeight = (int) (Math.random()*100) + 10,
                    canvas);
rect2 = new RectangleTester(rect1.getX() + rect1.getWidth() + 40,
                    randomY = (int) (Math.random()*300),
                    randomWidth = (int) (Math.random()*50) + 25,
                    randomHeight = (int) (Math.random()*100) + 10,
                    canvas);
rect3 = new RectangleTester(rect2.getX() + rect2.getWidth() + 40,
                    randomY = (int) (Math.random()*300),
                    randomWidth = (int) (Math.random()*50) + 25,
                    randomHeight = (int) (Math.random()*100) + 10,
                    canvas);
rect4 = new RectangleTester(rect3.getX() + rect3.getWidth() + 40,
                    randomY = (int) (Math.random()*300),
                    randomWidth = (int) (Math.random()*50) + 25,
                    randomHeight = (int) (Math.random()*100) + 10,
                    canvas);
}
public static void main(String[] args)
{
new Rectangle().startController(600, 600);
}

public void onMousePress(Location point)
{
RectangleTester firstRect = null; 
RectangleTester destinationRect = null;
RectangleTester saveRect = null;
    


if(firstClick)
{
if(rect1.contains(point))
{
firstRect = rect1;
firstClick = false;
}
if (rect2.contains(point))
{
firstRect = rect2;
firstClick = false;
}
if (rect3.contains(point))
{
firstRect = rect3;
firstClick = false;
}
if (rect4.contains(point))
{
firstRect = rect4;
firstClick = false;
}
}
else 
{
if (rect1 != firstRect && rect1.contains(point))
{
saveRect = destinationRect = rect1;
firstClick = true;
destinationRect.moveTo(firstRect.getX(), firstRect.getY());
        firstRect.moveTo(saveRect.getX(),saveRect.getY());

}
if (rect2 != firstRect && rect2.contains(point))
{

saveRect = destinationRect = rect2;
firstClick = true;
destinationRect.moveTo(firstRect.getX(), firstRect.getY());
firstRect.moveTo(saveRect.getX(),saveRect.getY());
}
if (rect3 != firstRect && rect3.contains(point))
{
saveRect = destinationRect = rect3;
firstClick = true;
destinationRect.moveTo(firstRect.getX(), firstRect.getY());
firstRect.moveTo(saveRect.getX(),saveRect.getY());
}
if (rect4 != firstRect  && rect4.contains(point))
{
saveRect = destinationRect = rect4;
firstClick = true;
destinationRect.moveTo(firstRect.getX(), firstRect.getY());
firstRect.moveTo(saveRect.getX(),saveRect.getY());
}
}
}
}
 
    

Constructor:

import java.awt.Color;
 
import objectdraw.*;
public class RectangleTester {
private FilledRect rect;


int randomColor = (int) (4*Math.random());

public RectangleTester(double x, double y, double width, double height,DrawingCanvas canvas)
{
if (randomColor == 0)
{
rect = new FilledRect(x,y,width,height,canvas);
rect.setColor(Color.blue);
}
else if(randomColor == 1)
{
rect = new FilledRect(x,y,width,height,canvas);
rect.setColor(Color.red);
}
else if(randomColor == 2)
{
rect = new FilledRect(x,y,width,height,canvas);
rect.setColor(Color.green);
}
else if(randomColor == 3)
{
rect = new FilledRect(x,y,width,height,canvas);
rect.setColor(Color.orange);
}
}

public double getX()
{
return(rect.getX());
}

public double getY()
{
return(rect.getY());
}

public double getWidth()
{
return(rect.getWidth());
}
 
public boolean contains(Location point)
{
return(rect.contains(point));
}

public void moveTo(double x, double y)
{
rect.moveTo(x, y);
}
}
    

[edit]Add newlines to avoid very long lines[/edit]
[ September 15, 2008: Message edited by: Campbell Ritchie ]

[Campbell Ritchie]

Welcome to JavaRanch

Please check the settings on your text editor; have you got tab = 8 spaces? If so change it to "replace tab with spaces" and "tab = 4 spaces." Also make sure to put a space after every comma. Both features which will gain marks. Also don't write lines so long they fall off the edge of the screen. Nesting assignment statements inside constructor calls will lose you marks, I am afraid.

What you need to do when clicking on a Rectangle is to store its fields (x, y, height, width, colour) somewhere, then when you click on the other rectangle, apply its x y height width colour to the first rectangle, then apply the stored variables to the 2nd rectangle. You may need a "mouseClicked" method which means that one of your Components has to implement the MouseListener interface. Remember that interface has 5 methods in, so you might need to implement 4 as "empty", or use the MouseAdapter. You can use an if-else on the firstClick field to choose which rectangle is frstToSwap and which is secondToSwap.

[edit]Minor spelling corrections.[/edit]
[ September 15, 2008: Message edited by: Campbell Ritchie ]