override the window.open function

[az ziz]

dear all,

in my application the reports will be opened in a new popup window using the window.open. whenever a new window is opened i need to append a query string to the url like "popup=Y".
i have overridden the window.open

   

window.open = function() {
      var args = arguments;
      args[0] = args[0]+"&popup=Y";  /// this is the url param
      //what else should i do????
      return true;// this didnt work
}

 

but the window did not open. what else should i do to open the window

Thanks
Vijay Veeraraghavan

[Eric Pascarello]

hints:
window.open_ = window.open
foo.call()

Eric

[az ziz]

dear eric,
Thanks for your reply....
kindly can you expand the reply you said.. i cant understand

Where should i call this? it goes into an infinite loop, at last stack overflow...

thanks

Vijay Veeraraghavan

[Eric Pascarello]

The basic idea:

window.open_ = window.open;
window.open = function(url, name, props) {
  var ques = (url.indexOf("?")<0):"&":"?";
  return window.open_(url + ques + "foo=bar", name, props);
}

Eric

[Bear Bibeault]

I wouldn't try to override the built-in function at all. I'd just define my own.

[az ziz]

thank you Eric ... it works fine...