Get Database connection

[Dan Parsons]

I have the below data class that connects to Oracle without any issues in Tomcat 6.0.18. The web app is used about once or twice a week by 5 users.
Everytime I connect in a class I have to use the same setter and getter methods so I would like to put them in a seperate bean class and call it in each java class.
Here is what I have that currently works:

public class City 
{
	private String dbURL = "";
	private String dbUser = "";
	private String dbPw = "";
	
	public void setDbURL(String dbURL)
	{
		this.dbURL = dbURL;
	}
	
	public String getDbURL()
	{
		return dbURL;
	}
	
	public void setDbUser(String dbUser) 
	{
		this.dbUser = dbUser;
    }
    
    public String getDbUser() 
    {
    	return dbUser;
    }
    
    public void setDbPw(String dbPw) 
    {
    	this.dbPw = dbPw;
    }
    
    public String getDbPw() 
    {
    	return dbPw;
    }
    

    public Connection getConnection() 
    {
	    Connection conn = null;
	    try {
	      conn = DriverManager.getConnection(getDbURL(), getDbUser(),
	          getDbPw());
	      }
	    catch (SQLException e) {
	      System.out.println("No Database connection");
	      e.printStackTrace();
	      }
	    return conn;
    }
    

    public UserBean getLocation(String city, String state)
.....

I tried putting it in a ConnBean java class like this:

public class ConnBean
{
    private String dbURL = "";
	private String dbUser = "";
	private String dbPw = "";

public ConnBean() {}
	
	public void setDbURL(String dbURL)
	{
		this.dbURL = dbURL;
	}
	
	public String getDbURL()
	{
		return dbURL;
	}
	
	public void setDbUser(String dbUser) 
	{
		this.dbUser = dbUser;
    }
    
    public String getDbUser() 
    {
    	return dbUser;
    }
    
    public void setDbPw(String dbPw) 
    {
    	this.dbPw = dbPw;
    }
    
    public String getDbPw() 
    {
    	return dbPw;
    }

 public Connection getConnection()    
    {   
        Connection conn = null;   
        try {   
          conn = DriverManager.getConnection(getDbURL(), getDbUser(),   
              getDbPw());   
          }   
        catch (SQLException e) {   
          System.out.println("No Database connection");   
          e.printStackTrace();   
          }   
        return conn;   
    }  
}

New connection attempt keeps saying it cant find any connection info:

public class City 
{

Connection conn;
conn = new ConnBean(getConnection());
    
    public UserBean getLocation(String city, String state) 
{
......

Please advise how I can make this work?

[Sagar Rohankar]

TellTheDetails and I saw there is no constructor in ConnBean which takes the Connection as an input parameter

conn = new ConnBean(getConnection())

[Jan Cumps]

...and I saw there is no constructor in ConnBean which takes the Connection as an input parameter...

Indeed. The code given by Dan does not compile.

Dan, please post the real code, and the real error messages.

Regards, Jan

[Gavi jadz Grandea]

I think what your trying to do is...

  Connection conn = new ConnBean().getConnection();  

to get the connection.

[Somnath Mallick]

You can also get rid of the constructor and make the variables and methods static! Shift the getConnection() to the class City as a private method. So then you can just call them like:

conn = getConnection(ConnBean.getDbURL(), ConnBean.getDbUser(), ConnBean.getDbPw());