help with a booking system

[Robert Staniforth]

Hey, I'm trying to get this hotel booking system sorted out so I can put a customer in a certain room, but i'm not really sure how to do it exactly. Would really appreciate some help, all the stuff I've tried so far has been a complete failure :/
(I wasn't really sure what to title this, sorry)

 public class Room
	{
	String customer;
	int roomNumber;
	double rate;

	
	Room(int n, double t)
	{
	}
	
	Room()
	{
	}
	
	public void bookRoom(String customer)
	{
		this.customer = customer;
	}
	
	void clearBooking()
	{
		customer = null;
	}
	
	public String getCustomer()
	{
		return customer;
	}
	
	double getRate()
	{
		return rate;
	}
	
	int getRoomNumber()
	{
		return roomNumber;
	}
	
	public String toString()
	{
		return customer + " in: " + roomNumber + " " +"(" + "type here later" + ")" + " at " + rate + " per day.";
	}
	

		
}   

  
public class Bedroom extends Room
{
	String roomType;
	
	Bedroom()
	{
	}
	
	Bedroom(int n, double r, String t)
	{
		if (n >= 201 && n <= 203){
			r = 35;
			t = "Single";
		} else if (n >= 204 && n <= 212){
			r = 60;
			t = "Double";
		} else {
			System.out.println("Incorrect room number");
		}

	}
	
	String getType()
	{
		return roomType;
	}
	
	public String toString()
	{
		return customer;
	}
}
  

import java.util.*;
import javax.swing.*;
public class testRoom
{
	public static void main(String[] args)
	{

		String customerName;
		Room mnRoom = new Room();
		int nameLength;
		System.out.println("Room before booked (should display " + "null) : "  + mnRoom.getCustomer());
		if (mnRoom.getCustomer() == null){
			do{
			customerName = JOptionPane.showInputDialog(null, "Please enter customers name (2 or more characters)");
			mnRoom.bookRoom(customerName);
			nameLength = customerName.length();
			}while(nameLength < 3 || nameLength > 50);
		} else {
			System.out.println("Sorry, room is booked already");
		}
		System.out.println ("Customer currently in the room: " + mnRoom.toString());
	}
}    

[moh oo]

hi,
By looking at your code, I think you can create a enum data type for room type (to improve, just what i think ). Also, in the bedroom constructor, you have a if condition, which i think is not so clear. accepting 'n' and 'r' values as parameters. then you assign them back (with a hard coded values). you would put something more realistic. it is something i can think of by brief look. I hope it helps

[Robert Staniforth]

the if statement is: there are only rooms 201-> 212 and rooms 201 to 203 are single rooms, therefore have a different rate to the double which are 204-> 212

[Amit Ghorpade]

Welcome to Javaranch moh moh oo .
Please check your Private messages.

[David Newton]

If this is a continuation of your previous thread, in the future, don't start a new one.

The code where you set a rate is... highly local:

    Bedroom(int n, double r, String t)  
    {  
        if (n >= 201 && n <= 203){  
            r = 35;  
            t = "Single";  
        } else if (n >= 204 && n <= 212){  
            r = 60;  
            t = "Double";  
        } else {  
            System.out.println("Incorrect room number");  
        }  
  
    }  

So... what impact does this code have outside the constructor itself? (Hint: none.) You set a parameter you pass in to the method: isn't your goal to set the rate for the room? Where/in what variable is the room rate visible to anything that might use it? Where is the parameter "r" visible?

[Prince Manchanda]

Hey Robert,

To start with I see following two problems with your code:

First, In the constructor of your class Bedroom, you are trying to set the values for the input arguments.

Bedroom(int n, double r, String t) 
r = "35";

It should be something like this

Bedroom(int n, double r, String t) 
rate = r;

Trying changing that and see if it works

Second, is the more fundamental problem of OOPS. You are trying to put the business logic in the classes that represent that your entities. To start with you can have the following approach:

public class Room  
     {  
     String customer;  
     int roomNumber;  
     double rate;
// getter/setter here
// remove the bookRoom and cancelBooking method
}

public class Bedroom extends Room  
 {  
     String roomType;  
//getter/setter
//don't add the parametised constructor
}

Then add a following class that will hold your logic for bookings

public class BookRoom {

public BookRoom() {
}

public BookRoom(int n, double r, String t)  {  
        BedRoom bRoom = new BedRoom()
         if (n >= 201 && n <= 203){  
             bRoom.setRate(r);// = 35;  
             bRoom.setRoomType(t);//"Single";
             bRoom.setRoomNumber(n);
         } else if (n >= 204 && n <= 212){  
//same as above
         } else {  
             System.out.println("Incorrect room number");  
         }  
   
     }  

 public bookRoom() {

//do the booking
}

public cancelBooking() {

//cancel the booking
}