AudioPlayer issues

[Louis Kounios]

Hi, guys! I'm new in Java and I'm trying to write a small game.

What I want to do is play a sound as soon as my program runs, and stop that sound and play a different one as soon as the user clicks on "Start". The problem is that the previous sound will not stop playing, but as soon as I click on "Start" in my GUI, the new sound plays and I can hear both of them playing simultaneously.

I won't post the whole code, because I don't think it's necessary.

Here's my class for sound playback:

package com.louiskounios;

import sun.audio.*;
import javax.swing.*;
import java.awt.event.*;
import java.io.*;

public class PlaySound {
	
	static AudioPlayer MGP = AudioPlayer.player;
	static AudioStream BGM;
	static AudioData MD;

	public PlaySound(FileInputStream file) {
		try {
			BGM = new AudioStream(file);
			MD = BGM.getData();
		} catch(IOException ex) {
			ex.printStackTrace();
		}
	} //close constructor
	
	public static void setSound(FileInputStream file) {
		try {
			BGM = new AudioStream(file);
			MD = BGM.getData();
		} catch(IOException ex) {
			ex.printStackTrace();
		}
	} //close setSound(FileInputStream) method
	
	//overloaded startSound(ContinuousAudioDataStream) for repeated playback
	public static void startSound(ContinuousAudioDataStream stream) {
		stream = new ContinuousAudioDataStream(MD);
		MGP.start(stream);
	} //close startSound(ContinuousAudioDataStream) method
	
	//overloaded startSound(AudioDataStream) for single playback
	public static void startSound(AudioDataStream stream) {
		stream = new AudioDataStream(MD);
		MGP.start(stream);
	} //close startSound(AudioDataStream) method
	
	public static void stopSound(ContinuousAudioDataStream stream) {
		MGP.stop(stream);
	} //close stopSound(ContinuousAudioDataStream) method
	
	public static void stopSound(AudioDataStream stream) {
		MGP.stop(stream);
	} //close stopSound(AudioDataStream) method
	
} //close PlaySound outer class

...and here's my game (only the important parts):

package com.louiskounios; //this file belongs in the package com.louiskounios

/*System Imports*/
import javax.swing.*;
import java.awt.*;
import java.util.*;
import java.awt.event.*;
import java.io.*;
import sun.audio.*;
/*--------------*/

public class Skeletas {

	/*Sound implementation*/
	static ContinuousAudioDataStream startupMusicStream;
	static ContinuousAudioDataStream backgroundMusicStream;
	static AudioDataStream ouchStream;
	static AudioDataStream laughingStream;
	
	static FileInputStream startupMusic;
	static FileInputStream backgroundMusic;
	static FileInputStream laughingMusic;
	static FileInputStream ouchMusic;

	static PlaySound soundPlayer;
	/*--------------------*/
	
	public static void main(String[] args) {
		Skeletas program = new Skeletas();
		program.setUpSound();
		program.setUpGUI();
	} //close main(String[] args) method
	
	public void setUpSound() {
	
		//Sound initialization
		try {
			startupMusic = new FileInputStream("com/louiskounios/sounds/starwarstheme.wav");
			backgroundMusic = new FileInputStream("com/louiskounios/sounds/imperialmarch.wav");
			laughingMusic = new FileInputStream("com/louiskounios/sounds/laughing.wav");
			ouchMusic = new FileInputStream("com/louiskounios/sounds/cheering.wav"); //change this!
			
			soundPlayer = new PlaySound(startupMusic);
			soundPlayer.startSound(startupMusicStream); //play our startupMusic
		} catch(Exception ex) {
			ex.printStackTrace();
		}
	} //close setUpSound() method

	public class myStartListener implements ActionListener {
		public void actionPerformed(ActionEvent a) {
			soundPlayer.stopSound(startupMusicStream);
			soundPlayer.setSound(backgroundMusic);
			soundPlayer.startSound(backgroundMusicStream);
			start.setEnabled(false); //disable the start button
			go();
		}
	} //close myStartListener inner class

I really do not understand what is going wrong. In one of my experiments, I tried placing the "AudioPlayer.player.stop(ContinuousAudioDataStream/AudioDataStream);" inside my startSound methods of the PlaySound class, and the sound didn't start at all, because the stop() method was directly following the start() method. This proved to me that the stop() method is working.

Sorry if the code is unclear in any way and thanks in advance for any help coming my way. If you think I neglected to share any required, please let me know.

Louis.

PS: Any suggestions to improve my code readability etc are welcome.

[Lester Burnham]

Instead of the com.sun... classes, I'd go with the stuff in javax.sound.sampled - it's in the API, it's much more capable and liable to be more mature.

[Louis Kounios]

Lester, I heeded your advice and went with javax.sound.sampled. Thanks for that!

Now that I'm almost close to finalising the basic stuff, I'm trying to finish my OO class for sound playback with the following addition: speed up/slow down the sound during playback. This is what I've done so far:

/**System Imports**/
import java.io.*;
import java.net.URL;
import javax.sound.sampled.*; 
/**==============**/

/**A class that will allow playback of files from the system by sending a URL to
   the setSound(URL) method, and invoking the playOnce() or playLoop() methods.**/
public class SoundPlayback {
	
	/**Controlling the Volume**/
	FloatControl gainControl;
	FloatControl sampleControl;
	double gainOnce = .9D; //need to be louder than looping sounds
	double gainLoop = .3D;
	float sampleRate = 20050f; //just to make sure the program runs
	float dB;
	/**======================**/
	
	/**Music Playback**/
	AudioInputStream audioIn;
	Clip clip;
	/**==============**/
	

	/**Method: setSound(URL)
	 //Used to select the music file to play. Opens the clip and
	 //gains access to the MASTER_GAIN and SAMPLE_RATE controls.
	**/
	public void setSound(URL url) {
		
		try {
			audioIn = AudioSystem.getAudioInputStream(url);
			clip = AudioSystem.getClip();
			clip.open(audioIn);
		} catch(Exception ex) {
			ex.printStackTrace();
		}
		
		gainControl = (FloatControl) clip.getControl(FloatControl.Type.MASTER_GAIN);
		sampleControl = (FloatControl) clip.getControl(FloatControl.Type.SAMPLE_RATE);
	} //end of setSound(URL)

	/**Method: playOnce()
	 //Sets the MASTER_GAIN to a high level.
	 //Sets the SAMPLE_RATE.
	 //Flushes the contents and starts playback.
	**/
	public void playOnce() {
		dB = (float) (Math.log(gainOnce) / Math.log(10.0) * 20.0);
		gainControl.setValue(dB);
		System.out.println("dB: " + dB);
		clip.flush();
		clip.start();
	} //end of playOnce() method
	
	/**Method: playLoop()
	 //Sets the MASTER_GAIN to a low level.
	 //Starts infinite playback.
	 //Playback will stop by calling the stop() method.
	**/
	public void playLoop() {
		dB = (float) (Math.log(gainLoop) / Math.log(10.0) * 20.0);
		gainControl.setValue(dB);
		sampleControl.setValue(sampleRate);
		System.out.println("dB: " + dB);
		System.out.println("Sample Rate: " + sampleRate);
		clip.loop(Clip.LOOP_CONTINUOUSLY);
	} //end of playLoop() method

	/**Method: stop()
	 //Flushes the contents and stops playback.
	**/
	public void stop() {
		clip.flush();
		clip.stop();
	} //end of stop() method
} //end of SoundPlayback class

And what I get when I run my test class (with a GUI) is "Exception in thread "main" java.lang.IllegalArgumentException: Unsupported control type: Sample Rate". If I comment out both the sampleControl = (FloatControl)... and sampleControl.setValue() methods, the program runs fine. The problem is, I already tried reading the API and I do not understand what I'm doing wrong. MASTER_GAIN works like a charm.

Can anyone help me with this?