getting null in second servlet

[Sachin Kadian]

hey all

i have 2 servlets called signup.java and submitfavourite.java

i am trying to pass a variable username from signup to submitfavourite like this...

code for signup.java

import java.sql.*;
import javax.servlet.http.*;
import java.io.*;
import javax.servlet.*;

public class signup extends HttpServlet

{
public void doPost(HttpServletRequest req,HttpServletResponse res) 

throws IOException
{
res.setContentType("text/html");
PrintWriter out=res.getWriter();

Connection con2;
String 

username,emailid,userpassword,sex,security,sex1,securityanswer;

username=req.getParameter("uname");
userpassword=req.getParameter("upass");
emailid=req.getParameter("email");
sex=req.getParameter("sex");
security=req.getParameter("security");
securityanswer=req.getParameter("securityanswer");

if(sex.equals("male"))
sex1="m";
else
sex1="f";



try
{
con2=new connect().getconnection();
Statement st=con2.createStatement();

PreparedStatement pr=con2.prepareStatement("select * from register 

where username=?");
pr.setString(1,username);
ResultSet rs=pr.executeQuery();
if(rs.next())
{

res.sendRedirect("/project2/pages/failure.html");


}
else
{
st.executeUpdate("insert into register values('"+username

+"','"+emailid+"','"+userpassword+"','"+sex1+"','"+security

+"','"+securityanswer+"')");

HttpSession session=req.getSession();
session.setAttribute("uname",username");

RequestDispatcher view=req.getRequestDispatcher

("/pages/favouriteup.html");
view.forward(req,res);
}

}
catch(Exception e)
{
out.println("exception");
}

}
}

favouriteup.html is calling submitfavourite.

code for submitfavourite.java

import java.sql.*;
import javax.servlet.http.*;
import java.io.*;
import javax.servlet.*;

public class submitfavourite extends HttpServlet

{

public void doGet(HttpServletRequest req1,HttpServletResponse res1) throws IOException
{
res.setContentType("text/html");
PrintWriter out=res.getWriter();

Connection con2;
String favourite_item,favourite_brand,favourite_method;

favourite_item=req.getParameter("select1");
favourite_brand=req.getParameter("select2");
favourite_method=req.getParameter("select3");

HttpSession session1=req1.getSession();
String username=(String)session1.getAttribute("uname");


try
{
con2=new connect().getconnection();
Statement st=con2.createStatement();

st.executeUpdate("insert into favourite values('"+username+"','"+favourite_item+"','"+favourite_brand+"','"+favourite_method+"')");
out.println("successfully registerd");
}

catch(Exception e)
{
out.println("exception");
}

}
}

but in my database i am getting null instead of username means session.getAttribute("uname") is returning null. i also tried this by request.getAttribute but that is also returning null.
please help me why it is returning null..

thanhx.

[Bear Bibeault]

Please properly indent your code when posting, unindented code is very hard to read. Also you should be following established naming conventions for Java. Class names should be Signup and SubmitFavourite,

[Sachin Kadian]

sorry sir but now it have done it..
please help me.

[Koen Aerts]

What is "req" in submitfavourite.java referring to? Should it be "req1" instead?

Also note that creating SQL by concatenating strings together is prone to SQL injection. You want to use binding variables instead.

[Sachin Kadian]

sir i also tried with req instead of req1 but same null is returning.

[Bear Bibeault]

You'll get more help if you re-post your code with proper indentation and following conventions.

[Koen Aerts]

Bear Bibeault wrote:You'll get more help if you re-post your code with proper indentation and following conventions.

That's right, it's currently difficult to read and I'm not sure if some errors like the one below are just a formatting issue or actual mistake in the code:

session.setAttribute("uname",username");

(notice the quote character after the username variable)

[Sachin Kadian]

code for SignUp

import java.sql.*;
import javax.servlet.http.*;
import java.io.*;
import javax.servlet.*;

public class signup extends HttpServlet

{
     public void doPost(HttpServletRequest req,HttpServletResponse res) throws IOException
     {
     
     res.setContentType("text/html");

     PrintWriter out=res.getWriter();

     Connection con2;

     String username,emailid,userpassword,sex,security,sex1,securityanswer;

     username=req.getParameter("uname");

     userpassword=req.getParameter("upass");

      emailid=req.getParameter("email");

     sex=req.getParameter("sex");

      security=req.getParameter("security");

     securityanswer=req.getParameter("securityanswer");

     if(sex.equals("male"))
     sex1="m";
     else
     sex1="f";

       try
         {
          con2=new connect().getconnection();
          
          Statement st=con2.createStatement();

          PreparedStatement pr=con2.prepareStatement("select * from register where username=?");
      
         pr.setString(1,username);

         ResultSet rs=pr.executeQuery();

         if(rs.next()) 
             {

               res.sendRedirect("/project2/pages/failure.html");


             }
          else
             {
              st.executeUpdate("insert into register values('"+username+"','"+emailid+"','"+userpassword+"','"+sex1+"','"+security+"','"+securityanswer+"')");

              req.setAttribute("uname",username);

              RequestDispatcher view=req.getRequestDispatcher("/pages/favouriteup.html");

              view.forward(req,res);
             }

       }
        catch(Exception e)
            {
            out.println("exception");
            }

    }
}

code for SubmitFavourite

import java.sql.*;
import javax.servlet.http.*;
import java.io.*;
import javax.servlet.*;

public class SubmitFavourite extends HttpServlet

        {

        public void doGet(HttpServletRequest req,HttpServletResponse res) throws IOException
             {

              res.setContentType("text/html");

              PrintWriter out=res.getWriter();

             Connection con2; 

              String favourite_item,favourite_brand,favourite_method;

              favourite_item=req.getParameter("select1");

              favourite_brand=req.getParameter("select2");

              favourite_method=req.getParameter("select3");

              HttpSession session1=req.getSession();

              String username=(String)session1.getAttribute("uname");

             try
                {

                   con2=new connect().getconnection();

                   Statement st=con2.createStatement();

                   st.executeUpdate("insert into favourite values('"+username+"','"+favourite_item+"','"+favourite_brand+"','"+favourite_method+"')");

                    out.println("successfully registerd");
                }

           catch(Exception e)
               {

               out.println("exception");

                } 

         }
}

[Sachin Kadian]

now is it okay or should i do anything else sir???

[Koen Aerts]

Sachin Kadian wrote:now is it okay or should i do anything else sir???

Now, now...

In one place you do request.setAttribute("uname"), but in the other you then do session.getAttribute("uname")... did you try request.getAttribute("uname") instead?

[Sachin Kadian]

ohh yaa.. that was realy an error sir.. i did it by mistake. thanhx for showing this... now it is working properly.. thanhx a lot.