Write the output to a file

[Prasad Rooge]

Im trying to write the contents of webpage to a file

import javax.swing.text.MutableAttributeSet;
import javax.swing.text.html.HTML;
import javax.swing.text.html.HTMLDocument;
import javax.swing.text.html.HTMLEditorKit;
import javax.swing.text.html.parser.ParserDelegator;
import org.jsoup.Jsoup;

public class ReadTest extends HTMLEditorKit.ParserCallback {

    File file= new File("C:/Documents and Settings/Designer/Desktop/me/file/new5.txt");
    
    @Override
public void handleText(char[] data, int pos){
        try {
            FileOutputStream fop= new FileOutputStream(file);
               String d= new String(data);
                System.out.println(d);
                fop.write(d.getBytes());
        } catch (IOException ex) {
            Logger.getLogger(ReadTest.class.getName()).log(Level.SEVERE, null, ex);
        }
}

    @Override
public void handleStartTag(HTML.Tag t, MutableAttributeSet a, int pos){
//System.out.println("start: " + t);
}

    @Override
public void handleEndTag(HTML.Tag t, int pos){
//System.out.println("end: " + t);
}

    @Override
public void handleSimpleTag(HTML.Tag t, MutableAttributeSet a, int pos){

if (t == HTML.Tag.META){
String name1=(String)a.getAttribute(HTML.Attribute.NAME);
if (name1 != null){

//System.out.println("META name1: 555" + name1);
}
String content1 = (String)a.getAttribute(HTML.Attribute.CONTENT);
if (content1 != null){
   // System.out.println("META content1: " + content1);
}
}

}

public static void main(String argv[]) {
try {
    
    File newFile=new File("C:/Documents and Settings/Designer/Desktop/me/ww.html");
    FileOutputStream fop=new FileOutputStream(newFile);
    String str="http://www.bangalorecircle.com/pages/Health%20Care.html";
    String html = Jsoup.connect(str).get().html();
    fop.write(html.getBytes());
    fop.flush();
    fop.close();
    
Reader r = new FileReader("C:/Documents and Settings/Designer/Desktop/me/ww.html");
ParserDelegator parser = new ParserDelegator();
HTMLEditorKit.ParserCallback callback = new ReadTest();
parser.parse(r, callback, true);
EditorKit kit=new HTMLEditorKit();
HTMLDocument doc=(HTMLDocument)kit.createDefaultDocument();
} catch (IOException e) {
}
}
}

its creating a blank file...the contents are not being written...please help me with this

[Paul Clapham]

Why do you open a new file every time the handleText() method is called?

[Prasad Rooge]

thanks for reply

i have created the file outside the outside the handleText ()

 File file= new File("C:/Documents and Settings/Designer/Desktop/me/file/new5.txt");

[Paul Clapham]

No, that just creates a Java "File" object. This does not create anything in your operating system's file system. I should have asked why you repeatedly re-opened the file.

[Prasad Rooge]

The char array data is only accessible inside the handleText() and it changes everytime the method is called. So im trying to append the

String d= new String(data);  

into the file.
Sorry for any mistake i'm a beginner in java.

Thanks

[Winston Gutkowski]

Prasad Rooge wrote:The char array data is only accessible inside the handleText() and it changes everytime the method is called.

Then doesn't it make sense to make the File (or perhaps even better, its FileOutputStream) accessible in the method too? What you're running into is an example of "tight coupling", and one of the ways to solve it would be to pass the FileOutputStream to the method.

So im trying to append the [String] into the file.

I wouldn't advise that. Opening and closing files is expensive. Why not just append what you need to the html you just read in, and write the whole file in one go?

Winston

[Aditya Jha]

Please note, every time you do

FileOutputStream fop= new FileOutputStream(file);

the contents of the file are purged and the file becomes empty.

It goes back to Winston's suggestion - don't open FileOutputStream multiple times. Every time you open it, the earlier contents will vanish.

[Prasad Rooge]

Thanks for your suggestions
Well i got the desired output... i made the following changes

public static StringBuffer buf= new StringBuffer();
    @Override
public void handleText(char[] data, int pos){
        PrintStream out = null;

            String d= new String(data);
             buf.append(data);
              buf.append("\n");
              
            System.out.println(d); 
            
}

append the data to Stringbuffer and write to a file in one go.

[Winston Gutkowski]

Prasad Rooge wrote:Well i got the desired output... i made the following changes...append the data to Stringbuffer and write to a file in one go.

Hmmm. Not the best I suspect, because all that appears to do is duplicate the input; but if it works...

A few tips for you:

1. Avoid static variables. They are almost invariably evil.

2. Write methods that do one thing.

3. Write methods that return something useful. That is to say: apart from things like setters (and main() of course), avoid writing methods that have void in the signature. Methods that return something can be combined with others, or used in assignments, which increases cohesion; usually a good thing.

For example, your handleText() method could look something like:

public String handleText(String healthCareURL, char[] data) {
   String oldHtml = Jsoup.connect(healthCareURL).get().html();
   StringBuilder buf = new StringBuilder(oldHtml);
   buf.append(data);
   buf.append("\n");
   return buf.toString;
}

which would then hand you back a String containing all the stuff in your healthcare file, plus whatever you passed in 'data'; and furthermore, it's completely self-contained. BTW, I removed the 'pos' parameter, because you don't appear to use it.

It's just one possibility though; and there may well be far better ones.

HIH

Winston