Console input menue unresponsive on recall

[Marcus Rauchfuss]

Hi all,

as part of the O'Reilly School Java 3 course I am currently tackling homework for a small I/O-program with console input.

Right now, only the part when you enter "E" or "e" on the console is implemented and the issue I am trying to tackle is described in the comment starting at line 38:

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
import java.util.Vector;
import java.io.File;
import java.io.FileReader;
import java.io.FileWriter;
import java.io.IOException;
import java.io.PrintWriter;
import java.lang.reflect.InvocationTargetException;
import java.util.Scanner;


 
public class StringFileWriter {
	
	
	
	static File theFile;

	private static Vector <String> theStrings = new Vector<String>(4);
	static //static String anInputString;
	Scanner scanner = new Scanner(System.in);
	
	public static void EnterOnTheConsole() {
		ConsoleMenue cm = new ConsoleMenue();
		


        InputStreamReader isr = new InputStreamReader(System.in);
        BufferedReader br = new BufferedReader(isr);

         try {
              String line = null;
              while (!(line = br.readLine()).equals("")){
              theStrings.add(line);
         }
           /*THE METHOD DOES NOT WORK PROPERLY HERE ANYMORE
            * The Message
            * (E)nter text, (S)ave text, (R)ead text, or (Q)uit:
			* (Enter a blank line to return to this menue.)
			* is displayed, but the input is not passed on and the program does not react
            */
              
          cm.consoleMenue(); 
            	

      }
      catch(IOException e){
          e.printStackTrace();
      }

        
  }
	
public static void writeToFile(){
	System.out.println("Saving to file!");
}

public static void readFromFile(){
	
}

public static void quitProgram(){
	
}
/*
public static void menueOutput(){
	
	System.out.println("(E)nter text, (S)ave text, (R)ead text, or (Q)uit:");
	System.out.println("(Enter a blank line to return to this menue.)");
	String anInputString = scanner.nextLine();
	setC( anInputString.charAt(0));
}
*/

/*
public static void createFile() throws InvocationTargetException {
    try {
        File dirFile = theFile.getParentFile();
        if (dirFile != null) {
            dirFile.mkdirs();
        }
        theFile.createNewFile();
    } catch (IOException e) {
        throw new InvocationTargetException(e);
    }
}
*/
  public static void main(String[] args) throws InvocationTargetException {
	 ConsoleMenue cMenue = new ConsoleMenue();
	  
 /*
	System.out.println("(E)nter text, (S)ave text, (R)ead text, or (Q)uit:");
	System.out.println("(Enter a blank line to return to this menue.)");
	String anInputString = scanner.nextLine();
	setC( anInputString.charAt(0));
	*/
	 // createFile();
	  cMenue.consoleMenue();
	
	if (cMenue.getC() == 'E'||cMenue.getC() =='e'){
		System.out.println("Enter!");
		//here comes some action
		
		
		
	}
	
	
	
	if (cMenue.getC() == 'S'||cMenue.getC() =='s'){
		System.out.println("Save!");
		writeToFile();

		
		//here comes some action
		
		
	}
	
	if (cMenue.getC() == 'R'||cMenue.getC() =='r'){
		System.out.println("Read!");

		
		//here comes some action
		
		
	}
	
	if (cMenue.getC() == 'Q'||cMenue.getC() =='q'){
		
		quitProgram();
		System.out.println("Quit!");

		//here comes some action
		
		
	}
	}
	
	
	
	
	
	
  }
  

and the other class which is referenced:

import java.util.Scanner;

public class ConsoleMenue {
	Scanner consoleScanner  = new Scanner(System.in);
	
	private char c;

	public char getC() {
		return c;
	}

	public void setC(char c) {
		this.c = c;
	}
	public void consoleMenue(){
		System.out.println("(E)nter text, (S)ave text, (R)ead text, or (Q)uit:");
		System.out.println("(Enter a blank line to return to this menue.)");
		String anInputString = consoleScanner.nextLine();
		setC( anInputString.charAt(0));
	}

}

Any hint on how to solve this issue with the unresponsive input would be highly appreciated :-)

[Carey Brown]

I don't see where you call EnterOnTheConsole(), which should begin with a lower case. Use ArrayList<String> and not Vector<String>.

[Marcus Rauchfuss]

Uuups, sorry about this, here's the corrected version (I prefer working with vector, for some reason)

enterOnTheConsole() is inserted on line 105 :-)

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
import java.util.Vector;
import java.io.File;
import java.io.FileReader;
import java.io.FileWriter;
import java.io.IOException;
import java.io.PrintWriter;
import java.lang.reflect.InvocationTargetException;
import java.util.Scanner;


 
public class StringFileWriter {
	
	
	
	static File theFile;

	private static Vector <String> theStrings = new Vector<String>(4);
	static //static String anInputString;
	Scanner scanner = new Scanner(System.in);
	
	public static void enterOnTheConsole() {
		ConsoleMenue cm = new ConsoleMenue();
		


        InputStreamReader isr = new InputStreamReader(System.in);
        BufferedReader br = new BufferedReader(isr);

         try {
              String line = null;
              while (!(line = br.readLine()).equals("")){
              theStrings.add(line);
         }
           /*THE METHOD DOES NOT WORK PROPERLY HERE ANYMORE
            * The Message
            * (E)nter text, (S)ave text, (R)ead text, or (Q)uit:
			* (Enter a blank line to return to this menue.)
			* is printed out, but the input is not passed on
            */
              
          //   cm.consoleMenue(); 
            	

      }
      catch(IOException e){
          e.printStackTrace();
      }

         cm.consoleMenue();
  }
	
public static void writeToFile(){
	System.out.println("Saving to file!");
}

public static void readFromFile(){
	
}

public static void quitProgram(){
	
}
/*
public static void menueOutput(){
	
	System.out.println("(E)nter text, (S)ave text, (R)ead text, or (Q)uit:");
	System.out.println("(Enter a blank line to return to this menue.)");
	String anInputString = scanner.nextLine();
	setC( anInputString.charAt(0));
}
*/

/*
public static void createFile() throws InvocationTargetException {
    try {
        File dirFile = theFile.getParentFile();
        if (dirFile != null) {
            dirFile.mkdirs();
        }
        theFile.createNewFile();
    } catch (IOException e) {
        throw new InvocationTargetException(e);
    }
}
*/
  public static void main(String[] args) throws InvocationTargetException {
	 ConsoleMenue cMenue = new ConsoleMenue();
	  
 /*
	System.out.println("(E)nter text, (S)ave text, (R)ead text, or (Q)uit:");
	System.out.println("(Enter a blank line to return to this menue.)");
	String anInputString = scanner.nextLine();
	setC( anInputString.charAt(0));
	*/
	 // createFile();
	  cMenue.consoleMenue();
	
	if (cMenue.getC() == 'E'||cMenue.getC() =='e'){
		System.out.println("Enter!");
 
		enterOnTheConsole();
		//here comes some action
		
		
		
	}
	
	
	
	if (cMenue.getC() == 'S'||cMenue.getC() =='s'){
		System.out.println("Save!");
		writeToFile();

		
		//here comes some action
		
		
	}
	
	if (cMenue.getC() == 'R'||cMenue.getC() =='r'){
		System.out.println("Read!");

		
		//here comes some action
		
		
	}
	
	if (cMenue.getC() == 'Q'||cMenue.getC() =='q'){
		
		quitProgram();
		System.out.println("Quit!");

		//here comes some action
		
		
	}
	}
	
	
	
	
	
	
  }
  

[Carey Brown]

I think your call to enterOnTheConsole() is giving you grief. Comment out line 105. Also, your call to anInputString.charAt(0) will throw an exception if you press enter (ie a blank line). Put a loop around all the lines in your main() with a test for a 'Q' that will break out of the loop. Your scanner member variable is never used because you never create an instance of your StringFileWriter class.

Vector predates ArrayList but has not been deprecated because it serves a very narrow function, specifically multi-threaded access to the same list instance. Otherwise, use ArrayList.