Java Mail problem

[Wim Van Geyt]

Hi everyone,

i have two classes wich one does a check for contracts that are overdue and one class that sends an email to warn the user that the conract will be expired.

When i only use the class that sends the mail, that class works fine and sends a mail.
But when i use the first class that checks the contracts and calls the Mailing class, the mail won't be sended.

Can anyone help me and say what is wrong with the first class or is it something with the call to the Mailing class?

here is the first class "Warning.java

import java.sql.*;
import java.text.*;
import java.util.Date;



public class Warning
{
	private static Connection con;
	private static Statement stmt;
	private static String startdate, endDate, currentDate, messages, query, contractNr, during, subject;
	private static String period, year, threeYears, fiveYears;
	private static int yeaR,threeYearss,fiveYearss, periode;
	
	public static void main(String[] args)
	{
	
		ResultSet rs;
		
		DateTimeTest dateTimeTest = new DateTimeTest();
		Mailing mailing = new Mailing();
		
		DateFormat formatter = new SimpleDateFormat("dd/MM/yyyy");
		Date date = new Date();
		currentDate = formatter.format(date);
		
		//System.out.println(currentDate);
		try{
			 
			Class.forName("com.mysql.jdbc.Driver");
			con = DriverManager.getConnection("jdbc:mysql://127.0.0.1:3306/contracts", "root", "Minidisc1");
			
			query= "select * from contracts.generallist";
			
			stmt = con.createStatement();
			rs = stmt.executeQuery(query);
			
			while (rs.next())
			{
				startdate = rs.getString("StartDate");
				endDate = rs.getString("endDate");
				contractNr = rs.getString("contract_id");
				during = rs.getString("during");
				period = dateTimeTest.getDays(startdate, currentDate).toString();
				/*year ="180";
				threeYears ="900";
				fiveYears ="1620";*/
				
				year ="180";
				threeYears ="900";
				fiveYears ="1620";
				
				yeaR = Integer.parseInt(year);
				threeYearss = Integer.parseInt(threeYears);
				fiveYearss = Integer.parseInt(fiveYears);
				periode = Integer.parseInt(period);
				
				if(periode >= yeaR)
				{
					subject = "Waarschuwing einde contract: " +contractNr+".";
					messages = "Het contract met nr: "+contractNr+" eindigt op datum: "+ endDate;
					mailing.getMail(messages, subject);
					
				}else if(periode >= threeYearss)
				{
					subject = "waarschuwing einde contract: " +contractNr+".";
					messages = "Het contract met nr: "+contractNr+" eindigt op datum: "+ endDate;
					mailing.getMail(messages, subject);
				}else if(periode >= fiveYearss)
				{
					subject = "waarschuwing einde contract: " +contractNr+".";
					messages = "Het contract met nr: "+contractNr+" eindigt op datum: "+ endDate;
					mailing.getMail(messages, subject);
				}
				
				System.out.println(startdate + " - "+ endDate +" - "+contractNr+" - "+ during+ " -"+ period);
			}
			
		
			/*rs.close();
		      stmt.close();
		      con.close();*/
		   }catch(SQLException se){
		      //Handle errors for JDBC
		      se.printStackTrace();
		   }catch(Exception e){
		      //Handle errors for Class.forName
		      e.printStackTrace();
		   }finally{
		      //finally block used to close resources
		      try{
		         if(stmt!=null)
		            stmt.close();
		      }catch(SQLException se2){}// nothing we can do
		      try{
		         if(con!=null)
		            con.close();
		      }catch(SQLException se){
		         se.printStackTrace();
		      }
		   
		   }
	}
}

Next is the Mailing.java class:

import java.util.*;

import javax.mail.*;
import javax.mail.internet.*;


public class Mailing
{

	public Mailing()
	{
		
		
	}
	public void getMail(String messages,String subject)
	{
		final String username = "[e-mail]";
		final String password = "Minidisc";
 
		Properties props = new Properties();
		props.put("mail.smtp.auth", "true");
		props.put("mail.smtp.starttls.enable", "true");
		props.put("mail.smtp.host", "smtp.gmail.com");
		props.put("mail.smtp.port", "587");
 
		Session session = Session.getInstance(props,
		  new javax.mail.Authenticator() {
			protected PasswordAuthentication getPasswordAuthentication() {
				return new PasswordAuthentication(username, password);
			}
		  });
 
		try {
 
			Message message = new MimeMessage(session);
			message.setFrom(new InternetAddress("[e-mail]"));
			message.setRecipients(Message.RecipientType.TO,
				InternetAddress.parse("[e-mail]"));
			message.setSubject(subject);
			message.setText(messages);
 
			Transport.send(message);
 
			System.out.println("Done");
 
		} catch (MessagingException e) {
			throw new RuntimeException(e);
		}
	
	}
	
	
}

[Tushar Goel]

How to know contract is expired? Also, why you defined all the variables as static when you can define as local. It would be more simpler than.

[Wim Van Geyt]

Tushar Goel wrote:How to know contract is expired? Also, why you defined all the variables as static when you can define as local. It would be more simpler than.

All the contracts have a during of 1, or 3 or 5 years.
So the email message has to be sended 6 months before the contract is expired.
It's based on the periode that's stored as a column in the database.

I set the variables at the top, so i can use them everywhere.

Wim

[Knute Snortum]

You might want to put System.out.println at lines 62, 68, and 73 to make sure that Mailing was called at all.

[Tushar Goel]

I need more details to help you.. like what does "180" or other means.. Also put some debugger statement to debug easily.

Secondly you are writing everything in main. So you can define it too. Otherwise, it is bad practice to write that long into the main method.
It should be spilt into small methods.

[Campbell Ritchie]

Too difficult for this forum: moving.

[Wim Van Geyt]

Tushar Goel wrote:I need more details to help you.. like what does "180" or other means.. Also put some debugger statement to debug easily.

Secondly you are writing everything in main. So you can define it too. Otherwise, it is bad practice to write that long into the main method.
It should be spilt into small methods.

The variables yeaR, threeYears and fiveYears are the day when the contract is at 6 months before the expire date.
Everything is counted in days.

I 've also set the String variables to integer so i can say that every day from 180 day and behind these 180 days there has to be send an email.



Wim