Java Code Enhancement Needed

[Jeansonne Pierre]

Hi Guys,

Kindly need your expertise here to enhanced my code as below,
because my amateur Java level now is stopping me to improve this code.

Question:
1) Seems like i'm using a lot of dummy method. Any advanced/fancy way to recode it?
2) Please correct any mistake that causing performance issue in this code.

prerequisite: **Global Variable with the @Getter @Setter cannot be changed**


Thanks in advanced, your help is much appreciated.

package com.sg.portal.web.queue.statistics;

import com.sg.portal.web.queue.obj.AchReturnedView;
import com.sg.rc.db.model.loanapp.LoanApp;
import com.sg.rc.db.model.loanapp.info.payment.LoanInfoRepaymentHistory;
import lombok.Getter;
import lombok.Setter;

import java.math.MathContext;
import java.math.RoundingMode;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Date;
import java.util.List;
import java.math.BigDecimal;


public class StatisticsFacadeImpl implements StatisticsFacade {


    @Getter @Setter private List<AchReturnedView> achPaylianceReturnedViewList;
    @Getter @Setter private List<AchReturnedView> achPdsReturnedViewList;
    @Getter @Setter private BigDecimal administrativeReturnedPercentage;
    @Getter @Setter private BigDecimal unauthorizedReturnedPercentage;
    @Getter @Setter private BigDecimal authorizedReturnedPercentage;
    @Getter @Setter private BigDecimal returnedPercentage;
    @Getter @Setter private BigDecimal pendingPercentage;
    @Getter @Setter private BigDecimal checkedPercentage;
    @Getter @Setter private long totalPayment;
    @Getter @Setter private long totalCheckedPayment;
    @Getter @Setter private long totalPendingPayment;
    @Getter @Setter private long totalReturnedPayment;
    @Getter @Setter private BigDecimal administrativePaylianceReturnedPercentage;
    @Getter @Setter private BigDecimal unauthorizedPaylianceReturnedPercentage;
    @Getter @Setter private BigDecimal authorizedPaylianceReturnPercentage;
    @Getter @Setter private BigDecimal returnedPayliancePercentage;
    @Getter @Setter private BigDecimal pendingPayliancePercentage;
    @Getter @Setter private BigDecimal checkedPayliancePercentage;
    @Getter @Setter private BigDecimal paylianceR02Percentage;
    @Getter @Setter private BigDecimal paylianceR03Percentage;
    @Getter @Setter private BigDecimal paylianceR04Percentage;
    @Getter @Setter private BigDecimal paylianceR05Percentage;
    @Getter @Setter private BigDecimal paylianceR07Percentage;
    @Getter @Setter private BigDecimal paylianceR10Percentage;
    @Getter @Setter private BigDecimal paylianceR29Percentage;
    @Getter @Setter private BigDecimal paylianceR51Percentage;
    @Getter @Setter private long totalPayliancePayment;
    @Getter @Setter private long totalPaylianceCheckedPayment;
    @Getter @Setter private long totalPayliancePendingPayment;
    @Getter @Setter private long totalPaylianceReturnedPayment;
    @Getter @Setter private long totalPaylianceR02Code;
    @Getter @Setter private long totalPaylianceR03Code;
    @Getter @Setter private long totalPaylianceR04Code;
    @Getter @Setter private long totalPaylianceR05Code;
    @Getter @Setter private long totalPaylianceR07Code;
    @Getter @Setter private long totalPaylianceR10Code;
    @Getter @Setter private long totalPaylianceR29Code;
    @Getter @Setter private long totalPaylianceR51Code;
    @Getter @Setter private BigDecimal administrativePdsReturnedPercentage;
    @Getter @Setter private BigDecimal unauthorizedPdsReturnedPercentage;
    @Getter @Setter private BigDecimal authorizedPdsReturnedPercentage;
    @Getter @Setter private BigDecimal returnedPdsPercentage;
    @Getter @Setter private BigDecimal pendingPdsPercentage;
    @Getter @Setter private BigDecimal checkedPdsPercentage;
    @Getter @Setter private BigDecimal pdsR02Percentage;
    @Getter @Setter private BigDecimal pdsR03Percentage;
    @Getter @Setter private BigDecimal pdsR04Percentage;
    @Getter @Setter private BigDecimal pdsR05Percentage;
    @Getter @Setter private BigDecimal pdsR07Percentage;
    @Getter @Setter private BigDecimal pdsR10Percentage;
    @Getter @Setter private BigDecimal pdsR29Percentage;
    @Getter @Setter private BigDecimal pdsR51Percentage;
    @Getter @Setter private long totalPdsPayment;
    @Getter @Setter private long totalPdsCheckedPayment;
    @Getter @Setter private long totalPdsPendingPayment;
    @Getter @Setter private long totalPdsReturnedPayment;
    @Getter @Setter private long totalPdsR02Code;
    @Getter @Setter private long totalPdsR03Code;
    @Getter @Setter private long totalPdsR04Code;
    @Getter @Setter private long totalPdsR05Code;
    @Getter @Setter private long totalPdsR07Code;
    @Getter @Setter private long totalPdsR10Code;
    @Getter @Setter private long totalPdsR29Code;
    @Getter @Setter private long totalPdsR51Code;
    @Getter @Setter private BigDecimal administrativeCcReturnedPercentage;
    @Getter @Setter private BigDecimal unauthorizedCcReturnedPercentage;
    @Getter @Setter private BigDecimal authorizedCcReturnedPercentage;
    @Getter @Setter private BigDecimal returnedCcPercentage;
    @Getter @Setter private BigDecimal pendingCcPercentage;
    @Getter @Setter private BigDecimal checkedCcPercentage;
    @Getter @Setter private long totalCcPayment;
    @Getter @Setter private long totalCcCheckedPayment;
    @Getter @Setter private long totalCcPendingPayment;
    @Getter @Setter private long totalCcReturnedPayment;
    @Getter @Setter private long totalCcR01Code;
    @Getter @Setter private long totalCcR02Code;
    @Getter @Setter private long totalCcR03Code;
    @Getter @Setter private long totalCcR04Code;
    @Getter @Setter private long totalCcR05Code;
    @Getter @Setter private long totalCcR07Code;
    @Getter @Setter private long totalCcR10Code;
    @Getter @Setter private long totalCcR29Code;
    @Getter @Setter private long totalCcR51Code;
    @Getter @Setter private long totalR02Code;
    @Getter @Setter private long totalR03Code;
    @Getter @Setter private long totalR04Code;
    @Getter @Setter private long totalR05Code;
    @Getter @Setter private long totalR07Code;
    @Getter @Setter private long totalR10Code;
    @Getter @Setter private long totalR29Code;
    @Getter @Setter private long totalR51Code;



    /**
     * **************************************************************************************************************
     * Overall Calculation
     * **************************************************************************************************************
     */
    @Override
    public void setAdministrativeReturnPercentage(){

        BigDecimal totalAdministrativeReturn = getBigDecimal(totalR02Code + totalR03Code + totalR04Code);
        BigDecimal totalAchPayment = getBigDecimal(this.totalPayment);
        administrativeReturnedPercentage = getPercentage(totalAdministrativeReturn,totalAchPayment);
    }

    @Override
    public void setUnauthorizedReturnPercentage(){

        BigDecimal totalUnauthorizedReturn = getBigDecimal(totalR05Code + totalR07Code + totalR10Code +
                totalR29Code + totalR51Code);
        BigDecimal totalAchPayment = getBigDecimal(this.totalPayment);
        unauthorizedReturnedPercentage = getPercentage(totalUnauthorizedReturn,totalAchPayment);
    }

    @Override
    public void setReturnedPercentage() {

        BigDecimal totalRejectedPayment = getBigDecimal(this.totalReturnedPayment);
        BigDecimal totalAchPayment = getBigDecimal(this.totalPayment);
        returnedPercentage = getPercentage(totalRejectedPayment, totalAchPayment);
    }

    @Override
    public void setPendingPercentage() {

        BigDecimal totalPendingPayment = getBigDecimal(this.totalPendingPayment);
        BigDecimal totalAchPayment = getBigDecimal(this.totalPayment);
        pendingPercentage = getPercentage(totalPendingPayment, totalAchPayment);
    }

    @Override
    public void setCheckedPercentage() {

        BigDecimal totalCheckedPayment = getBigDecimal(this.totalCheckedPayment);
        BigDecimal totalAchPayment = getBigDecimal(this.totalPayment);
        checkedPercentage = getPercentage(totalCheckedPayment, totalAchPayment);
    }

    /**
     * **************************************************************************************************************
     * Payliance Calculation
     * **************************************************************************************************************
     */
    @Override
    public void setPaylianceAdministrativeReturnPercentage() {

        BigDecimal totalPaylianceAdministrativeReturn = getBigDecimal(totalPaylianceR02Code + totalPaylianceR03Code +
                totalPaylianceR04Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        administrativePaylianceReturnedPercentage = getPercentage(totalPaylianceAdministrativeReturn,totalPayliancePayment);
    }

    @Override
    public void setPaylianceUnauthorizedReturnPercentage() {

        BigDecimal totalPaylianceUnauthorizedReturn = getBigDecimal(totalPaylianceR05Code + totalPaylianceR07Code +
                totalPaylianceR10Code + totalPaylianceR29Code + totalPaylianceR51Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        unauthorizedPaylianceReturnedPercentage = getPercentage(totalPaylianceUnauthorizedReturn,totalPayliancePayment);
    }

    @Override
    public void setPaylianceReturnedPercentage() {
        BigDecimal totalPaylianceRejectedPayment = getBigDecimal(this.totalPaylianceReturnedPayment);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        returnedPayliancePercentage = getPercentage(totalPaylianceRejectedPayment,totalPayliancePayment);
    }

    @Override
    public void setPaylianceCheckedPercentage() {
        BigDecimal totalPaylianceCheckedPayment = getBigDecimal(this.totalPaylianceCheckedPayment);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        checkedPayliancePercentage = getPercentage(totalPaylianceCheckedPayment,totalPayliancePayment);
    }

    @Override
    public void setPayliancePendingPercentage() {
        BigDecimal totalPayliancePendingPayment = getBigDecimal(this.totalPayliancePendingPayment);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        pendingPayliancePercentage = getPercentage(totalPayliancePendingPayment,totalPayliancePayment);
    }

    /**
     * **************************************************************************************************************
     * PDS Calculation
     * **************************************************************************************************************
     */
    @Override
    public void setPdsAdministrativeReturnPercentage() {

        BigDecimal totalPdsAdministrativeReturn = getBigDecimal(totalPdsR02Code + totalPdsR03Code +
                totalPdsR04Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        administrativePdsReturnedPercentage = getPercentage(totalPdsAdministrativeReturn,totalPdsPayment);

    }

    @Override
    public void setPdsUnauthorizedReturnPercentage() {

        BigDecimal totalPdsUnauthorizedReturn = getBigDecimal(totalPdsR05Code + totalPdsR07Code +
                totalPdsR10Code + totalPdsR29Code + totalPdsR51Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        unauthorizedPdsReturnedPercentage = getPercentage(totalPdsUnauthorizedReturn,totalPdsPayment);
    }

    @Override
    public void setPdsReturnedPercentage() {
        BigDecimal totalPdsRejectedPayment = getBigDecimal(this.totalPdsReturnedPayment);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        returnedPdsPercentage = getPercentage(totalPdsRejectedPayment,totalPdsPayment);
    }

    @Override
    public void setPdsCheckedPercentage() {
        BigDecimal totalPdsCheckedPayment = getBigDecimal(this.totalPdsCheckedPayment);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        checkedPdsPercentage = getPercentage(totalPdsCheckedPayment,totalPdsPayment);
    }

    @Override
    public void setPdsPendingPercentage() {
        BigDecimal totalPdsPendingPayment = getBigDecimal(this.totalPdsPendingPayment);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        pendingPdsPercentage = getPercentage(totalPdsPendingPayment,totalPdsPayment);
    }

    /**
     * **************************************************************************************************************
     * CC Calculation
     * **************************************************************************************************************
     */
    @Override
    public void setCcAdministrativeReturnPercentage() {

        BigDecimal totalCcAdministrativeReturn = getBigDecimal(totalCcR02Code + totalCcR03Code +
                totalCcR04Code);
        BigDecimal totalCcPayment = getBigDecimal(this.totalCcPayment);
        administrativeCcReturnedPercentage = getPercentage(totalCcAdministrativeReturn,totalCcPayment);
    }

    @Override
    public void setCcUnauthorizedReturnPercentage() {

        BigDecimal totalCcUnauthorizedReturn = getBigDecimal(totalCcR05Code + totalCcR07Code +
                totalCcR10Code + totalCcR29Code + totalCcR51Code);
        BigDecimal totalCcPayment = getBigDecimal(this.totalCcPayment);
        unauthorizedCcReturnedPercentage = getPercentage(totalCcUnauthorizedReturn,totalCcPayment);
    }

    @Override
    public void setCcReturnedPercentage() {
        BigDecimal totalCcRejectedPayment = getBigDecimal(this.totalCcReturnedPayment);
        BigDecimal totalCcPayment = getBigDecimal(this.totalCcPayment);
        returnedCcPercentage = getPercentage(totalCcRejectedPayment,totalCcPayment);
    }

    @Override
    public void setCcCheckedPercentage() {
        BigDecimal totalCcCheckedPayment = getBigDecimal(this.totalCcCheckedPayment);
        BigDecimal totalCcPayment = getBigDecimal(this.totalCcPayment);
        checkedCcPercentage = getPercentage(totalCcCheckedPayment,totalCcPayment);
    }

    @Override
    public void setCcPendingPercentage() {
        BigDecimal totalCcPendingPayment = getBigDecimal(this.totalCcPendingPayment);
        BigDecimal totalCcPayment = getBigDecimal(this.totalCcPayment);
        pendingCcPercentage = getPercentage(totalCcPendingPayment,totalCcPayment);
    }

    /**
     * **************************************************************************************************************
     * R02, R03, R04, R05, R07, R10, R29, R51 Calculation
     * **************************************************************************************************************
     */

    @Override
    public void setPaylianceR02Percentage() {
        BigDecimal totalPaylianceR02Code = getBigDecimal(this.totalPaylianceR02Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        paylianceR02Percentage = getPercentage(totalPaylianceR02Code,totalPayliancePayment);
    }

    @Override
    public void setPaylianceR03Percentage() {
        BigDecimal totalPaylianceR03Code = getBigDecimal(this.totalPaylianceR03Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        paylianceR03Percentage = getPercentage(totalPaylianceR03Code,totalPayliancePayment);
    }

    @Override
    public void setPaylianceR04Percentage() {
        BigDecimal totalPaylianceR04Code = getBigDecimal(this.totalPaylianceR04Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        paylianceR04Percentage = getPercentage(totalPaylianceR04Code,totalPayliancePayment);
    }

    @Override
    public void setPdsR02Percentage() {
        BigDecimal totalPdsR02Code = getBigDecimal(this.totalPdsR02Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        pdsR02Percentage = getPercentage(totalPdsR02Code,totalPdsPayment);
    }

    @Override
    public void setPdsR03Percentage() {
        BigDecimal totalPdsR03Code = getBigDecimal(this.totalPdsR03Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        pdsR03Percentage = getPercentage(totalPdsR03Code,totalPdsPayment);
    }

    @Override
    public void setPdsR04Percentage() {
        BigDecimal totalPdsR04Code = getBigDecimal(this.totalPdsR04Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        pdsR04Percentage = getPercentage(totalPdsR04Code,totalPdsPayment);
    }

    @Override
    public void setPaylianceR05Percentage() {
        BigDecimal totalPaylianceR05Code = getBigDecimal(this.totalPaylianceR05Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        paylianceR05Percentage = getPercentage(totalPaylianceR05Code,totalPayliancePayment);
    }

    @Override
    public void setPaylianceR07Percentage() {
        BigDecimal totalPaylianceR07Code = getBigDecimal(this.totalPaylianceR07Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        paylianceR07Percentage = getPercentage(totalPaylianceR07Code,totalPayliancePayment);
    }

    @Override
    public void setPaylianceR10Percentage() {
        BigDecimal totalPaylianceR10Code = getBigDecimal(this.totalPaylianceR10Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        paylianceR10Percentage = getPercentage(totalPaylianceR10Code,totalPayliancePayment);
    }

    @Override
    public void setPaylianceR29Percentage() {
        BigDecimal totalPaylianceR29Code = getBigDecimal(this.totalPaylianceR29Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        paylianceR29Percentage = getPercentage(totalPaylianceR29Code,totalPayliancePayment);
    }

    @Override
    public void setPaylianceR51Percentage() {
        BigDecimal totalPaylianceR51Code = getBigDecimal(this.totalPaylianceR51Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        paylianceR51Percentage = getPercentage(totalPaylianceR51Code,totalPayliancePayment);
    }

    @Override
    public void setPdsR05Percentage() {
        BigDecimal totalPdsR05Code = getBigDecimal(this.totalPdsR05Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        pdsR05Percentage = getPercentage(totalPdsR05Code,totalPdsPayment);
    }

    @Override
    public void setPdsR07Percentage() {
        BigDecimal totalPdsR07Code = getBigDecimal(this.totalPdsR07Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        pdsR07Percentage = getPercentage(totalPdsR07Code,totalPdsPayment);
    }

    @Override
    public void setPdsR10Percentage() {
        BigDecimal totalPdsR10Code = getBigDecimal(this.totalPdsR10Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        pdsR10Percentage = getPercentage(totalPdsR10Code,totalPdsPayment);
    }

    @Override
    public void setPdsR29Percentage() {
        BigDecimal totalPdsR29Code = getBigDecimal(this.totalPdsR29Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        pdsR29Percentage = getPercentage(totalPdsR29Code,totalPdsPayment);
    }

    @Override
    public void setPdsR51Percentage() {
        BigDecimal totalPdsR51Code = getBigDecimal(this.totalPdsR51Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        pdsR51Percentage = getPercentage(totalPdsR51Code,totalPdsPayment);
    }


    /**
     * **************************************************************************************************************
     * Facade Selector
     * **************************************************************************************************************
     */
    public void setTotalPercentage(){
        setCheckedPercentage();
        setReturnedPercentage();
        setPendingPercentage();
        setAdministrativeReturnPercentage();
        setUnauthorizedReturnPercentage();
        setPaylianceAdministrativeReturnPercentage();
        setPaylianceUnauthorizedReturnPercentage();
        setPaylianceReturnedPercentage();
        setPaylianceCheckedPercentage();
        setPayliancePendingPercentage();
        setPdsAdministrativeReturnPercentage();
        setPdsUnauthorizedReturnPercentage();
        setPdsReturnedPercentage();
        setPdsCheckedPercentage();
        setPdsPendingPercentage();
        setCcAdministrativeReturnPercentage();
        setCcUnauthorizedReturnPercentage();
        setCcReturnedPercentage();
        setCcCheckedPercentage();
        setCcPendingPercentage();
        setTotalReturnedPercentage();
    }

    public void setTotalReturnedPercentage(){

        setPaylianceR02Percentage();
        setPaylianceR03Percentage();
        setPaylianceR04Percentage();
        setPaylianceR05Percentage();
        setPaylianceR07Percentage();
        setPaylianceR10Percentage();
        setPaylianceR29Percentage();
        setPaylianceR51Percentage();
        setPdsR02Percentage();
        setPdsR03Percentage();
        setPdsR04Percentage();
        setPdsR05Percentage();
        setPdsR07Percentage();
        setPdsR10Percentage();
        setPdsR29Percentage();
        setPdsR51Percentage();
        setAchReturnedViewListPercentage();

    }

    /**
     * **************************************************************************************************************
     * Facade Calculation
     * **************************************************************************************************************
     */

    private BigDecimal getBigDecimal(long volume){

        return new BigDecimal(volume);
    }

    private BigDecimal getPercentage(BigDecimal numerator, BigDecimal denominator) {

        if(numerator.compareTo(BigDecimal.ZERO)==0){
            return BigDecimal.ZERO;
        }
        else{
            MathContext mathContext = new MathContext(10, RoundingMode.HALF_EVEN);
            BigDecimal percentage = numerator.divide(denominator, mathContext).
                    multiply(new BigDecimal("100"), mathContext);
            return percentage.setScale(2, BigDecimal.ROUND_HALF_EVEN);
        }
    }

    private int compareDate(Date before, Date after) {

        try {
            if (before.compareTo(after) > 0) {return 1;}
            else if (before.compareTo(after) < 0) {return -1;}
            else if (before.compareTo(after) == 0) {return 0;}
            else {return 2;}
        } catch (Exception ex) {ex.printStackTrace();return 3;}
    }

    private void setAchReturnedViewListPercentage(){

        achPaylianceReturnedViewList = new ArrayList<>();
        achPdsReturnedViewList = new ArrayList<>();

        achPaylianceReturnedViewList.add(new AchReturnedView("R02","Payliance","unauthorized",totalPaylianceR02Code, paylianceR02Percentage));
        achPaylianceReturnedViewList.add(new AchReturnedView("R03","Payliance","unauthorized",totalPaylianceR03Code, paylianceR03Percentage));
        achPaylianceReturnedViewList.add(new AchReturnedView("R04","Payliance","unauthorized",totalPaylianceR04Code, paylianceR04Percentage));
        achPaylianceReturnedViewList.add(new AchReturnedView("R05","Payliance","administrative",totalPaylianceR05Code, paylianceR05Percentage));
        achPaylianceReturnedViewList.add(new AchReturnedView("R07","Payliance","administrative",totalPaylianceR07Code, paylianceR07Percentage));
        achPaylianceReturnedViewList.add(new AchReturnedView("R10","Payliance","administrative",totalPaylianceR10Code, paylianceR10Percentage));
        achPaylianceReturnedViewList.add(new AchReturnedView("R29","Payliance","administrative",totalPaylianceR29Code, paylianceR29Percentage));
        achPaylianceReturnedViewList.add(new AchReturnedView("R51","Payliance","administrative",totalPaylianceR51Code, paylianceR51Percentage));

        achPdsReturnedViewList.add(new AchReturnedView("R02","Pds","unauthorized",totalPdsR02Code, pdsR02Percentage));
        achPdsReturnedViewList.add(new AchReturnedView("R03","Pds","unauthorized",totalPdsR03Code, pdsR03Percentage));
        achPdsReturnedViewList.add(new AchReturnedView("R04","Pds","unauthorized",totalPdsR04Code, pdsR04Percentage));
        achPdsReturnedViewList.add(new AchReturnedView("R05","Pds","administrative",totalPdsR05Code, pdsR05Percentage));
        achPdsReturnedViewList.add(new AchReturnedView("R07","Pds","administrative",totalPdsR07Code, pdsR07Percentage));
        achPdsReturnedViewList.add(new AchReturnedView("R10","Pds","administrative",totalPdsR10Code, pdsR10Percentage));
        achPdsReturnedViewList.add(new AchReturnedView("R29","Pds","administrative",totalPdsR29Code, pdsR29Percentage));
        achPdsReturnedViewList.add(new AchReturnedView("R51","Pds","administrative",totalPdsR51Code, pdsR51Percentage));

    }

    private void setVolumeByProcessorAndStatus(LoanInfoRepaymentHistory loanInfoRepaymentHistory, String processor){

        switch(processor.toLowerCase()){
            case "payliance":
                if (loanInfoRepaymentHistory.getPaymentStatus() != null) {
                    switch(loanInfoRepaymentHistory.getPaymentStatus()){
                        case LoanInfoRepaymentHistory.PAYMENT_STATUS_CHECKED:totalPaylianceCheckedPayment++;break;
                        case LoanInfoRepaymentHistory.PAYMENT_STATUS_PENDING:totalPayliancePendingPayment++;break;
                        case LoanInfoRepaymentHistory.PAYMENT_STATUS_REJECTED:
                            totalPaylianceReturnedPayment++;break;
                    }
                }
                break;
            case "pds":
                if (loanInfoRepaymentHistory.getPaymentStatus() != null) {
                    switch(loanInfoRepaymentHistory.getPaymentStatus()){
                        case LoanInfoRepaymentHistory.PAYMENT_STATUS_CHECKED:totalPdsCheckedPayment++;break;
                        case LoanInfoRepaymentHistory.PAYMENT_STATUS_PENDING:totalPdsPendingPayment++;break;
                        case LoanInfoRepaymentHistory.PAYMENT_STATUS_REJECTED:
                            totalPdsReturnedPayment++;break;
                    }
                }
                break;
            case "cc":
                if (loanInfoRepaymentHistory.getPaymentStatus() != null) {
                    switch(loanInfoRepaymentHistory.getPaymentStatus()){
                        case LoanInfoRepaymentHistory.PAYMENT_STATUS_CHECKED:totalCcCheckedPayment++;break;
                        case LoanInfoRepaymentHistory.PAYMENT_STATUS_PENDING:totalCcPendingPayment++;break;
                        case LoanInfoRepaymentHistory.PAYMENT_STATUS_REJECTED:
                            totalCcReturnedPayment++;break;
                    }
                }
                break;
        }
    }

    private void setVolumeByProcessorAndCode(LoanInfoRepaymentHistory loanInfoRepaymentHistory, String returnCode){

        switch(loanInfoRepaymentHistory.getProcessor().toLowerCase()){
            case "payliance":
                if (returnCode != null) {
                    switch(returnCode){
                        case "R02":totalPaylianceR02Code++;break;
                        case "R03":totalPaylianceR03Code++;break;
                        case "R04":totalPaylianceR04Code++;break;
                        case "R05":totalPaylianceR05Code++;break;
                        case "R07":totalPaylianceR07Code++;break;
                        case "R10":totalPaylianceR10Code++;break;
                        case "R29":totalPaylianceR29Code++;break;
                        case "R51":totalPaylianceR51Code++;break;
                    }
                }
                break;
            case "pds":
                if (returnCode != null) {
                    switch(returnCode){
                        case "R02":totalPdsR02Code++;break;
                        case "R03":totalPdsR03Code++;break;
                        case "R04":totalPdsR04Code++;break;
                        case "R05":totalPdsR05Code++;break;
                        case "R07":totalPdsR07Code++;break;
                        case "R10":totalPdsR10Code++;break;
                        case "R29":totalPdsR29Code++;break;
                        case "R51":totalPdsR51Code++;break;
                    }
                }
                break;
            case "cc":
                if (returnCode != null) {
                    switch(returnCode){
                        case "R01":totalCcR01Code++;break;
                        case "R02":totalCcR02Code++;break;
                        case "R03":totalCcR03Code++;break;
                        case "R04":totalCcR04Code++;break;
                        case "R05":totalCcR05Code++;break;
                        case "R07":totalCcR07Code++;break;
                        case "R10":totalCcR10Code++;break;
                        case "R29":totalCcR29Code++;break;
                        case "R51":totalCcR51Code++;break;
                    }
                }
                break;
        }
    }

    public String getHtmlDate(Date defaultDate){

        SimpleDateFormat simpleDateFormat = new SimpleDateFormat("yyyy-MM-dd");
        String htmlDate = simpleDateFormat.format(defaultDate);

        return htmlDate;
    }

    public void setTotalVolume(List<LoanApp> loanAppsList, List<String> listOfPaymentStatus, Date startDate, Date endDate) {

        for (LoanApp loanApp : loanAppsList) {
            List<LoanInfoRepaymentHistory> loanInfoRepaymentHistoriesList = loanApp.getInfo().getRepayment().getHistories();

            for (LoanInfoRepaymentHistory loanInfoRepaymentHistory : loanInfoRepaymentHistoriesList) {

                for (String paymentStatus : listOfPaymentStatus) {

                    if (loanInfoRepaymentHistory.getPaymentStatus().matches(paymentStatus)) {

                        if (compareDate(loanInfoRepaymentHistory.getEffectiveDate(), startDate) > 0 &&
                                compareDate(loanInfoRepaymentHistory.getEffectiveDate(), endDate) < 0) {

                            totalPayment++;

                            if (loanInfoRepaymentHistory.getPaymentStatus() != null) {
                                switch(loanInfoRepaymentHistory.getPaymentStatus()){
                                    case LoanInfoRepaymentHistory.PAYMENT_STATUS_CHECKED:totalCheckedPayment++;
                                        break;
                                    case LoanInfoRepaymentHistory.PAYMENT_STATUS_PENDING:totalPendingPayment++;
                                        break;
                                    case LoanInfoRepaymentHistory.PAYMENT_STATUS_REJECTED:
                                        totalReturnedPayment++;break;
                                    default:System.out.println("Unknown Status Found = "
                                            +loanInfoRepaymentHistory.getPaymentStatus());
                                        break;
                                }
                            }

                            if(loanInfoRepaymentHistory.getProcessor() != null) {
                                switch(loanInfoRepaymentHistory.getProcessor()){
                                    case LoanInfoRepaymentHistory.PROCESSOR_PAYLIANCE:totalPayliancePayment++;
                                        setVolumeByProcessorAndStatus(loanInfoRepaymentHistory,
                                                LoanInfoRepaymentHistory.PROCESSOR_PAYLIANCE);
                                        break;
                                    case LoanInfoRepaymentHistory.PROCESSOR_PDS:totalPdsPayment++;
                                        setVolumeByProcessorAndStatus(loanInfoRepaymentHistory,
                                                LoanInfoRepaymentHistory.PROCESSOR_PDS);
                                        break;
                                    case LoanInfoRepaymentHistory.PROCESSOR_CC:totalCcPayment++;
                                        setVolumeByProcessorAndStatus(loanInfoRepaymentHistory,
                                                LoanInfoRepaymentHistory.PROCESSOR_CC);
                                        break;
                                    default:System.out.println("Unknown Processor Found = "
                                                +loanInfoRepaymentHistory.getProcessor());
                                        break;
                                }
                            }

                            if (loanInfoRepaymentHistory.getReturnCode() != null) {

                                switch (loanInfoRepaymentHistory.getReturnCode())
                                {
                                    case "R02":totalR02Code++;
                                        setVolumeByProcessorAndCode(loanInfoRepaymentHistory, "R02");break;
                                    case "R03":totalR03Code++;
                                        setVolumeByProcessorAndCode(loanInfoRepaymentHistory, "R03");break;
                                    case "R04":totalR04Code++;
                                        setVolumeByProcessorAndCode(loanInfoRepaymentHistory, "R04");break;
                                    case "R05":totalR05Code++;
                                        setVolumeByProcessorAndCode(loanInfoRepaymentHistory, "R05");break;
                                    case "R07":totalR07Code++;
                                        setVolumeByProcessorAndCode(loanInfoRepaymentHistory, "R07");break;
                                    case "R10":totalR10Code++;
                                        setVolumeByProcessorAndCode(loanInfoRepaymentHistory, "R10");break;
                                    case "R29":totalR29Code++;
                                        setVolumeByProcessorAndCode(loanInfoRepaymentHistory, "R29");break;
                                    case "R51":totalR51Code++;
                                        setVolumeByProcessorAndCode(loanInfoRepaymentHistory, "R51");break;
                                    default:System.out.println("Unknown Code Found = "
                                            +loanInfoRepaymentHistory.getReturnCode());break;
                                }
                            }
                        }
                    }
                }
            }
        }
    }
}

[Campbell Ritchie]

And where do you have a performance problem?
Where do you have any global variables? I didn't notice any, but you should not have global variables in the first place.

[Jeansonne Pierre]

Opps, maybe I should use the word Instance variable. prerequisite:all the instance variable with @getter @setter method cannot be changed.

is it possible to modify the code to be more advanced? or in other word, more intelligent/fancy/complicated design pattetn. I have a strong feeling that my written code is newbie style. I'm in learning progress. please help.

[Bear Bibeault]

Making code "fancy" or "complicated" is not a desirable goal.

You question should be "Can this code be made more elegant and with improved clarity".

Code should not be fancy or complicated, it should be clear.

[Jeansonne Pierre]

hi bear bibeault
noted and thanks.
so my corrected question is..
Can this code be made more elegant and with improved clarity?
kindly need your advise. its out of my capability to improve this code. need your help.

[Jeanne Boyarsky]

That code is long and complicated. I'm not sure why the constraint that you need almost 100 instance variables and can't change that. it would be better to have some of those in objects and those objects be an instance variable in the main class. Or have some of those be maps of keys like "R02" to the percentage.

As far as clarity, let's take a look at this method. It looks like it returns a value based on compareTo(). I see a few things that could be better in this method:
1) How does it differ form just writing return before.compareTo(after)?
2) It's impossible to get to the line with return 2;
3) Why are you catching an exception? What exception are ypu expecting. And why return 3. What does that mean? And where do you check for that return code? Hint: you don't. It's better for the exception to just propogate if you aren't handling it so you don't have a bug later in the program.

private int compareDate(Date before, Date after) {
 
        try {
            if (before.compareTo(after) > 0) {return 1;}
            else if (before.compareTo(after) < 0) {return -1;}
            else if (before.compareTo(after) == 0) {return 0;}
            else {return 2;}
        } catch (Exception ex) {ex.printStackTrace();return 3;}
    }

The last method is also really complicated. The nesting logic is too deep. If nothing else, you could extract some of the logic to other methods. As a start, can you explain how it works in English?

[Jeansonne Pierre]

Hi Jeanne Boyarsky,

Thanks for your time. appreciate it sincerely.

1)

it would be better to have some of those in objects and those objects be an instance variable in the main class.

Oh, i never thought of it that way, noted & thanks. and i will amend it as per suggested. This really helps.

2)

Or have some of those be maps of keys like "R02" to the percentage.

I don't really understand what do you mean by this suggestion?

3)

How does it differ form just writing return before.compareTo(after)?

Oh ya, you are right. i will amend it as per suggested. This really helps.

4)

It's impossible to get to the line with return 2;

Oh ya, you are right again. Thanks a lot.

5)

It's better for the exception to just propogate if you aren't handling it

I don't really understand this, are you mean throw the exception to the calling class instead?


Thanks guys.
Will amend it and repost it again.

[Campbell Ritchie]

Jeansonne Pierre wrote: . . . I don't really understand this, are you mean throw the exception to the calling class instead?
. . .

Yes. but check carefully whether there are any exceptions at all. I do not think there is any possibility of comparing dates giving Exceptions, unless either of the dates is null.

Stop using Date and use the newer classes if you are on Java8.

[Jeansonne Pierre]

Hi Campbell Ritchie, Jeanne Boyarsky, Bear Bibeault,

I have modified the code as per suggested. Looks much better than before. Thanks a lot.
Anymore improvement that i can make? because i still lack of some confident on my code especially the design pattern. Thanks.

package com.sg.csrportal.web.queue.statistics;

import com.sg.csrportal.web.queue.obj.AchPercentageView;
import com.sg.csrportal.web.queue.obj.AchReturnedView;
import com.sg.rc.db.model.loanapp.LoanApp;
import com.sg.rc.db.model.loanapp.info.payment.LoanInfoRepaymentHistory;
import lombok.Getter;
import lombok.Setter;

import java.math.MathContext;
import java.math.RoundingMode;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Date;
import java.util.List;
import java.math.BigDecimal;

public class StatisticsFacadeImpl implements PercentageFacade {

    @Getter @Setter private List<AchReturnedView> achPaylianceReturnedVOList;
    @Getter @Setter private List<AchReturnedView> achPdsReturnedVOList;
    @Getter @Setter private AchPercentageView achPercentageVO;
    @Getter @Setter private long totalPayment;
    @Getter @Setter private long totalCheckedPayment;
    @Getter @Setter private long totalPendingPayment;
    @Getter @Setter private long totalReturnedPayment;
    @Getter @Setter private long totalPayliancePayment;
    @Getter @Setter private long totalPaylianceCheckedPayment;
    @Getter @Setter private long totalPayliancePendingPayment;
    @Getter @Setter private long totalPaylianceReturnedPayment;
    @Getter @Setter private long totalPaylianceR02Code;
    @Getter @Setter private long totalPaylianceR03Code;
    @Getter @Setter private long totalPaylianceR04Code;
    @Getter @Setter private long totalPaylianceR05Code;
    @Getter @Setter private long totalPaylianceR07Code;
    @Getter @Setter private long totalPaylianceR10Code;
    @Getter @Setter private long totalPaylianceR29Code;
    @Getter @Setter private long totalPaylianceR51Code;
    @Getter @Setter private long totalPdsPayment;
    @Getter @Setter private long totalPdsCheckedPayment;
    @Getter @Setter private long totalPdsPendingPayment;
    @Getter @Setter private long totalPdsReturnedPayment;
    @Getter @Setter private long totalPdsR02Code;
    @Getter @Setter private long totalPdsR03Code;
    @Getter @Setter private long totalPdsR04Code;
    @Getter @Setter private long totalPdsR05Code;
    @Getter @Setter private long totalPdsR07Code;
    @Getter @Setter private long totalPdsR10Code;
    @Getter @Setter private long totalPdsR29Code;
    @Getter @Setter private long totalPdsR51Code;
    @Getter @Setter private long totalR02Code;
    @Getter @Setter private long totalR03Code;
    @Getter @Setter private long totalR04Code;
    @Getter @Setter private long totalR05Code;
    @Getter @Setter private long totalR07Code;
    @Getter @Setter private long totalR10Code;
    @Getter @Setter private long totalR29Code;
    @Getter @Setter private long totalR51Code;



    /**
     * **************************************************************************************************************
     * Overall Calculation
     * **************************************************************************************************************
     */
    @Override
    public void setAdministrativeReturnPercentage(AchPercentageView achPercentageVO){

        BigDecimal totalAdministrativeReturn = getBigDecimal(totalR02Code + totalR03Code + totalR04Code);
        BigDecimal totalAchPayment = getBigDecimal(this.totalPayment);
        achPercentageVO.setAdministrativeReturnedPercentage(getPercentage(totalAdministrativeReturn,totalAchPayment));
    }

    @Override
    public void setUnauthorizedReturnPercentage(AchPercentageView achPercentageVO){

        BigDecimal totalUnauthorizedReturn = getBigDecimal(totalR05Code + totalR07Code + totalR10Code +
                totalR29Code + totalR51Code);
        BigDecimal totalAchPayment = getBigDecimal(this.totalPayment);
        achPercentageVO.setUnauthorizedReturnedPercentage(getPercentage(totalUnauthorizedReturn, totalAchPayment));
    }

    @Override
    public void setReturnedPercentage(AchPercentageView achPercentageVO) {

        BigDecimal totalRejectedPayment = getBigDecimal(this.totalReturnedPayment);
        BigDecimal totalAchPayment = getBigDecimal(this.totalPayment);
        achPercentageVO.setReturnedPercentage(getPercentage(totalRejectedPayment, totalAchPayment));
    }

    @Override
    public void setPendingPercentage(AchPercentageView achPercentageVO) {

        BigDecimal totalPendingPayment = getBigDecimal(this.totalPendingPayment);
        BigDecimal totalAchPayment = getBigDecimal(this.totalPayment);
        achPercentageVO.setPendingPercentage(getPercentage(totalPendingPayment, totalAchPayment));
    }

    @Override
    public void setCheckedPercentage(AchPercentageView achPercentageVO) {

        BigDecimal totalCheckedPayment = getBigDecimal(this.totalCheckedPayment);
        BigDecimal totalAchPayment = getBigDecimal(this.totalPayment);
        achPercentageVO.setCheckedPercentage(getPercentage(totalCheckedPayment, totalAchPayment));
    }

    /**
     * **************************************************************************************************************
     * Payliance Calculation
     * **************************************************************************************************************
     */
    @Override
    public void setPaylianceAdministrativeReturnPercentage(AchPercentageView achPercentageVO) {

        BigDecimal totalPaylianceAdministrativeReturn = getBigDecimal(totalPaylianceR02Code + totalPaylianceR03Code +
                totalPaylianceR04Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        achPercentageVO.setAdministrativePaylianceReturnedPercentage(getPercentage(totalPaylianceAdministrativeReturn, totalPayliancePayment));
    }

    @Override
    public void setPaylianceUnauthorizedReturnPercentage(AchPercentageView achPercentageVO) {

        BigDecimal totalPaylianceUnauthorizedReturn = getBigDecimal(totalPaylianceR05Code + totalPaylianceR07Code +
                totalPaylianceR10Code + totalPaylianceR29Code + totalPaylianceR51Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        achPercentageVO.setUnauthorizedPaylianceReturnedPercentage(getPercentage(totalPaylianceUnauthorizedReturn, totalPayliancePayment));
    }

    @Override
    public void setPaylianceReturnedPercentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPaylianceRejectedPayment = getBigDecimal(this.totalPaylianceReturnedPayment);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        achPercentageVO.setReturnedPayliancePercentage(getPercentage(totalPaylianceRejectedPayment, totalPayliancePayment));
    }

    @Override
    public void setPaylianceCheckedPercentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPaylianceCheckedPayment = getBigDecimal(this.totalPaylianceCheckedPayment);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        achPercentageVO.setCheckedPayliancePercentage(getPercentage(totalPaylianceCheckedPayment, totalPayliancePayment));
    }

    @Override
    public void setPayliancePendingPercentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPayliancePendingPayment = getBigDecimal(this.totalPayliancePendingPayment);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        achPercentageVO.setPendingPayliancePercentage(getPercentage(totalPayliancePendingPayment, totalPayliancePayment));
    }

    /**
     * **************************************************************************************************************
     * PDS Calculation
     * **************************************************************************************************************
     */
    @Override
    public void setPdsAdministrativeReturnPercentage(AchPercentageView achPercentageVO) {

        BigDecimal totalPdsAdministrativeReturn = getBigDecimal(totalPdsR02Code + totalPdsR03Code +
                totalPdsR04Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        achPercentageVO.setAdministrativePdsReturnedPercentage(getPercentage(totalPdsAdministrativeReturn, totalPdsPayment));

    }

    @Override
    public void setPdsUnauthorizedReturnPercentage(AchPercentageView achPercentageVO) {

        BigDecimal totalPdsUnauthorizedReturn = getBigDecimal(totalPdsR05Code + totalPdsR07Code +
                totalPdsR10Code + totalPdsR29Code + totalPdsR51Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        achPercentageVO.setUnauthorizedPdsReturnedPercentage(getPercentage(totalPdsUnauthorizedReturn, totalPdsPayment));
    }

    @Override
    public void setPdsReturnedPercentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPdsRejectedPayment = getBigDecimal(this.totalPdsReturnedPayment);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        achPercentageVO.setReturnedPdsPercentage(getPercentage(totalPdsRejectedPayment, totalPdsPayment));
    }

    @Override
    public void setPdsCheckedPercentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPdsCheckedPayment = getBigDecimal(this.totalPdsCheckedPayment);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        achPercentageVO.setCheckedPdsPercentage(getPercentage(totalPdsCheckedPayment, totalPdsPayment));
    }

    @Override
    public void setPdsPendingPercentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPdsPendingPayment = getBigDecimal(this.totalPdsPendingPayment);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        achPercentageVO.setPendingPdsPercentage(getPercentage(totalPdsPendingPayment, totalPdsPayment));
    }


    /**
     * **************************************************************************************************************
     * R02, R03, R04, R05, R07, R10, R29, R51 Calculation
     * **************************************************************************************************************
     */

    @Override
    public void setPaylianceR02Percentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPaylianceR02Code = getBigDecimal(this.totalPaylianceR02Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        achPercentageVO.setPaylianceR02Percentage(getPercentage(totalPaylianceR02Code, totalPayliancePayment));
    }

    @Override
    public void setPaylianceR03Percentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPaylianceR03Code = getBigDecimal(this.totalPaylianceR03Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        achPercentageVO.setPaylianceR03Percentage(getPercentage(totalPaylianceR03Code, totalPayliancePayment));
    }

    @Override
    public void setPaylianceR04Percentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPaylianceR04Code = getBigDecimal(this.totalPaylianceR04Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        achPercentageVO.setPaylianceR04Percentage(getPercentage(totalPaylianceR04Code, totalPayliancePayment));
    }

    @Override
    public void setPdsR02Percentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPdsR02Code = getBigDecimal(this.totalPdsR02Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        achPercentageVO.setPdsR02Percentage(getPercentage(totalPdsR02Code, totalPdsPayment));
    }

    @Override
    public void setPdsR03Percentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPdsR03Code = getBigDecimal(this.totalPdsR03Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        achPercentageVO.setPdsR03Percentage(getPercentage(totalPdsR03Code, totalPdsPayment));
    }

    @Override
    public void setPdsR04Percentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPdsR04Code = getBigDecimal(this.totalPdsR04Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        achPercentageVO.setPdsR04Percentage(getPercentage(totalPdsR04Code, totalPdsPayment));
    }

    @Override
    public void setPaylianceR05Percentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPaylianceR05Code = getBigDecimal(this.totalPaylianceR05Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        achPercentageVO.setPaylianceR05Percentage(getPercentage(totalPaylianceR05Code, totalPayliancePayment));
    }

    @Override
    public void setPaylianceR07Percentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPaylianceR07Code = getBigDecimal(this.totalPaylianceR07Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        achPercentageVO.setPaylianceR07Percentage(getPercentage(totalPaylianceR07Code, totalPayliancePayment));
    }

    @Override
    public void setPaylianceR10Percentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPaylianceR10Code = getBigDecimal(this.totalPaylianceR10Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        achPercentageVO.setPaylianceR10Percentage(getPercentage(totalPaylianceR10Code, totalPayliancePayment));
    }

    @Override
    public void setPaylianceR29Percentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPaylianceR29Code = getBigDecimal(this.totalPaylianceR29Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        achPercentageVO.setPaylianceR29Percentage(getPercentage(totalPaylianceR29Code, totalPayliancePayment));
    }

    @Override
    public void setPaylianceR51Percentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPaylianceR51Code = getBigDecimal(this.totalPaylianceR51Code);
        BigDecimal totalPayliancePayment = getBigDecimal(this.totalPayliancePayment);
        achPercentageVO.setPaylianceR51Percentage(getPercentage(totalPaylianceR51Code, totalPayliancePayment));
    }

    @Override
    public void setPdsR05Percentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPdsR05Code = getBigDecimal(this.totalPdsR05Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        achPercentageVO.setPdsR05Percentage(getPercentage(totalPdsR05Code, totalPdsPayment));
    }

    @Override
    public void setPdsR07Percentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPdsR07Code = getBigDecimal(this.totalPdsR07Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        achPercentageVO.setPdsR07Percentage(getPercentage(totalPdsR07Code, totalPdsPayment));
    }

    @Override
    public void setPdsR10Percentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPdsR10Code = getBigDecimal(this.totalPdsR10Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        achPercentageVO.setPdsR10Percentage(getPercentage(totalPdsR10Code, totalPdsPayment));
    }

    @Override
    public void setPdsR29Percentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPdsR29Code = getBigDecimal(this.totalPdsR29Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        achPercentageVO.setPdsR29Percentage(getPercentage(totalPdsR29Code, totalPdsPayment));
    }

    @Override
    public void setPdsR51Percentage(AchPercentageView achPercentageVO) {
        BigDecimal totalPdsR51Code = getBigDecimal(this.totalPdsR51Code);
        BigDecimal totalPdsPayment = getBigDecimal(this.totalPdsPayment);
        achPercentageVO.setPdsR51Percentage(getPercentage(totalPdsR51Code, totalPdsPayment));

    }


    /**
     * **************************************************************************************************************
     * Facade Selector
     * **************************************************************************************************************
     */
    public void setTotalPercentage(){
        achPercentageVO = new AchPercentageView();

        setCheckedPercentage(achPercentageVO);
        setReturnedPercentage(achPercentageVO);
        setPendingPercentage(achPercentageVO);
        setAdministrativeReturnPercentage(achPercentageVO);
        setUnauthorizedReturnPercentage(achPercentageVO);
        setPaylianceAdministrativeReturnPercentage(achPercentageVO);
        setPaylianceUnauthorizedReturnPercentage(achPercentageVO);
        setPaylianceReturnedPercentage(achPercentageVO);
        setPaylianceCheckedPercentage(achPercentageVO);
        setPayliancePendingPercentage(achPercentageVO);
        setPdsAdministrativeReturnPercentage(achPercentageVO);
        setPdsUnauthorizedReturnPercentage(achPercentageVO);
        setPdsReturnedPercentage(achPercentageVO);
        setPdsCheckedPercentage(achPercentageVO);
        setPdsPendingPercentage(achPercentageVO);
        setTotalReturnedPercentage();
    }

    public void setTotalReturnedPercentage(){


        setPaylianceR02Percentage(achPercentageVO);
        setPaylianceR03Percentage(achPercentageVO);
        setPaylianceR04Percentage(achPercentageVO);
        setPaylianceR05Percentage(achPercentageVO);
        setPaylianceR07Percentage(achPercentageVO);
        setPaylianceR10Percentage(achPercentageVO);
        setPaylianceR29Percentage(achPercentageVO);
        setPaylianceR51Percentage(achPercentageVO);
        setPdsR02Percentage(achPercentageVO);
        setPdsR03Percentage(achPercentageVO);
        setPdsR04Percentage(achPercentageVO);
        setPdsR05Percentage(achPercentageVO);
        setPdsR07Percentage(achPercentageVO);
        setPdsR10Percentage(achPercentageVO);
        setPdsR29Percentage(achPercentageVO);
        setPdsR51Percentage(achPercentageVO);
        setAchReturnedViewListPercentage();

    }


    private void setAchReturnedViewListPercentage(){

        achPaylianceReturnedVOList = new ArrayList<>();
        achPdsReturnedVOList = new ArrayList<>();

        achPaylianceReturnedVOList.add(new AchReturnedView("R02", "Payliance", "unauthorized", totalPaylianceR02Code, achPercentageVO.getPaylianceR02Percentage()));
        achPaylianceReturnedVOList.add(new AchReturnedView("R03", "Payliance", "unauthorized", totalPaylianceR03Code, achPercentageVO.getPaylianceR03Percentage()));
        achPaylianceReturnedVOList.add(new AchReturnedView("R04", "Payliance", "unauthorized", totalPaylianceR04Code, achPercentageVO.getPaylianceR04Percentage()));
        achPaylianceReturnedVOList.add(new AchReturnedView("R05", "Payliance", "administrative", totalPaylianceR05Code, achPercentageVO.getPaylianceR05Percentage()));
        achPaylianceReturnedVOList.add(new AchReturnedView("R07", "Payliance", "administrative", totalPaylianceR07Code, achPercentageVO.getPaylianceR07Percentage()));
        achPaylianceReturnedVOList.add(new AchReturnedView("R10", "Payliance", "administrative", totalPaylianceR10Code, achPercentageVO.getPaylianceR10Percentage()));
        achPaylianceReturnedVOList.add(new AchReturnedView("R29", "Payliance", "administrative", totalPaylianceR29Code, achPercentageVO.getPaylianceR29Percentage()));
        achPaylianceReturnedVOList.add(new AchReturnedView("R51", "Payliance", "administrative", totalPaylianceR51Code, achPercentageVO.getPaylianceR51Percentage()));

        achPdsReturnedVOList.add(new AchReturnedView("R02", "Pds", "unauthorized", totalPdsR02Code, achPercentageVO.getPdsR02Percentage()));
        achPdsReturnedVOList.add(new AchReturnedView("R03", "Pds", "unauthorized", totalPdsR03Code, achPercentageVO.getPdsR03Percentage()));
        achPdsReturnedVOList.add(new AchReturnedView("R04", "Pds", "unauthorized", totalPdsR04Code, achPercentageVO.getPdsR04Percentage()));
        achPdsReturnedVOList.add(new AchReturnedView("R05", "Pds", "administrative", totalPdsR05Code, achPercentageVO.getPdsR05Percentage()));
        achPdsReturnedVOList.add(new AchReturnedView("R07", "Pds", "administrative", totalPdsR07Code, achPercentageVO.getPdsR07Percentage()));
        achPdsReturnedVOList.add(new AchReturnedView("R10", "Pds", "administrative", totalPdsR10Code, achPercentageVO.getPdsR10Percentage()));
        achPdsReturnedVOList.add(new AchReturnedView("R29", "Pds", "administrative", totalPdsR29Code, achPercentageVO.getPdsR29Percentage()));
        achPdsReturnedVOList.add(new AchReturnedView("R51", "Pds", "administrative", totalPdsR51Code, achPercentageVO.getPdsR51Percentage()));

    }

    /**
     * **************************************************************************************************************
     * Facade Calculation
     * **************************************************************************************************************
     */

    private BigDecimal getBigDecimal(long volume){

        return new BigDecimal(volume);
    }

    private BigDecimal getPercentage(BigDecimal numerator, BigDecimal denominator) {

        if(numerator.compareTo(BigDecimal.ZERO)==0){
            return BigDecimal.ZERO;
        }
        else{
            MathContext mathContext = new MathContext(10, RoundingMode.HALF_EVEN);
            BigDecimal percentage = numerator.divide(denominator, mathContext).
                    multiply(new BigDecimal("100"), mathContext);
            return percentage.setScale(2, BigDecimal.ROUND_HALF_EVEN);
        }
    }

    private void setVolumeByProcessorAndStatus(LoanInfoRepaymentHistory loanInfoRepaymentHistory, String processor){

        switch(processor.toLowerCase()){
            case "payliance":
                if (loanInfoRepaymentHistory.getPaymentStatus() != null) {
                    switch(loanInfoRepaymentHistory.getPaymentStatus()){
                        case LoanInfoRepaymentHistory.PAYMENT_STATUS_CHECKED:totalPaylianceCheckedPayment++;break;
                        case LoanInfoRepaymentHistory.PAYMENT_STATUS_PENDING:totalPayliancePendingPayment++;break;
                        case LoanInfoRepaymentHistory.PAYMENT_STATUS_REJECTED:
                            totalPaylianceReturnedPayment++;break;
                    }
                }
                break;
            case "pds":
                if (loanInfoRepaymentHistory.getPaymentStatus() != null) {
                    switch(loanInfoRepaymentHistory.getPaymentStatus()){
                        case LoanInfoRepaymentHistory.PAYMENT_STATUS_CHECKED:totalPdsCheckedPayment++;break;
                        case LoanInfoRepaymentHistory.PAYMENT_STATUS_PENDING:totalPdsPendingPayment++;break;
                        case LoanInfoRepaymentHistory.PAYMENT_STATUS_REJECTED:
                            totalPdsReturnedPayment++;break;
                    }
                }
                break;
        }
    }

    private void setVolumeByProcessorAndCode(LoanInfoRepaymentHistory loanInfoRepaymentHistory, String returnCode){

        switch(loanInfoRepaymentHistory.getProcessor().toLowerCase()){
            case "payliance":
                if (returnCode != null) {
                    switch(returnCode){
                        case "R02":totalPaylianceR02Code++;break;
                        case "R03":totalPaylianceR03Code++;break;
                        case "R04":totalPaylianceR04Code++;break;
                        case "R05":totalPaylianceR05Code++;break;
                        case "R07":totalPaylianceR07Code++;break;
                        case "R10":totalPaylianceR10Code++;break;
                        case "R29":totalPaylianceR29Code++;break;
                        case "R51":totalPaylianceR51Code++;break;
                    }
                }
                break;
            case "pds":
                if (returnCode != null) {
                    switch(returnCode){
                        case "R02":totalPdsR02Code++;break;
                        case "R03":totalPdsR03Code++;break;
                        case "R04":totalPdsR04Code++;break;
                        case "R05":totalPdsR05Code++;break;
                        case "R07":totalPdsR07Code++;break;
                        case "R10":totalPdsR10Code++;break;
                        case "R29":totalPdsR29Code++;break;
                        case "R51":totalPdsR51Code++;break;
                    }
                }
                break;
        }
    }

    public String getHtmlDate(Date defaultDate){

        SimpleDateFormat simpleDateFormat = new SimpleDateFormat("yyyy-MM-dd");
        String htmlDate = simpleDateFormat.format(defaultDate);

        return htmlDate;
    }

    public void setTotalVolume(List<LoanApp> loanAppsList, List<String> listOfPaymentStatus, Date startDate, Date endDate) {

        for (LoanApp loanApp : loanAppsList) {
            List<LoanInfoRepaymentHistory> loanInfoRepaymentHistoriesList = loanApp.getInfo().getRepayment().getHistories();

            for (LoanInfoRepaymentHistory loanInfoRepaymentHistory : loanInfoRepaymentHistoriesList) {

                for (String paymentStatus : listOfPaymentStatus) {

                    if (loanInfoRepaymentHistory.getPaymentStatus().matches(paymentStatus)) {

                        if (loanInfoRepaymentHistory.getEffectiveDate().compareTo(startDate) > 0 &&
                                loanInfoRepaymentHistory.getEffectiveDate().compareTo(endDate) < 0) {

                            System.out.println(loanInfoRepaymentHistory.getEffectiveDate());

                            totalPayment++;

                            if (loanInfoRepaymentHistory.getPaymentStatus() != null) {
                                switch(loanInfoRepaymentHistory.getPaymentStatus()){
                                    case LoanInfoRepaymentHistory.PAYMENT_STATUS_CHECKED:totalCheckedPayment++;
                                        break;
                                    case LoanInfoRepaymentHistory.PAYMENT_STATUS_PENDING:totalPendingPayment++;
                                        break;
                                    case LoanInfoRepaymentHistory.PAYMENT_STATUS_REJECTED:
                                        totalReturnedPayment++;break;
                                    default:break;
                                }
                            }

                            if(loanInfoRepaymentHistory.getProcessor() != null) {
                                switch(loanInfoRepaymentHistory.getProcessor()){
                                    case LoanInfoRepaymentHistory.PROCESSOR_PAYLIANCE:totalPayliancePayment++;
                                        setVolumeByProcessorAndStatus(loanInfoRepaymentHistory,
                                                LoanInfoRepaymentHistory.PROCESSOR_PAYLIANCE);
                                        break;
                                    case LoanInfoRepaymentHistory.PROCESSOR_PDS:totalPdsPayment++;
                                        setVolumeByProcessorAndStatus(loanInfoRepaymentHistory,
                                                LoanInfoRepaymentHistory.PROCESSOR_PDS);
                                        break;
                                    default:break;
                                }
                            }

                            if (loanInfoRepaymentHistory.getReturnCode() != null) {

                                switch (loanInfoRepaymentHistory.getReturnCode())
                                {
                                    case "R02":totalR02Code++;
                                        setVolumeByProcessorAndCode(loanInfoRepaymentHistory, "R02");break;
                                    case "R03":totalR03Code++;
                                        setVolumeByProcessorAndCode(loanInfoRepaymentHistory, "R03");break;
                                    case "R04":totalR04Code++;
                                        setVolumeByProcessorAndCode(loanInfoRepaymentHistory, "R04");break;
                                    case "R05":totalR05Code++;
                                        setVolumeByProcessorAndCode(loanInfoRepaymentHistory, "R05");break;
                                    case "R07":totalR07Code++;
                                        setVolumeByProcessorAndCode(loanInfoRepaymentHistory, "R07");break;
                                    case "R10":totalR10Code++;
                                        setVolumeByProcessorAndCode(loanInfoRepaymentHistory, "R10");break;
                                    case "R29":totalR29Code++;
                                        setVolumeByProcessorAndCode(loanInfoRepaymentHistory, "R29");break;
                                    case "R51":totalR51Code++;
                                        setVolumeByProcessorAndCode(loanInfoRepaymentHistory, "R51");break;
                                    default:break;
                                }
                            }
                        }
                    }
                }
            }
        }
    }
}

[Jeanne Boyarsky]

Jeansonne Pierre wrote:
2)

Or have some of those be maps of keys like "R02" to the percentage.

I don't really understand what do you mean by this suggestion?

It's a big refactoring, but have something like this instead of all those variables.

public enum TotalTypes {
  PDS_R02_CODE, PDS_R03_CODE, R03_CODE;
}
	
private Map< TotalTypes, Long> totals;

That would require changing your AchPercentageView class as well since it has the same setters.

[Jeansonne Pierre]

Thanks a lot guys ! appreciate it so much