Passing Value From Popup Window To Parent Window

[Daniel Gee]

I am using JSF. I try to pass a value that is entered by users back to a text field in the parent window. I think my problem is with the syntax of the JavaScript because I got script error:

document.forms[ ].elements[ ] is null or not an object.

The relevant code snippets are shown below. The web site does not accept one of the tag attributes that I entered; therefore, I put an underscore in that attribute - on_click.

The screen1.jsp is the parent window:

.....
         <script language="JavaScript1.1">
            function doPopup(source) {
                popup = window.open("externalFilePopup.jsp",
                    "popup", 
                    "height=300,width=200,toolbar=no,menubar=no,"
                    + "scrollbars=yes");               
                popup.openerFormId = source.form.id;
                popup.focus();
            }               
         </script>
 
.....
.....
<h:outputText value="Enter the external system file name"/>
        <h:inputText value="#{dataManagementBean.ip}" size="18" />
<h:commandButton value="..." on_click="doPopup(this); return false;" />
 
.....
.....

The externalFilePopup.jsp is the popup window:

.....
        <script language="JavaScript1.1">
            function doSave( value ) 
{
               var formId = window.openerFormId;
               opener.document.forms[ formId ].elements[ formId + ":ip" ].value = value;
               window.close();
            }               
        </script>
 
.....
.....
<h:outputText value="IP Address: "/>
<h:inputText size="25" value="#{dataManagementBean.ip }" required="true"/>
 
.....
.....
<h:commandButton value="OK" on_click="doSave('#{dataManagementBean.ip}');"/>
 

The script error occurs when I click on this OK button.

Please point out the mistakes in my code. Thank you.
[ September 22, 2005: Message edited by: Daniel Gee ]

[Daniel Gee]

I have made some modifications to the code in the popup window. The error reported in my previous posting is gone. But, I still have several problems:

1. syntax error in the popup window jsp page:

line 45, char 21, syntax error, ..., Do you want to continue running script on this page?

2. The popup window does not close after I click on the OK button that I coded in the popup window jsp.
3. The value that I entered in the popup window eventually gets passed back to the text field in the parent window only if I re-run the application.

The relevant JavaScript code snippets are:

......
 
        <script language="JavaScript1.1">
            function doSave( value ) 
{
               var formId = window.openerFormId;
               opener.document.forms[ formId ].form[ formId + ":ip" ].value = value;
               window.close();
            }               
        </script>
 
......
......
 
<h:outputText value="IP Address: "/>
<h:inputText size="25" id="ip" value="#{dataManagementBean.ip }" required="true"/>
 
......
......
 
<h:commandButton value="OK" on_click="doSave('ip'); return=false;"/>
 
......

What are the mistakes that I made?