why the window doesn't close and bring the item to the main form?

[Peter Primrose]

Hi there,

the javascript function below is taken from struts-layout. a new window is opened with a list of items, the end-user chooses from the list (drop down box) and clicks SELECT. what it need to do is to select the item of the user and move it to the main form.

for some reason the opened-window doesn't close! I tested it (with alert("point 1") any debugger?~) and realized that the problem is in this line:

  window.opener.document.forms[0][openerField].value = value;  

the complete function is:

  
 
function closepopup(form, openerField, popupField) {
var inputField = form[popupField];
var value;
if (inputField.options) {
value = inputField.options[form[popupField].selectedIndex].value;
} else if (inputField.type == "file") {
value = inputField.value;
} else {
for (i=0; i < form.elements.length; i++) {
var element = form.elements[i];
if (element.name == popupField && element.checked) {
value = element.value;
break;
}
}
}
window.opener.document.forms[0][openerField].value = value;
window.close();
}
 
    

[ February 19, 2007: Message edited by: Bear Bibeault ]

[Ashish K Sharma]

Try

  
window.opener.document.forms[0].openerField.value = value;  

[Eric Pascarello]

if it is a <input type="file" ..> you can not set its value.

How are you opening this pop up from the parent?

Eric

[Peter Primrose]

thank you guys,

Eric: "How are you opening this pop up from the parent?"

the code below. thanks again

    
function openpopup(form, popup, width, height, e) {
var xx, yy;
xx = e.screenX;
yy = e.screenY;
window.open('about:blank', 'popup', 'directories=0, location=0, menubar=0, status=0, toolbar=0, width=' + width + ', height=' + height + ', top=' + yy + ', left=' + xx); 
var action = form.action;
var target = form.target;
if (popup == null || popup == "") {
popup = action;
}
form.target='popup';
form.action = popup;
form.submit();
form.target = target;
form.action = action;

return false;
}

[Peter Primrose]

oh... and the open/close is from


open:

   
<layout:tab key="Subject" width="50">
           <layout:text key="news.subject" property="subject" styleClass="LABEL">
<layout:submit reqCode="popup" on_click="return openpopup(this.form, '', '280', '150', event);" value="..."/>
           </layout:text>
 
 

close:

  <layout:html>
<layout:form action="/addNews" styleClass="FORM">
<layout:select key="" property="subject" styleClass="LABEL">
<layout :-o	 ptions collection="subjects" property="name" labelProperty="name"/>
</layout:select>
<layout:button on_click="closepopup(this.form, 'subject', 'subject')" value="Select"/>
</layout:form>
</layout:html>