wood burning stoves*
The moose likes Agile and Other Processes and the fly likes Code Reviews Big Moose Saloon
  Search | Java FAQ | Recent Topics | Flagged Topics | Hot Topics | Zero Replies
Register / Login
JavaRanch » Java Forums » Engineering » Agile and Other Processes
Bookmark "Code Reviews" Watch "Code Reviews" New topic

Code Reviews

Mark Herschberg

Joined: Dec 04, 2000
Posts: 6037
I am a big proponent of code reviews. Usually when we do it, I ask the presenter to provide, ahead of time, a dagram of the active object instances and how they relate to each other, to give everyone a big picture overview of the (sub)system. We then go through the code in a handful of related classes.
Has anyone ever tried doing a code review from a use-case point of view? That is, instead of going class by class, you more or less step throug the code, as executed during a given use-case, similar to debugging. It seems like it would involve a lot of page flipping, but I'm wondering if it might provide a different set of insights. I'm tempted to give it a try.

Steve Fahlbusch

Joined: Sep 18, 2000
Posts: 557

I use use case review to determine how the proposed solution (design) will fit the use case. Basically a design walkthrough.
Have tried to map the code to use cases, but the distance seems to be too far (that is from code, to design to use case).
The other time I utilized use case walkthrough is when I am testing the test cases (ie do the test cases that test the use cases really map to the use cases). <- earlier than above
For a small system I think it could work since the code, design and requirements (use cases) can all be understood. For a larger system it has not worked for me.

It is sorta covered in the JavaRanch Style Guide.
subject: Code Reviews
Similar Threads
JSP variable into javascript
servlet filter to hain System.out to jsp out.println() -Challenge !-
Need right tool for java coding standards & code review
Introducing agile at a company
A class is a subclass