is this security ok?

[Takeshi Toyohara]

Hello all,
I looked through the archives and I didnt see a solid answer to this, so I just wanted to double-check. Do you guys think this is the correct way/enough of a security implementation for RMI?

this is in my server startup class

 
        if(System.getSecurityManager() == null) {
            System.setSecurityManager(new RMISecurityManager());
        } 

and my policy file as:

 grant {
  permission java.security.AllPermission;
  permission java.net.SocketPermission "*:1-1023", "connect,resolve";
  permission java.net.SocketPermission "*:1024-65535", "connect,accept,resolve";
};
 

thanks

[Mark Spritzler]

I'd just set the SecurityManager without the check for null.
Policy file - I just added one line to give all permissions. That was fine.
I think what you have in yours is fine too.
Mark