Some code about GUI

[George Ren]

Hi,everyone.
Recently I am working on FBNS. First I created a dialog to allow user to select which model(Remote or Local)to use. I use JBuilder 9 to do the job, the .java file is compiled successfully, but when I run this gui, it displaies only the area of label of the window. I try to set size to the panel, but It seems don't work. Now I paste the code, please help me see it. Thanks.

<font size="2"> 
public class Dialog1 extends JDialog {
  JPanel panel1 = new JPanel();
  JMenuBar jMenuBar1 = new JMenuBar();
  JMenu jMenuFile = new JMenu();
  JMenuItem jMenuFileExit = new JMenuItem();
  JMenu jMenuHelp = new JMenu();
  JMenuItem jMenuHelpAbout = new JMenuItem();
  JRadioButton rbLocal = new JRadioButton();
  JRadioButton rbRemote = new JRadioButton();
  JLabel jLabel1 = new JLabel();
  JTextField tfLoc = new JTextField();
  JTextField tfPort = new JTextField();
  JButton bOk = new JButton();
  JButton bCancel = new JButton();
  ButtonGroup buttonGroup1 = new ButtonGroup();
  JTextPane jTextPane1 = new JTextPane();
  public Dialog1(Frame frame, String title, boolean modal) {
    super(frame, title, modal);
    try {
      jbInit();
      pack();
    }
    catch(Exception ex) {
      ex.printStackTrace();
    }
  }
  public Dialog1() {
    this(null, "", false);
    Dimension screenSize = Toolkit.getDefaultToolkit().getScreenSize();
    Dimension dialogSize = this.getSize();
    if (dialogSize.height > screenSize.height)
      dialogSize.height = screenSize.height;
    if (dialogSize.width > screenSize.width)
      dialogSize.width = screenSize.width;
    this.setLocation((screenSize.width - dialogSize.width) / 2, (screenSize.height - dialogSize.height) / 2);
    this.setVisible(true);
  }
  private void jbInit() throws Exception {
    panel1.setLayout(null);
    this.setTitle("Fly by night service v1.0");
    this.setJMenuBar(jMenuBar1);
    this.setSize(new Dimension(400, 300));
  }
  
  static public void main(String[] args) {
    try {
      UIManager.setLookAndFeel(UIManager.getSystemLookAndFeelClassName());
    }
    catch(Exception e) {
      e.printStackTrace();
    }
    new Dialog1();
  }

}

[ October 01, 2003: Message edited by: Mark Spritzler ]

[Andrew Monkhouse]

Hi George,
One problem is that since you do not have a layout manager for the panel, when you call the pack() method, the panel cannot calculate it's preferred size. If you set the panel's preferred size, that problem will be avoided.
Regards, Andrew

[George Ren]

Thanks Andrew, I will try.

[Mark Spritzler]

I would also look at your indentation of your code, and the variable naming. It appears a couple of places that it does not follow Sun's standards. And a variable name like "panel1" is a very bad name for that variable. variables should be more descriptive as to what it actually is.
I am also going to need to remove most of your code, just because it gives too much away to another test taker. I will leave the part of the code that relates to your question.
Thanks
Mark

[Dushy Inguva]

Hello George,
Its probably better to use a LayoutManager. Sun usually insists about using a LayoutManager.
As part of the requirements, you are supposed to provide a framework for GUI development. It would fit in better if you use a layout manager.
Thanks
Dushy

[George Ren]

Thank all of you for giving me the advice.
Mark, I will change the panel's name and I will not give out any code that doesn't relate to the problem.
Dushyanth,thank you for your advice. I will try to use a Layout manager in my implementation.