Anybody using developing their project and adding UNIT Tests?

[Mark Waldrop]

I was curious, if anybody was creating UNIT tests for their application as they were developing it (i.e. JUnit TestCases)?
If so, did you find it beneficial for your SCJD project?

[Ken Krebs]

I did create unit tests for my key classes and was very glad I did as it allowed me to improve my design and coding by refactoring it over and over again with confidence that I hadn't broken anything in the process.
Speaking about JUnit:
"Never in the field of software development was so much owed by so many to so few lines of code" - Martin Fowler
This is so true.

[Jay Bromley]

Mark,
I too am using JUnit and a couple of custom classes to do unit tests. It's really good for peace of mind. Like Ken said, you can change something, even radically, then retest it. If it still works you're all good.
One question for Ken: Did you include your test classes in your uploaded project? I'm not intending to do this, does that sound ok?
Regards,
jb

[Billy Tsai]

i didnt use any UNIT test, i did all the testing by myself as a user.

[Terry Martinson]

I have a custom class to do the testing of my Data class methods. JUnit would probably have been better, but the custom class works fine for me. I also do manual user testing of the application in both network and standalone modes.
The custom class test is a lifesaver though.
TJ

[Terry Martinson]

Billy -
Did you do any type of multithreaded test as a unit test?
Or just the manual testing you mention above?
I know you passed recently, so I was just wondering.
TJ

[Ken Krebs]

Jay,
I did not submit my test code.

[Terry Martinson]

Ken -
Did you do a multithreaded unit test to pound the data manipulation methods?
Just curious - I have a question posted out here at this url and it's not getting any response.
I would love to hear your 2 cents worth.
TJ

[Ken Krebs]

TJ,
I did write a multithreading test but it wasn't a JUnit test.
[ January 22, 2004: Message edited by: Ken Krebs ]

[Roel De Meester]

I'm using junit and junitperf. I've copied the junitperf loadTest from some other thread in this forum.
My unit testcase which can run on it's own (AND is succesfull in both tests)

package suncertify.db;
import java.io.File;
import java.io.FileNotFoundException;
import java.io.IOException;
import java.util.Random;
import junit.framework.TestCase;
import util.FileCopy;
public class DataLockTest extends TestCase {
    private static final Random random = new Random();
    private static final File backupFile = new File("backup.db");
    private static final File oriFile = new File("db-1x2.db");
    private boolean selfSetup = false;
    private static final int RECORD_NO = 24;
    private static final int SLEEP_TIME = 1000;
    private Data data;
    /**
     * @param string
     * @param name
     */
    public DataLockTest(String name, Data data2) {
        super(name);
        data = data2;
    }
    /**
     * @param name
     */
    public DataLockTest(String name) {
        super(name);
    }
    /**
     * Copy the original file to test.db and only use that file during testing.
     * This method will NOT be called during Performance Test
     */
    protected void setUp() throws Exception {
        if (data == null) {
            selfSetup = true;
            data = Data.getInstance();
            if (backupFile.exists()) FileCopy.copy(backupFile.getAbsolutePath(), oriFile.getAbsolutePath(), true);
            else
                FileCopy.copy(oriFile.getAbsolutePath(), backupFile.getAbsolutePath(), true);
            try {
                data = Data.getInstance();
            } catch (IOException e) {
                fail("Could not access the data file");
            }
        }
    }
    /**
     * 
     * Breaksdown test case data, prior to every test
     * This method will NOT be called during Performance Test
     */
    protected void tearDown() throws Exception {
        if (selfSetup) {
            Data.resetInstance();
            data = null;
            if (!backupFile.exists()) { throw new FileNotFoundException("Backup Database file not found"); }
            FileCopy.copy(backupFile.getAbsolutePath(), oriFile.getAbsolutePath(), true);
            backupFile.delete();
        }
    }
    public void testUpdateWithoutLock() throws RecordNotFoundException, SecurityException, InterruptedException {
//        long cookie = data.lock(RECORD_NO);
        long cookie = -1;
        String[] expRecord = data.read(RECORD_NO);
        expRecord[6] = "OWNE" + random.nextInt(10000);
        data.update(RECORD_NO, expRecord, cookie);
        Thread.currentThread().sleep(SLEEP_TIME);
        String[] actualRecord = data.read(RECORD_NO);
//        data.unlock(RECORD_NO, cookie);
        
        assertEquals("UPDATE while locked FAILED", new HotelRoom(expRecord), new HotelRoom(actualRecord));
        expRecord = data.read(RECORD_NO);
        expRecord[6] = "";
//        cookie = data.lock(RECORD_NO);
        data.update(RECORD_NO, expRecord, cookie);
        Thread.currentThread().sleep(SLEEP_TIME);
        actualRecord = data.read(RECORD_NO);
//        data.unlock(RECORD_NO, cookie);
        
        assertEquals("2nd UPDATE FAILED", new HotelRoom(expRecord), new HotelRoom(actualRecord));
    }
    public void testUpdateWithLock() throws RecordNotFoundException, SecurityException, InterruptedException {
        long cookie = data.lock(RECORD_NO);
        String[] expRecord = data.read(RECORD_NO);
        expRecord[6] = "OWNE" + random.nextInt(10000);
        data.update(RECORD_NO, expRecord, cookie);
        Thread.currentThread().sleep(SLEEP_TIME);
        String[] actualRecord = data.read(RECORD_NO);
        data.unlock(RECORD_NO, cookie);
        
        assertEquals("UPDATE while locked FAILED", new HotelRoom(expRecord), new HotelRoom(actualRecord));
        expRecord = data.read(RECORD_NO);
        expRecord[6] = "";
        cookie = data.lock(RECORD_NO);
        data.update(RECORD_NO, expRecord, cookie);
        Thread.currentThread().sleep(SLEEP_TIME);
        actualRecord = data.read(RECORD_NO);
        data.unlock(RECORD_NO, cookie);
        
        assertEquals("2nd UPDATE FAILED", new HotelRoom(expRecord), new HotelRoom(actualRecord));
    }
}

The performance tests which starts 50 clients at the same time and does a 1 time only setup/teardown. WithLock->succes | WithoutLock->fails (as expected)

package suncertify.db;
import java.io.File;
import java.io.FileNotFoundException;
import java.io.IOException;
import junit.extensions.TestSetup;
import junit.framework.Test;
import junit.framework.TestSuite;
import util.FileCopy;
import com.clarkware.junitperf.LoadTest;
public class DataLockLoadTest {
    private static Data data;
    private static final int MAX_USERS = 50;
    private static final File backupFile = new File("backup.db");
    private static final File oriFile = new File("db-1x2.db");
    public static Test suite() throws IOException {
        if (backupFile.exists()) FileCopy.copy(backupFile.getAbsolutePath(), oriFile.getAbsolutePath(), true);
        else
            FileCopy.copy(oriFile.getAbsolutePath(), backupFile.getAbsolutePath(), true);
        try {
            data = Data.getInstance();
        } catch (IOException e) {
            System.err.println("Could not access the data file");
        }
        // Pass the testDatabase to the test case contained in the
        // DataLockTest class
        Test testCase = new DataLockTest("testUpdateWithoutLock", data);
        Test testCase2 = new DataLockTest("testUpdateWithLock", data);
        
        Test loadTest = new LoadTest(testCase, MAX_USERS);
        Test loadTest2 = new LoadTest(testCase2, MAX_USERS);
        TestSuite suite = new TestSuite();
        suite.addTest(loadTest);
        suite.addTest(loadTest2);
        // Anonymous TestSetup object for one time tearDown method
        TestSetup wrapper = new TestSetup(suite) {
            protected void tearDown() throws IOException {
                if (!backupFile.exists()) { throw new FileNotFoundException("Backup Database file not found"); }
                FileCopy.copy(backupFile.getAbsolutePath(), oriFile.getAbsolutePath(), true);
                backupFile.delete();
            }
        };
        return wrapper;
    }
}

[ January 22, 2004: Message edited by: Roel De Meester ]

[Dixon Alexander]

Originally posted by Jay Bromley:
Mark,
I too am using JUnit and a couple of custom classes to do unit tests. It's really good for peace of mind. Like Ken said, you can change something, even radically, then retest it. If it still works you're all good.
One question for Ken: Did you include your test classes in your uploaded project? I'm not intending to do this, does that sound ok?
Regards,
jb

Jay do no include Testing in your code I've been reading about JUnit and "JUnit In Action" says that you should just use JUnit testing for your internal testing needs, kind of like to simulate the actual customer of your product.
Hope this helps.

[Jay Bromley]

Ken and Dev,
THanks for confirming my suspicions about not submitting test code. I didn't want to do so, because my test code is not as "pretty" as the Sun Coding Conventions might want them to be, but I wasn't sure if the grader might be interested in them.
Thanks and regards,
jb