Record Data Cache.

[Muthaiah Ramanathan]

Guys,

I am caching the record data in a hashtable and having synchronised blocks where I wait for the lock on this hashtable before creating or updating or deleting, in the corresponding methods.

Here I am synchronizing the method so that no other thread changes the recNo or data or the lockCookie while a thread a executing this method.

 public synchronized void updateRecord(long recNo, String[] data,
                                          long lockCookie) throws
            RecordNotFoundException, SecurityException
    {        
        try
        {
            if (Data.getLockManager().isRecordLockedByCookie(recNo, lockCookie))
            {
                synchronized (Data.getRecordsTable())
                { 
                  //UPDATE THE RECORD....
                }
            }
    }

I am wondering if this is acceptable (or looks dump??). Any suggestion is appreciated.

Thanks,

Muthaiah.

[Daniel Dalton]

It's very different to whay I'm doing, but then there are loads of ways of doing things. I'd suggest that you make very, very sure that there is no possibility of introducing a thread deadlock situation by having a sunchronised block within a synchronised method as you've suggesting.

Do you need to synchronise the method itself? As far as I can see, recNo and lockCookie are thread local variables (each thread has its own stack, so other threads can't change the values of them).