locking help

[uzma ali]

the following method is in data.java which implements DBAccess interface

    
public void updateRecord(long recNo, String[] data, long lockCookie)
throws RecordNotFoundException, SecurityException { 
     lockCookie = lockRecord(recNo);
     database.updateRecord(recNo,data,lockCookie);
     unlock(recNo,lockCookie);
     }

Then I have a lockManager class which returns a cookie to be used in the above method

 public long lockRecord(long recNo)  {   
                 lock.lock();

return cookie;
}
 

I have another class DataFileAccess which gives the detail methods of Data.java

   
public void updateRecord(long recNo, String[] data, long lockCookie)
throws RecordNotFoundException, SecurityException {
//finally updates the database
}
 

If this is correct to call lock,update and then unloack from updateRecord method from Data.java

Please comment and any help is appreciated

uzma

[Xabier Martija]

No. The user of data.java should do it. But you should document it well.
Note that update(in data class) throws security exception if not provided with a valid coockie, so it has no sense that you lock and unlock in your data class.