May code writing style affect the grade?

Hi,

I am wondering which style of coding below is preferred.
Can the coding style affect the exam result?
What if in real business?

Style 1
<blockquote>code:

<pre name="code" class="java">
String[] theArray = {"scjd", ""};

int emptySlot = theArray[0].equals("") || theArray[1].equals("") ?
(theArray[0].equals("") ? 0 : 1):
-1;
</pre>

</blockquote>

Style 2
<blockquote>code:

<pre name="code" class="java">int emptySlot = -1;
String[] theArray = {"scjd", ""};

if (theArray [0].equals("") || theArray [1].equals("")) {
if (theArray [0].equals("")) {
emptySlot = 0;
} else {
emptySlot = 1;
}
} else {
emptySlot = -1;
}
</pre>

</blockquote>

Thanks a lot.

[ July 11, 2008: Message edited by: Shengshuo ]

[ July 11, 2008: Message edited by: Shengshuo ]
[ July 11, 2008: Message edited by: Shengshuo Wu ]

Hey, partner.

Yes, the way you code certainly affects your grade (I believe you lose some points in the "General Considerations" section of the marking criteria). You must follow the Java Coding Conventions.

In your example, according to the Java Coding Conventions, your second example is almost correct. It should be:

<blockquote>code:

<pre name="code" class="java">
int emptySlot = -1;
String [] theArray = {"scjd", ""};

if (theArray[0].equals("") || theArray[1].equals("")) {
if (theArray[0].equals("")) {
emptySlot = 0;
} else {
emptySlot = 1;
}
} else {
emptySlot = -1;
}
</pre>

</blockquote>

Hi Roberto,

Thank you for the prompt response.
I think I'll look more into the coding convention.

"Shengshuo", please check your private messages for an important administrative matter.

Btw, does the Style1 violate the convention really large?
Or it just seems confusing?

Hello, about the code that you have:

I believe you should be able to refactor it to:

I believe it does what you wanted in your example
[ August 01, 2008: Message edited by: Ulises Pulido ]

Originally posted by Ulises Pulido:
I believe you should be able to refactor it to:

code: int emptySlot = -1; String[] theArray = {"scjd", ""}; if (theArray [0].equals("") ) { emptySlot = 0; } else if ( theArray[1].equals("") ){ emptySlot = 1; }

I believe it does what you wanted in your example

I believe it is even better to do it like this:

In order to prevent NPE's when theArray[0] or theArray[1] are null.

Totally agree.

Originally posted by Jethro Borsje:

I believe it is even better to do it like this:
int emptySlot = -1; String[] theArray = {"scjd", ""}; if ("".equals(theArray[0])) { emptySlot = 0; } else if ("".equals(theArray[1])) { emptySlot = 1; }

In order to prevent NPE's when theArray[0] or theArray[1] are null.