Locked door help

[Martin vanPutten]

I'm building a neat little game where the user can type commands to go places and pick items up and whatnot. But I want to create a locked door into the construction room and only if the player picks up the key can they enter this key... otherwise the user cannot enter this room. I have many classes that all compile right and run great. Can anybody help me figure out how to create this locked room in construction room (to get there go west northeast northwest and northwest again).

  import java.util.*;
 
/**
 * Class Game - The game.
 * 
 * @author  Martin vanPutten
 * @version 2007.08.05
 */
 
public class Game 
{
  public static void main(String args[])
  {
  Game g = new Game();
  g.play();
  }  
  
    private Parser parser;
    private Player player;
    private Room currentRoom, prevRoom, outside, construction, chargeRoom, fireRoom;
    String playerName;
    private Scanner reader = new Scanner(System.in);
    
    public Game() 
    {
        createRooms();
        parser = new Parser();
        prevRoom = currentRoom;
        chargeRoom = currentRoom;
        player = new Player(playerName, currentRoom, 40, 0);
    }
 
    private void createRooms()
    {
        Room theatre, pub, lab, office, mainEntrance, hallway1, hallway2, hallway3, library;
      
        outside = new Room("outside the main entrance of the university");
        theatre = new Room("in a lecture theatre");
        pub = new Room("in the campus pub");
        lab = new Room("in a computing lab");
        office = new Room("in the computing admin office");
        mainEntrance = new Room("in the main entrance of university");
        hallway1 = new Room("in a hallway from office to theater");
        hallway2 = new Room("in a hallway outside pub");
        hallway3 = new Room("in a hallway outside lab");
        library = new Room("in the library");
        construction = new Room("in construction... turn around. There is a chute. Type 'fall' to fall down the chute. \nYou cannot use the beamer here. There is no return to this room. \nThis room has an aurora around it. You don't worry about it right now");
                
        currentRoom = outside; 
        
        outside.setExit("east", theatre);
        outside.setExit("south", lab);
        outside.setExit("west", pub); 
        outside.setExit("north", mainEntrance); 
        mainEntrance.setExit("south", outside);
        mainEntrance.setExit("west", hallway1); 
        mainEntrance.setExit("northeast", hallway2);
        hallway2.setExit("southwest", mainEntrance);
        hallway2.setExit("southeast", theatre);
        theatre.setExit("west", outside);
        theatre.setExit("south", office);
        theatre.setExit("southwest", lab);
        theatre.setExit("northwest", hallway2);
        pub.setExit("east", outside);
        pub.setExit("southeast", lab);
        pub.setExit("south", library);
        pub.setExit("northeast", hallway1);
        hallway1.setExit("southwest", pub);
        hallway1.setExit("east", mainEntrance);
        hallway1.setExit("northwest", hallway3);
        hallway3.setExit("southeast", hallway1);
        construction.setExit("southeast", hallway3);
        library.setExit("north", pub);
        library.setExit("east", lab);
        lab.setExit("north", outside);
        lab.setExit("east", office);
        lab.setExit("northeast", theatre);
        lab.setExit("northwest", pub);
        lab.setExit("west", library);
        office.setExit("west", lab);
        office.setExit("north", theatre);
        
        Item computer, flag, printer, book, ration, mouse, speakers, game, monitor, ring, key;
                
        computer = new Item(20, "Computer", "Alienware ALX Computer.");
        flag = new Item(5, "Flag", "Canada Flag.");
        printer = new Item(15, "Printer", "Canon Inkjet 530.");
        book = new Item(2, "Book", "The Lord Of The Rings.");
        ration = new Item(2, "Ration", "Hamburger.");
        mouse = new Item(1, "Mouse", "Logitech G7 Mouse.");
        speakers = new Item(4, "Speakers", "Logitech x540.");
        game = new Item(1, "PC Game", "Prince Of Persia game.");
        monitor = new Item(15, "Monitor", "Viewsonic Monitor");
        ring = new Item(1, "Ring", "Woodstock High School Graduate Ring.");
        key = new Item(1, "Key", "This key opens a locked door.");
        
        lab.setItem("computer", computer);
        lab.setItem("printer", printer);
        lab.setItem("mouse", mouse);
        lab.setItem("speakers", speakers);
        lab.setItem("game", game);
        lab.setItem("monitor", monitor);
        outside.setItem("flag", flag);
        library.setItem("book", book);
        pub.setItem("ration", ration);
        theatre.setItem("ring", ring);
        outside.setItem("key", key); 
        
        if()
        hallway3.setExit("northwest", construction);       
    }
    
    public void play() 
    {            
        printWelcome();
     
        boolean finished = false;
        while(! finished) 
        {
            Command command = parser.getCommand();
            finished = processCommand(command);
        }
        
        System.out.println("Thank you for playing. Good bye.");
    }
 
    private void printWelcome()
    {
  System.out.println("What is your name?");
playerName = reader.nextLine();
        System.out.println();
        System.out.println("Welcome " + playerName + " to the World of Zuul!");
        System.out.println("World of Zuul is a new, incredible adventure game.");
        System.out.println();
        System.out.println("Type 'help' if you need help.");
        System.out.println("You have a beamer to transport to rooms. \nType 'charge' to charge the beamer and 'fire' to transport.");
        System.out.println("You can only lift a total of 40 pounds. You will have to drop items to pick others up.");
        System.out.println();
        System.out.println(currentRoom.getLongDescription());
        System.out.println(currentRoom.getItemDescription());
    }
 
    private boolean processCommand(Command command) 
    {
        boolean wantToQuit = false;
 
        if(command.isUnknown()) 
        {
            System.out.println("I don't know what you mean...");
            return false;
        }
 
        String commandWord = command.getCommandWord();
        if(commandWord.equals("help")) 
            printHelp();
        else if(commandWord.equals("go")) 
            goRoom(command);
        else if(commandWord.equals("quit")) 
            wantToQuit = quit(command);
        else if(commandWord.equals("take")) 
            takeItem(command);
        else if(commandWord.equals("drop")) 
            dropItem(command);
        else if(commandWord.equals("items"))
        {
        if(command.hasSecondWord())
        System.out.println("Please type 'items' to access your inventory.");
        else
        System.out.println(player.playersInventory(command.getSecondWord()));
        }
        else if(commandWord.equals("back"))
        {
        if(command.hasSecondWord())
        System.out.println("Please type 'back' to go back.");
        else
        goBack();
        }
        else if(commandWord.equals("fall"))
        {
        if(currentRoom == construction)
        {
        if(command.hasSecondWord())
        System.out.println("Please type 'fall'. Should you really do this?");
        else
        fallDownChute();
        }
        else
        System.out.println("What are you talking about?");
        }
        else if(commandWord.equals("charge"))
        {
    if(command.hasSecondWord())
        System.out.println("Please type 'charge' to charge the beamer.");
        
        chargeRoom = currentRoom;
        System.out.println("The beamer has been charged.");
        }
        else if(commandWord.equals("fire"))
        {
        if(!prevRoom.equals(currentRoom))
    {
    currentRoom = chargeRoom;
    System.out.println(currentRoom.getLongDescription());
        System.out.println(currentRoom.getItemDescription());
    }
        }
        
        return wantToQuit;
    }
 
    private void printHelp() 
    {
        System.out.println("You are lost. You are alone. You wander around at the university.");
        System.out.println();
        System.out.println("Your command words are:");
        parser.showCommands();
    }
 
    private void goRoom(Command command) 
    {
        if(!command.hasSecondWord()) 
            System.out.println("Go where?");
 
        String direction = command.getSecondWord();
 
        Room nextRoom = currentRoom.getExit(direction);
 
        if(nextRoom == null)
            System.out.println("There is no door!");
        else 
        {
prevRoom = currentRoom;
            currentRoom = nextRoom;
            System.out.println(currentRoom.getLongDescription());
        System.out.println(currentRoom.getItemDescription());
        }
    }
    
    public void takeItem(Command command) 
    {    
        if(!command.hasSecondWord()) 
            System.out.println("Take what?");
 
        String itemName = command.getSecondWord();
 
        Item items = currentRoom.getItem(itemName);
        
        if(items == null) 
            System.out.println("You do not have that item!");
        else
        {  
        if(player.getCurrentWeight() >= player.getMaxWeight())
        System.out.println("You cannot pick up any more items. Drop some first.");
        else
        {
        player.putItem(itemName, items);
        System.out.println("You picked up a " + itemName);
        
        player.setCurrentWeight(player.getCurrentWeight() + items.getWeight());
        
        currentRoom.removeItem(itemName);
        }
        }
    }
    
    public void dropItem(Command command) 
    {    
        if(!command.hasSecondWord())
            System.out.println("Drop what?");
 
        String itemName = command.getSecondWord();
 
        Item items = player.getItem(itemName); 
        
        if(items == null)
        System.out.println("You have no items!");
        else
        {
        currentRoom.putItem(itemName, items);
        System.out.println("You have dropped a " + itemName);
        
        player.setCurrentWeight(player.getCurrentWeight() - items.getWeight());
        
        player.removeItem(itemName);
        }
    }
    
    private void goBack()
    {
    if(!prevRoom.equals(currentRoom))
    {
    currentRoom = prevRoom;
    System.out.println(currentRoom.getLongDescription());
        System.out.println(currentRoom.getItemDescription());
    }
    else
    System.out.println("You cannot go back any farther.");
    }
    
    private void fallDownChute()
    {
    currentRoom = outside;
    prevRoom = currentRoom;
        System.out.println(currentRoom.getLongDescription());
        System.out.println(currentRoom.getItemDescription());
    }
    
    private boolean quit(Command command) 
    {
        if(command.hasSecondWord()) 
        {
            System.out.println("Quit what?");
            return false;
        }
        else 
            return true; 
    }
}
 
  

  import java.util.Scanner;
import java.util.StringTokenizer;
 
/**
 * Class Parser - Creates inputs and reading.
 * 
 * @author  Martin vanPutten
 * @version 2007.08.05
 */
 
public class Parser 
{
    private CommandWords commands;  
    private Scanner reader;    
 
    public Parser() 
    {
        commands = new CommandWords();
        reader = new Scanner(System.in);
    }
 
    public Command getCommand() 
    {
        String inputLine; 
        String word1 = null;
        String word2 = null;
 
        System.out.print("> ");  
 
        inputLine = reader.nextLine();
 
        Scanner tokenizer = new Scanner(inputLine);
        if(tokenizer.hasNext()) 
        {
            word1 = tokenizer.next();
            if(tokenizer.hasNext()) 
                word2 = tokenizer.next(); 
        }
 
        if(commands.isCommand(word1)) 
            return new Command(word1, word2);
        else 
            return new Command(null, word2); 
    }
 
    public void showCommands()
    {
        commands.showAll();
    }
}
  

  import java.util.*;
 
/**
 * Class Player - The rooms.
 * 
 * @author  Martin vanPutten
 * @version 2007.08.05
 */
 
public class Room
{
    private String description;
    private HashMap<String, Room> exits; 
    private HashMap<String, Item> items;
 
    public Room(String description) 
    {
        this.description = description;
        exits = new HashMap<String, Room>();
        items = new HashMap<String, Item>();
    }
    
    public Item getItem(String itemName)
    {
    return items.get(itemName);
    }
       
    public void setExit(String direction, Room neighbor) 
    {
        exits.put(direction, neighbor);
    }

    public void setItem(String itemName, Item giveItem)
    {
    items.put(itemName, giveItem);
    }
 
    public String getShortDescription()
    {
        return description;
    }
 
    public String getLongDescription()
    {
        return "You are " + description + ".\n" + getExitString();
    }
    
    public String getItemDescription()
    {
    if(items.size() == 0)
    return "There are no items in this room.";
    else
    {        
    String returnString = "Items:";
        Collection<Item> itemList = items.values();
        for(Item item : itemList) 
            returnString += " " + item.getName() + ". " + item.getWeight() + " pounds. " + item.getDescription() + "\n";
        return returnString;
    }
    }
 
    private String getExitString()
    {
        String returnString = "Exits:";
        Set<String> theExits = exits.keySet();
        for(String exit : theExits) 
            returnString += " " + exit;
        return returnString;
    }
    
    public void putItem(String name, Item theItem)
    {
    this.items.put(name, theItem);
    }
 
    public Room getExit(String direction) 
    {
        return exits.get(direction);
    }
    
    public void removeItem(String itemName)
    {
    items.remove(itemName);
    }
}
 
  

  /**
 * Class Player - The command words.
 * 
 * @author  Martin vanPutten
 * @version 2007.08.05
 */
 
public class CommandWords
{
    private static final String[] validCommands = 
    {
        "go", "quit", "help", "back", "take", "drop", "items", "fall", "charge", "fire"
    };
 
    public boolean isCommand(String aString)
    {
        for(int i = 0; i < validCommands.length; i++)
            if(validCommands[i].equals(aString))
                return true;
                
        return false;
    }
 
    public void showAll() 
    {
        for(String command: validCommands) 
            System.out.print(command + "  ");
        
        System.out.println();
    }
}
  

  /**
 * Class Player - How the command words operate.
 * 
 * @author  Martin vanPutten
 * @version 2007.08.05
 */
 
public class Command
{
    private String commandWord;
    private String secondWord;
 
    public Command(String firstWord, String secondWord)
    {
        commandWord = firstWord;
        this.secondWord = secondWord;
    }
 
    public String getCommandWord()
    {
        return commandWord;
    }
 
    public String getSecondWord()
    {
        return secondWord;
    }
 
    public boolean isUnknown()
    {
        return (commandWord == null);
    }
 
    public boolean hasSecondWord()
    {
        return (secondWord != null);
    }
}
 
  

  import java.util.*;
 
/**
 * Class Item - All the items in the game
 * 
 * @author  Martin vanPutten
 * @version 2007.02.05
 */
 
public class Item
{
private int weight;
private String name;
private String Idescription;

public Item(int weight, String name, String Idescription)
{
this.weight = weight;
this.name = name;
this.Idescription = Idescription;
}

public int getWeight()
{
return weight;
}

public String getName()
{
return name;
}

public String getDescription()
{
return Idescription;
}
}  

  import java.util.*;
 
/**
 * Class Player - Player in the game.
 * 
 * @author  Martin vanPutten
 * @version 2007.08.05
 */
 
public class Player
{
private String playerName;
private Room currentRoom;
private int maxWeight;
private Item itemInfo;
private int currentWeight;
    private HashMap<String, Item> items;

public Player(String playerName, Room currentRoom, int maxWeight, int weight)
{
this.playerName = playerName;
this.currentRoom = currentRoom;
this.maxWeight = maxWeight;
currentWeight = weight;
        items = new HashMap<String, Item>();
}

public String getPlayerName()
{
return playerName;
}

public int getMaxWeight()
{
return maxWeight;
}

public void setCurrentWeight(int weight)
{
currentWeight = weight;
}

public int getCurrentWeight()
{
return currentWeight;
}
    
    public Item getItem(String itemName)
    {
    return items.get(itemName);
    }
    
    public void putItem(String name, Item theItem)
    {
    this.items.put(name, theItem);
    itemInfo = theItem;
    }
    
    public void setItem(String itemName, Item giveItem)
    {
    items.put(itemName, giveItem);
    }
    
    public String getItemDescription()
    {
    if(items.size() == 0)
    return "There are no items in this room.";
    else
    {    
    String returnString = "Items:";
        Set<String> keys = items.keySet();
        for(String item : keys) 
            returnString += " " + item;
        return returnString;
    }
    }
    
    public String returnItems()
    {
    String returnString = "";
        Set<String> keys = items.keySet();
        for(String item : keys) 
            returnString = item;
        return returnString;
    }
    
    public void removeItem(String itemName)
    {
    items.remove(itemName);
    }
    
    public String playersInventory(String item)
    {
    Item getItem = items.get(item);
    if(items.size() == 0)
    return "You do not have any items!";
    else
    {    
    String returnString = "Inventory:";
        Set<String> itemList = items.keySet();
        for(String items : itemList) 
            returnString += " " + items;
        return returnString + "\nThe total weight you are carrying is " + currentWeight + " pounds.";
    }
    }
}
  

[ March 08, 2007: Message edited by: Bear Bibeault ]

[Gregg Bolinger]

Well Martin, that is quite a bit of code and quite honestly, I can't imagine a lot of people wanting to traverse through all that. We all have limited time here.

It would be better for us if you could pinpoint your issue a bit more and narrow the code we need to look at down quite a bit. Without looking at the code and just brainstorming here is what I might do.

If I had an inventory class I might have 1 or more keys. A door would have a simple boolean property of locked = true|false. And maybe a property of which key it needs. When I encounter a locked door, a) check my inventory for said key and change boolean of locked or b) upon submitting a key to a locked door, change the boolean of locked. Only allow passage through a door if the locked boolean is false. Does that help?

[Justin Fox]

you can add certain properties to a player with the hashmap.
if they find say "magical key" add it to their hash map / inventory.

if the person comes across the door, search their person for the key
if no key no get in lol.

Justin

[Gregg Bolinger]

Originally posted by Justin Fox:
you can add certain properties to a player with the hashmap.
if they find say "magical key" add it to their hash map / inventory.

if the person comes across the door, search their person for the key
if no key no get in lol.

Justin

How is that different than what I suggested? :roll:

[Justin Fox]

i didnt read yours


Justin

[Gregg Bolinger]

Originally posted by Justin Fox:
i didnt read yours


Justin

Exactly.

[Gavin Tranter]

You could create a Lock class, the lock could have an ID, and a state (open or locked), a method to check the state and to set the state open or closed. (providing for both allows for in game events to lock the door again, like not being able to escape a room before a foe is defeated).

Then you need a Key class with a matching ID.

As others have suggested give the door a method to detected if the door is locked or not. This method is just a call though to a method in the Lock class that determines if the lock is open or closed.

If the code detects that the player has the key with the right ID the door opens. (A basic search of all object of type Key in the users inventry.)

The advantage of this method is that you can reuse the lock and key for any item, not just doors. Also it allows for doors to have different types of locks, perhaps having two keys.

As locking a "thing" is rather generic. It could be implemented either using aggregation (as described above) or as an interface (Lockable), and some form of key interface (Keyable? ).

Either method allows for different objects to be locked or to be given the ability to unlock items, for example a magic wand, you could lock the use of the magic wand until some other item is found, or a magic wand could be used to open certain items (doors, chests etc).

Its probably a bit more code initially, but I think as your game grows it might prove more helpful in the long run.

hope this helps
G

[ March 19, 2007: Message edited by: Gavin Tranter ]
[ March 19, 2007: Message edited by: Gavin Tranter ]

[Gregg Bolinger]

I like Gavin's approach. And don't forget about lock picking.

[Gavin Tranter]

Locks that can be picked??

hmmmm

Oh, thanks
I have set up some classes, and it seems to work quite well, obivously they
they are a bit mickey (or mini if you prefer) mouse.
[ March 19, 2007: Message edited by: Gavin Tranter ]