selectOneMenu from database

Hi All,
Why my code doesn't works? After code execution on JSP page I get empty selectOneMenu. Please help me!

Page: test1.jsp:

<html>

<%@ taglib uri="http://java.sun.com/jsf/core" prefix="f" %>
<%@ taglib uri="http://java.sun.com/jsf/html" prefix="h" %>

<f:view>
<head>
<link href="styles.css" rel="stylesheet" type="text/css"/>
<title>

</title>
</head>
<body>
<h:form >

<h:selectOneMenu value="#{test1.value}">
<f:selectItems value="#{test1.values}" />
</h:selectOneMenu>

</h:form>
</body>
</f:view>
</html>

Bean: Test1.java

public class Test1 extends FacesBean {

ArrayList arrayList = new ArrayList();

public SelectItem[] getValues() {
        return arrayListToSelectItem(arrayList);
    }

public SelectItem[] arrayListToSelectItem(ArrayList arrayList) 
  {
         SelectItem[] result = new SelectItem[arrayList.size()];
         arrayList.toArray(result);
         return result;
     }

private Connection conn;
    
    public void open() throws SQLException, NamingException{
    
    if (conn != null) return;
    Context ctx = new InitialContext();
    DataSource ds = (DataSource) ctx.lookup("java:comp/env/jdbc/mydb");
    conn = ds.getConnection();
     }

public ArrayList getNames() throws SQLException, NamingException {

ArrayList arrayList = new ArrayList();
String SQL_query = "SELECT NAME FROM MYDB.DEPARTMENT";

try{
      open();
      
      Statement stmt = conn.createStatement();
      ResultSet result = stmt.executeQuery(SQL_query);
      
      
      while (result.next()) {
            arrayList.add(new SelectItem(result.getString(1)));
        }         
      
      
      return arrayList;
    
}finally{
    close();
    }
}
    
   
    public void close() throws SQLException {
    if (conn == null) return;
    conn.close();
    conn = null;
    
    }
    
}

faces-config.xml:

<managed-bean>
<managed-bean-name>test1</managed-bean-name>
<managed-bean-class>com.va.epms.dept.Test1</managed-bean-class>
<managed-bean-scope>request</managed-bean-scope>
</managed-bean>

You probably are not seeing the menu labels on the page. Try this:
SelectItem(java.lang.Object value, java.lang.String label)
instead of this:
SelectItem(java.lang.Object value).
This will construct a SelectItem with the specified value and label.

Also from the code I could not figure out if you are calling the getNames() anywhere. Did you verify that this method gets called and the resultset is not empty?
[ October 31, 2007: Message edited by: A. Dusi ]

Thanks A. Dusi !

With pleasure would look at a similar working code, (code must work with database) !!!

Guys, I solved this broblem. My implementation isn't perfect, but he works!

Bean: Test1.java

package com.va.epms.dept;
 
import java.sql.Connection;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;

import javax.faces.model.ArrayDataModel;
import javax.faces.model.SelectItem;
import javax.naming.Context;
import javax.naming.InitialContext;
import javax.naming.NamingException;
import javax.servlet.jsp.jstl.sql.Result;
import javax.servlet.jsp.jstl.sql.ResultSupport;
import javax.sql.DataSource;
 
import com.sun.jsfcl.app.FacesBean;
 
import java.util.ArrayList;
 
public class Test1  {

String s = "SELECT NAME FROM EPMS.DEPARTMENT";

ArrayList<SelectItem> arrayList3 = null;
ArrayList<SelectItem> arrayList =  abra(arrayList3) ;

public ArrayList<SelectItem> abra(ArrayList<SelectItem> arrayList3 ){

try {
arrayList = getNames2(s) ;
} catch (SQLException e) {

e.printStackTrace();
} catch (NamingException e) {

e.printStackTrace();
}

return  arrayList;

}

public SelectItem[] getValues() {
        return arrayListToSelectItem(arrayList);
    }

public SelectItem[] arrayListToSelectItem(ArrayList<SelectItem> arrayList) 
  {
         SelectItem[] result = new SelectItem[arrayList.size()];
         arrayList.toArray(result);
         return result;
     }
 
 
private Connection conn;
    
    public void open() throws SQLException, NamingException{
    
    if (conn != null) return;
    Context ctx = new InitialContext();
    DataSource ds = (DataSource) ctx.lookup("java:comp/env/jdbc/mydb");
    conn = ds.getConnection();
     }

//public ArrayList<SelectItem> throws SQLException, NamingException {

public ArrayList<SelectItem>  getNames2(String s) throws SQLException, NamingException   {
  ArrayList<SelectItem> arrayList2 = new ArrayList<SelectItem>();

try{
      open();
      
      Statement stmt = conn.createStatement();
      ResultSet result = stmt.executeQuery(s);
            
      while (result.next()) {
            arrayList2.add(new SelectItem(result.getString(1)));
        }         
      
      
     return arrayList2;
    
}finally{
    close();
    }

}
    
       
    
    public void close() throws SQLException {
    if (conn == null) return;
    conn.close();
    conn = null;
    
    }
    
}