My app displays memory leaks: please help

[Julien Martin]

Hello,

I am new to hibernate and I have the following problem: my app has memory leaks or an abnormally high memory consumption...

-My question is should the entity manager be a static variable?
-How can I control the cache, flush it?


Here are some classes that I suspect are the culprits of the above problem:

package com.calyonfinancial.protide;
 
import com.calyonfinancial.protide.entities.Protide01p;
import com.calyonfinancial.protide.persistence.PersistenceUtil;
import java.io.IOException;
import javax.faces.component.html.HtmlDataTable;
import javax.faces.component.html.HtmlInputHidden;
import javax.faces.context.FacesContext;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.log4j.Logger;
 
/**
 *
 * @author Julien Martin
 */
public class ContractManagedBean {
    
    private static Logger log = Logger.getLogger("com.calyonfinancial.protide");
    private ContractCaracteristicsBean contractCaracteristicsBean = new ContractCaracteristicsBean();
    private ContractDetailsBean contractDetailsBean = new ContractDetailsBean();
    private ContractAccountsBean contractAccountsBean = new ContractAccountsBean();
    private PersistenceUtil pu = new PersistenceUtil();
    private String messageViewId = "/includes/input-screen/errorMessage.jsp";
    private HtmlDataTable protide01p;
    private ContractBackingBean contractBackingBean= new ContractBackingBean();
    private HtmlInputHidden trOrderIdInputHidden;
    private boolean contractForUpdate;
    private Integer trOrderIdForUpdate;
    
    
    /////////////////////////////////////////////////////////////
    //Constructor
    /////////////////////////////////////////////////////////////
    public ContractManagedBean() {
    }
    
    
    /////////////////////////////////////////////////////////////
    //Getters and setters
    /////////////////////////////////////////////////////////////
    public ContractCaracteristicsBean getContractCaracteristicsBean() {
        return contractCaracteristicsBean;
    }
    
    public void setContractCaracteristicsBean(ContractCaracteristicsBean contractCaracteristicsBean) {
        this.contractCaracteristicsBean = contractCaracteristicsBean;
    }
    
    public ContractDetailsBean getContractDetailsBean() {
        return contractDetailsBean;
    }
    
    public void setContractDetailsBean(ContractDetailsBean contractDetailsBean) {
        this.contractDetailsBean = contractDetailsBean;
    }
    
    public ContractAccountsBean getContractAccountsBean() {
        return contractAccountsBean;
    }
    
    public void setContractAccountsBean(ContractAccountsBean contractAccountsBean) {
        this.contractAccountsBean = contractAccountsBean;
    }
    
    public String getMessageViewId() {
        return messageViewId;
    }
    
    public void setMessageViewId(String messageViewId) {
        this.messageViewId = messageViewId;
    }
    
    public HtmlDataTable getProtide01p() {
        return protide01p;
    }
    
    public void setProtide01p(HtmlDataTable protide01p) {
        this.protide01p = protide01p;
    }
    
    public boolean isContractForUpdate() {
        return contractForUpdate;
    }
    
    public void setContractForUpdate(boolean contractForUpdate) {
        this.contractForUpdate = contractForUpdate;
    }
    
    public ContractBackingBean getContractBackingBean() {
        return contractBackingBean;
    }
    
    public void setContractBackingBean(ContractBackingBean contractBackingBean) {
        this.contractBackingBean = contractBackingBean;
    }
    
    public Integer getTrOrderIdForUpdate() {
        return trOrderIdForUpdate;
    }
    
    public void setTrOrderIdForUpdate(Integer trOrderIdForUpdate) {
        this.trOrderIdForUpdate = trOrderIdForUpdate;
    }
    
    public HtmlInputHidden getTrOrderIdInputHidden() {
        return trOrderIdInputHidden;
    }
 
    public void setTrOrderIdInputHidden(HtmlInputHidden trOrderIdInputHidden) {
        this.trOrderIdInputHidden = trOrderIdInputHidden;
    }
 
    
    /////////////////////////////////////////////////////////////
    //Action methods called from jsp
    /////////////////////////////////////////////////////////////
    
    public String saveContractAction(){
        log.info("saveContractAction");
        HttpServletResponse response = (HttpServletResponse) FacesContext.getCurrentInstance().getExternalContext().getResponse();
        // messageViewId = "/includes/input-screen/confirmationMessage.jsp";
        boolean contractSaved = pu.saveContractToDatabase(this.contractCaracteristicsBean, this.contractDetailsBean, this.contractAccountsBean);
//        if (contractSaved){
//            return "ok";
//        } else{
        messageViewId = "/includes/input-screen/errorMessage.jsp";
//            return "problem";
//        }
        try {
            response.sendRedirect("home.jsf");
        } catch (IOException ex) {
            log.error("IOException", ex);
        }
        return null;
    }
    
    public String deleteContractAction(){
        log.info("deleteContractAction");
        HttpServletResponse response = (HttpServletResponse) FacesContext.getCurrentInstance().getExternalContext().getResponse();
        Protide01p protide01pBean =  (Protide01p) getProtide01p().getRowData();
        log.info("TrSource " + protide01pBean.getTrSource());
        pu.deleteContract(protide01pBean);
        try {
            response.sendRedirect("home.jsf");
        } catch (IOException ex) {
           log.error("IOException", ex);
        }
        return "ok";
    }
    
    public String updateContractAction(){
        log.info("updateContractAction");
        HttpServletResponse response = (HttpServletResponse) FacesContext.getCurrentInstance().getExternalContext().getResponse();
        HttpServletRequest request = (HttpServletRequest) FacesContext.getCurrentInstance().getExternalContext().getRequest();
        //String param = (String) FacesContext.getCurrentInstance().getExternalContext().getRequestParameterMap().get("trorderid_param");
        log.info(request.getParameter("main-form:ecran-saisie:control-panel:trOrderIdForUpdate"));
        Integer trorderid = Integer.parseInt(request.getParameter("main-form:ecran-saisie:control-panel:trOrderIdForUpdate"));
        pu.updateContract(this.contractCaracteristicsBean, this.contractDetailsBean, this.contractAccountsBean, trorderid);
        contractForUpdate = false;
        try {
            response.sendRedirect("home.jsf");
        } catch (IOException ex) {
           log.error("IOException", ex);
        }
        return "ok";
    }
    
    
    public String retrieveLineAction(){
        log.info("retrieveLineAction");
        Protide01p line =  (Protide01p) getProtide01p().getRowData();
        ContractAggregatorBean agg = ContractFactory.constructContractAggregator(line);
        
        trOrderIdForUpdate=line.getTrOrderid();
        
        log.info("test three" + trOrderIdForUpdate);
        
        contractCaracteristicsBean = agg.getContractCaracteristicsBean();
        contractDetailsBean = agg.getContractDetailsBean();
        contractAccountsBean = agg.getContractAccountsBean();
        
        trOrderIdInputHidden.setLocalValueSet(false);
        trOrderIdInputHidden.setSubmittedValue(null);
        
        contractBackingBean.setAllLocalValuesSet(false);
        contractBackingBean.setAllSubmittedValues(null);
        
        contractForUpdate = true;
       
        return "ok";
    }
    
}
 

  package com.calyonfinancial.protide.persistence;
 
import com.calyonfinancial.protide.ContractAccountsBean;
import com.calyonfinancial.protide.ContractCaracteristicsBean;
import com.calyonfinancial.protide.ContractDetailsBean;
import com.calyonfinancial.protide.blobtests.UploadedDocumentBean;
import com.calyonfinancial.protide.entities.Blobtests;
import com.calyonfinancial.protide.entities.Protide01p;
import com.calyonfinancial.protide.misc.EntityManagerUtil;
import com.calyonfinancial.protide.misc.SequenceUtil;
import java.io.IOException;
import java.util.Date;
import java.util.Random;
import javax.persistence.EntityManager;
import javax.persistence.EntityManagerFactory;
import org.apache.log4j.Logger;
 
/**
 *
 * @author Julien Martin
 */
public class PersistenceUtil {
    
    private static Logger log = Logger.getLogger("com.calyonfinancial.protide");
    private EntityManagerFactory emf = EntityManagerUtil.getInstance().getEntityManagerFactory();
    private EntityManager em = emf.createEntityManager();
    private SequenceUtil su = new SequenceUtil();
    
    public PersistenceUtil() {
        log.info("PersistenceUtil");
        
    }
    
    public void saveDocumentToDatabase(UploadedDocumentBean documentBean) {//todo: will need to be split into two methods, private and public
        log.info("saveDocumentToDatabase");
        log.info("'"+documentBean.getDescription()+"'");
        try {
            Blobtests instance = new Blobtests();
            instance.setDescription(documentBean.getDescription());
            instance.setDocument(documentBean.getDocument().getBytes());
            instance.setFilename(documentBean.getDocument().getName());
            instance.setDocumentSize(documentBean.getDocument().getSize());
            //instance.setFk(documentBean.getFk());
            instance.setFk(1);//todo: will come from the web
            instance.setId(new Random().nextInt());//todo: will need to change
            
            em.getTransaction().begin();
            em.persist(instance);
            em.getTransaction().commit();
        } catch(IOException e) {
            log.fatal("IOException", e);
            em.getTransaction().rollback();
        } finally {
             log.info("Closing entity manager");
            em.close();
        }
    }
    
    public boolean saveContractToDatabase(ContractCaracteristicsBean ccb, ContractDetailsBean cdb, ContractAccountsBean cab){
        log.info("saveContractToDatabase");
        return _saveContractToDatabase(ccb, cdb, cab);
    }
    
    private boolean _saveContractToDatabase(ContractCaracteristicsBean ccb, ContractDetailsBean cdb, ContractAccountsBean cab) {
        log.info("_saveContractToDatabase");
        try {
            em.getTransaction().begin();
            Protide01p instance = new Protide01p();
            instance.setAmountRange(cdb.getAmountRange());
            instance.setCashFlow(cdb.getCashFlow());
            instance.setCashFlowType(cdb.getCashFlowType());
            instance.setCounterpartCountry(cab.getCounterpartCountry());
            instance.setCreateBy("default user");//todo: hard coded
            instance.setCreateDate(new Date());//todo hard coded
            instance.setCurrency(cdb.getCurrency());
            instance.setDescription(ccb.getDescription());
            //instance.setFlag1();
            //instance.setFlag2();
            instance.setHolderAge(cab.getHolderAge());
            instance.setHolderArea(cab.getHolderArea());
            instance.setHolderCountry(cab.getHolderCountry());
            instance.setHolderIndustry(cab.getHolderIndustry());
            instance.setHolderSocialEconCategory(cab.getHolderSocialEconCategory());
            instance.setHolderThreshold(cab.getHolderThreshold());
            instance.setHoldingType(cdb.getHoldingType());
            instance.setInstrumentType(ccb.getInstrumentType());
            instance.setIsin(ccb.getIsin().toUpperCase());
            instance.setIssuerArea(ccb.getIssuerArea());
            instance.setIssuerCountry(ccb.getIssuerCountry());
            instance.setIssuerIndustry(ccb.getIssuerIndustry());
            instance.setMaturity(cdb.getMaturity());
            //instance.setModifiedBy();
            //instance.setModifiedDate();
            //instance.setNum1();
            instance.setNumberOfAccounts(cab.getNumberOfAccounts());
            instance.setNumberOfSecurities(cdb.getNumberOfSecurities());
            //instance.setOutstandingEndCurPeriod()//calcul
            //instance.setOutstandingEndPrevPeriod()//calcul
            instance.setPotrfolioType(cdb.getPotrfolioType());
            //instance.setRecordNumber()//calcul
            instance.setEquityDate(cdb.getEquityDate());
            instance.setTrAction('I');
            instance.setTrSource(su.getNextVal());
            instance.setTrOrderid(su.getPrevVal());
            
            em.persist(instance);
            em.getTransaction().commit();
            return true;
        } catch(Exception e) {
            log.fatal("Exception", e);
            //todo: create a facesmessage here
            em.getTransaction().rollback();
            return false;
        } finally {
            log.info("Closing entity manager");
            em.close();
        }
    }
    
    public void deleteContract(Protide01p protide01pBean) {
        log.info("deleteContract");
        _deleteContract(protide01pBean);
    }
    
    private void _deleteContract(Protide01p protide01pBean) {
        log.info("_deleteContract");
        try {
            em.getTransaction().begin();
            Protide01p instance = protide01pBean;
            instance.setCreateBy("default user");//todo: hard coded
            instance.setTrSource(su.getNextVal());
            instance.setTrAction('D');
            em.persist(instance);
            em.getTransaction().commit();
            
        } catch(Exception e) {
            log.fatal("Exception", e);
            //todo: create a facesmessage here
            em.getTransaction().rollback();
        } finally {
            log.info("Closing entity manager");
            em.close();
        }
    }
    
    public void updateContract(ContractCaracteristicsBean ccb, ContractDetailsBean cdb, ContractAccountsBean cab, Integer trorderid) {
        _updateContract(ccb, cdb, cab, trorderid);
    }
    
    private void _updateContract(ContractCaracteristicsBean ccb, ContractDetailsBean cdb, ContractAccountsBean cab, Integer trorderid) {
        log.info("_updateContract");
        try {
            em.getTransaction().begin();
            Protide01p instance = new Protide01p();
            instance.setAmountRange(cdb.getAmountRange());
            instance.setCashFlow(cdb.getCashFlow());
            instance.setCashFlowType(cdb.getCashFlowType());
            instance.setCounterpartCountry(cab.getCounterpartCountry());
            instance.setCreateBy("default user");//todo: hard coded
            instance.setCreateDate(new Date());//todo hard coded
            instance.setCurrency(cdb.getCurrency());
            instance.setDescription(ccb.getDescription());
            //instance.setFlag1();
            //instance.setFlag2();
            instance.setHolderAge(cab.getHolderAge());
            instance.setHolderArea(cab.getHolderArea());
            instance.setHolderCountry(cab.getHolderCountry());
            instance.setHolderIndustry(cab.getHolderIndustry());
            instance.setHolderSocialEconCategory(cab.getHolderSocialEconCategory());
            instance.setHolderThreshold(cab.getHolderThreshold());
            instance.setHoldingType(cdb.getHoldingType());
            instance.setInstrumentType(ccb.getInstrumentType());
            instance.setIsin(ccb.getIsin().toUpperCase());
            instance.setIssuerArea(ccb.getIssuerArea());
            instance.setIssuerCountry(ccb.getIssuerCountry());
            instance.setIssuerIndustry(ccb.getIssuerIndustry());
            instance.setMaturity(cdb.getMaturity());
            //instance.setModifiedBy();
            //instance.setModifiedDate();
            //instance.setNum1();
            instance.setNumberOfAccounts(cab.getNumberOfAccounts());
            instance.setNumberOfSecurities(cdb.getNumberOfSecurities());
            //instance.setOutstandingEndCurPeriod()//calcul
            //instance.setOutstandingEndPrevPeriod()//calcul
            instance.setPotrfolioType(cdb.getPotrfolioType());
            //instance.setRecordNumber()//calcul
            instance.setEquityDate(cdb.getEquityDate());
            instance.setTrAction('U');
            instance.setTrSource(su.getNextVal());
            instance.setTrOrderid(trorderid);
            
            em.persist(instance);
            em.getTransaction().commit();
            
        } catch(Exception e) {
            log.fatal("Exception", e);
            //todo: create a facesmessage here
            em.getTransaction().rollback();
        } finally {
            log.info("Closing entity manager");
            em.close();
        }
        
    }
    
    
    
    
}  

Any clue?

Thanks in advance,

Julien.