many side of one to many not being populated

[Mike London]

I'm trying to populate two tables: a user table and a user visit history table.

The user table code is working fine, but the many table (uservisithistory) doesn't get populated.

I think it may be in the mapping files.

I have the PK generation set to automatic in MySQL with no nulls, etc.

Here are the mapping files:

Users Table

   <hibernate-mapping>
    <class name="TestProject.Users" table="users" catalog="users">
        <id name="usrPk" type="java.lang.Integer">
            <column name="usr_pk" />
            <generator class="increment" />
        </id>
        <property name="usrIsPaidUser" type="java.lang.Byte">
            <column name="usr_isPaidUser" not-null="true" />
        </property>
        <property name="usrAccountExpires" type="java.lang.Byte">
            <column name="usr_accountExpires" not-null="true" />
        </property>
        <property name="usrAccountExpireDate" type="java.util.Date">
            <column name="usr_accountExpireDate" length="19" />
        </property>
        <property name="usrFname" type="java.lang.String">
            <column name="usr_fname" length="20" not-null="true" />
        </property>
        <property name="usrMi" type="java.lang.String">
            <column name="usr_mi" length="1" />
        </property>
        <property name="usrLname" type="java.lang.String">
            <column name="usr_lname" length="25" not-null="true" />
        </property>
        <property name="usrEmail" type="java.lang.String">
            <column name="usr_email" length="45" />
        </property>
        <property name="usrPhone" type="java.lang.String">
            <column name="usr_phone" length="25" />
        </property>
        <property name="usrLastlogindate" type="java.util.Date">
            <column name="usr_lastlogindate" length="19" />
        </property>
        <property name="usrAccountactive" type="java.lang.Byte">
            <column name="usr_accountactive" not-null="true" />
        </property>
        <property name="usrLogin" type="java.lang.String">
            <column name="usr_login" length="45" not-null="true" />
        </property>
        <property name="usrPassword" type="java.lang.String">
            <column name="usr_password" length="20" not-null="true" />
        </property>
        <set name="uservisithistories" inverse="true">
            <key>
                <column name="usr_pk" not-null="true">
                    <comment>foreign key back to users table.</comment>
                </column>
            </key>
            <one-to-many class="TestProject.Uservisithistory" />
        </set>
    </class>
</hibernate-mapping>
 
 

Here is the mapping for the user visit history (many side) table:

 <hibernate-mapping>
    <class name="TestProject.Uservisithistory" table="uservisithistory" catalog="users">
        <id name="uvhPk" type="java.lang.Integer">
            <column name="uvh_pk" />
            <generator class="increment" />
        </id>
        <many-to-one name="users" class="TestProject.Users" fetch="select">
            <column name="usr_pk" not-null="true">
                <comment>foreign key back to users table.</comment>
            </column>
        </many-to-one>
        <property name="uvhDateTimeOfVisit" type="java.util.Date">
            <column name="uvh_dateTimeOfVisit" length="19" />
        </property>
        <property name="uvhPageFrom" type="java.lang.String">
            <column name="uvh_pageFrom" length="45" not-null="true" />
        </property>
    </class>
</hibernate-mapping>
 
   

The code to create the many side I do inside a test "main" method like this:
(see: "// add new visit history record" below)

 
 
   Users newUser = new Users();
        newUser.setUsrAccountactive((byte) 1);
        
        newUser.setUsrAccountExpires((byte)0);
        
//        // set expiration date from one year from now       
        Calendar now = Calendar.getInstance();
        now.add(Calendar.YEAR, 1);
        Date dateToStore = now.getTime();        
        newUser.setUsrAccountExpireDate(dateToStore);
        
        // set user first name and last name
        newUser.setUsrFname("admin");
        newUser.setUsrLname("admin");
        
        // user doesn't pay.
        newUser.setUsrIsPaidUser((byte) 0);
        
        // set user login/password
        newUser.setUsrLogin("[e-mail]");
        newUser.setUsrPassword("123456");
        
        // add new visit history record
        // ****** CODE BELOW DOES NOT WORK -> No Population in many table
 
        Uservisithistory uvh = new Uservisithistory();
        uvh.setUsers(newUser);
        uvh.setUvhDateTimeOfVisit(dateToStore);
        uvh.setUvhPageFrom("home page");
        HashSet<Uservisithistory> set = new HashSet <Uservisithistory>();
        set.add(uvh);
        
        newUser.setUservisithistories(set);
        
        
        // save user
        
      dao.save(newUser);
      transaction.commit();
        
      }
 
   

The strange thing to me is that the mapping file I generated has a "Users" element in the many side.

I think the reason it might not be populating the many side is that it needs the foreign key to insert into the user visit history table. However, since the PK in the users table gets generated by MySQL automatically, I'm not sure how this works or why the code isn't populating the many side.

Does the code, having a Set in the users table, and a Users object in the uservisithistory table, look correct?

Any advice/suggestions would be greatly appreciated.

Thanks.

Mike

[Mark Spritzler]

First suggestions is to move your

inverse="true"

To the other side of the relationship. So instead of in the Set of user, into the child mapping file.

Mark

[Mark Spritzler]

And I am assuming quite a bit when I read

dao.save(newUser);
transaction.commit();

Why the transaction.commit() there? Where is the creation of that transaction? It isn't shown in the code you posted, and we don't see what is in your dao.save() method.

Have you also looked at your console or logs to see any exceptions being thrown when you save? Because of the inverse, I am sure you have an exception being thrown when it tries to insert the child before the parent, which would through an constraint violation.

Mark

[Mike London]

Hi Mark,

Thanks for your reply...sorry it's taken me so long to reply to your thoughtful posting.

I hope this additional information will help you help me figure out why the many side doesn't populate.

I have key generation in MySQL set to auto-generate PKs for each table, which shouldn't be a problem since I changed the generation method (correctly, I "think") in the hibernate config files.

Please let me know if you need additional information, OK?

Thanks.

- Mike

--------------------------

My UsersDao.save() method is the following:
(auto-generated by MyEclipse)

    
  public void save(Users transientInstance)
   {
      log.debug("saving Users instance");
      try
      {
         getSession().save(transientInstance);
         log.debug("save successful");
      }
      catch (RuntimeException re)
      {
         log.error("save failed", re);
         throw re;
      }
   }
 

In the UservisithistoryDao class, here is the save method:
(auto-generated by MyEclipse)

 
   public void save(Uservisithistory transientInstance)
   {
      log.debug("saving Uservisithistory instance");
      try
      {
         getSession().save(transientInstance);
         log.debug("save successful");
      }
      catch (RuntimeException re)
      {
         log.error("save failed", re);
         throw re;
      }
   }

And, the entire example test code to get a user's data (works OK), the number of users (works OK), and to save a user (works OK) and populate the many side (*DOES NOT WORK*) with the transaction statement that you noticed was missing in my posting is:

    
 
   UsersDAO dao = new UsersDAO();
      Transaction transaction = null;
      
      Session session = dao.getSession();
      
      try
      {
 
        transaction = session.beginTransaction();         
        
         // try to find a user (this works!)
 
         Users user = dao.findById(new Integer(1));
         System.out.println("Entity retrieval successful, message is: "
               + user.getUsrFname() + " "+ user.getUsrLastlogindate());
 
        
        // use Dao to get all users
        // this works!
 
        List <Users> userList = dao.findAll();
        System.out.println(userList.size());
        
        // -----------------------  create and save a new user         
     
        Users newUser = new Users();
        newUser.setUsrAccountactive((byte) 1);
        
        newUser.setUsrAccountExpires((byte)0);
        
//        // set expiration date from one year from now       
        Calendar now = Calendar.getInstance();
        now.add(Calendar.YEAR, 1);
        Date dateToStore = now.getTime();        
        newUser.setUsrAccountExpireDate(dateToStore);
        
        // set user first name and last name
        newUser.setUsrFname("admin");
        newUser.setUsrLname("admin");
        
        // user doesn't pay.
        newUser.setUsrIsPaidUser((byte) 0);
        
        // set user login/password
        newUser.setUsrLogin("[e-mail]");
        newUser.setUsrPassword("123456");
 
// above logic to add a user to the users table (works!)
        
        // add new visit
        // this is the many side below 
   
        // *** CODE BELOW DOES NOT WORK!!!! ****
        // throws no visible error in console window
 
        Uservisithistory uvh = new Uservisithistory();        
        uvh.setUvhDateTimeOfVisit(dateToStore);
        uvh.setUvhPageFrom("home page");
        HashSet<Uservisithistory> set = new HashSet <Uservisithistory>();
        set.add(uvh);
   
         newUser.setUservisithistories(set);
        
        
        // save user
        
      dao.save(newUser);
      transaction.commit();
        
      }
      catch (HibernateException e)
      {
         System.err.println("Entity retrieval failed.");
         transaction.rollback();
         e.printStackTrace();
         
      }
      finally
      {
         try
         {
            dao.getSession().close();
         }
         catch (Exception e)
         {
            // do nothing
         }
      }
 

When I run this code, I get no error messages in the console window or even detailed SQL trace (even though I have that setting enabled).

[Mark Spritzler]

Oh, sorry I didn't look the first time, but where is your cascade option for the collection.

Mark

[Mike London]

Mark,

Pardon the "newbie" reply, but where should I put the cascade option?

Thanks.

[Mike London]

Yikes! This is complicated...

If I enter cascade="all",

like this:

<set name="uservisithistories" inverse="true" cascade="all" >
<key>
<column name="usr_pk" >
<comment>foreign key back to users table.</comment>
</column>
</key>
<one-to-many class="TestProject.Uservisithistory" />
</set>


I get this:

org.hibernate.PropertyValueException: not-null property references a null or transient value: TestProject.Uservisithistory.users
at org.hibernate.engine.Nullability.checkNullability(Nullability.java:72)
at org.hibernate.event.def.AbstractSaveEventListener.performSaveOrReplicate(AbstractSaveEventListener.java:265)
at org.hibernate.event.def.AbstractSaveEventListener.performSave(AbstractSaveEventListener.java:167)
at org.hibernate.event.def.AbstractSaveEventListener.saveWithGeneratedId(AbstractSaveEventListener.java:114)
at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.saveWithGeneratedOrRequestedId(DefaultSaveOrUpdateEventListener.java:186)
at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.entityIsTransient(DefaultSaveOrUpdateEventListener.java:175)
at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.performSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:98)
at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.onSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:70)
at org.hibernate.impl.SessionImpl.fireSaveOrUpdate(SessionImpl.java:502)
at org.hibernate.impl.SessionImpl.saveOrUpdate(SessionImpl.java:494)
at org.hibernate.engine.CascadingAction$1.cascade(CascadingAction.java:134)
at org.hibernate.engine.Cascade.cascadeToOne(Cascade.java:213)
at org.hibernate.engine.Cascade.cascadeAssociation(Cascade.java:157)
at org.hibernate.engine.Cascade.cascadeProperty(Cascade.java:108)
at org.hibernate.engine.Cascade.cascadeCollectionElements(Cascade.java:290)
at org.hibernate.engine.Cascade.cascadeCollection(Cascade.java:185)
at org.hibernate.engine.Cascade.cascadeAssociation(Cascade.java:160)
at org.hibernate.engine.Cascade.cascadeProperty(Cascade.java:108)
at org.hibernate.engine.Cascade.cascade(Cascade.java:248)
at org.hibernate.event.def.AbstractSaveEventListener.cascadeAfterSave(AbstractSaveEventListener.java:410)
at org.hibernate.event.def.AbstractSaveEventListener.performSaveOrReplicate(AbstractSaveEventListener.java:299)
at org.hibernate.event.def.AbstractSaveEventListener.performSave(AbstractSaveEventListener.java:167)
at org.hibernate.event.def.AbstractSaveEventListener.saveWithGeneratedId(AbstractSaveEventListener.java:114)
at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.saveWithGeneratedOrRequestedId(DefaultSaveOrUpdateEventListener.java:186)
at org.hibernate.event.def.DefaultSaveEventListener.saveWithGeneratedOrRequestedId(DefaultSaveEventListener.java:33)
at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.entityIsTransient(DefaultSaveOrUpdateEventListener.java:175)
at org.hibernate.event.def.DefaultSaveEventListener.performSaveOrUpdate(DefaultSaveEventListener.java:27)
at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.onSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:70)
at org.hibernate.impl.SessionImpl.fireSave(SessionImpl.java:530)
at org.hibernate.impl.SessionImpl.save(SessionImpl.java:518)
at org.hibernate.impl.SessionImpl.save(SessionImpl.java:514)
at TestProject.UsersDAO.save(UsersDAO.java:54)
at TestProject.GetUserData.main(GetUserData.java:83)

[Mike London]

OK, finally got the many side working!

Based on the error, I added the code to make sure the user object was added to the many-side object.

// add new visit
Uservisithistory uvh = new Uservisithistory();

uvh.setUsers(newUser); // ** ADDED THIS LINE **

uvh.setUvhDateTimeOfVisit(dateToStore);
uvh.setUvhPageFrom("home page");
HashSet<Uservisithistory> set = new HashSet <Uservisithistory>();
set.add(uvh);

Works fine now!

Thanks to all who replied.

mike

[Mark Spritzler]

Fantastic. Good work. You got the last part before I could even come back and reply.

Mark

[Mike London]

Thanks Mark.

Because of great people like you, JavaRanch ROCKS!!!

Thank you for all your help and great replies.



M