help please

[Lawrence Buensalida]

I keep on having an "Application Error" on my game whenever I try to run it on my phone. When I click "Details" it shows "NullPointerException". However, when I am running on my computer, it doesn't display any message like that. Why is that?

I want to post my code here but it's more than 400 lines of code.

Help me please, thanks.

[Mark Spritzler]

We had had a similar issue before. While I can't give you a direct answer because you give us very little to go on.

But sometimes the devices implement the specification in different ways, and hence one device might give you a NullPointerException, while the other won't show you that even though one exists.

Have you tried to debug it through the Wireless Toolkit and an IDE?

Also look at your code and see where you call a method on an instance of some object, and put in a check for null.

Mark

[Lawrence Buensalida]

here's my code for that. I cleaned some part of it and replaced it with comments to cut it short.

here's my code "NewGame.java"

import javax.microedition.lcdui.*;
import javax.microedition.lcdui.game.*;
import java.io.*;
import java.lang.*;
 
 
public class NewGame extends Canvas
{
    private Display display;
        
    private int gameLevel;
    public int ctr;
    public int temp;
    public int perSpace;
 
    public char keyLetter;
    
    EasyWord easyWord = new EasyWord();
    MediumWord mediumWord = new MediumWord();
    Checker checker = new Checker();
    
    private String setTheEasyWord, setTheMediumWord;
    public Graphics g;
        
    public Image image;
            
    Font font = Font.getFont(Font.FACE_PROPORTIONAL, Font.STYLE_PLAIN, Font.SIZE_SMALL);
    
    public int GbLeft, GbTop;
    public boolean pinindot;
    
    //NewGAME
    
    public NewGame(Display d)
    {
        super();
        setFullScreenMode(true);
        display = d;
        temp = 0;
        ctr = 1;
        perSpace = 1;
        pinindot = false;
    }
    
    //start
    
    void start()
    {
        display.setCurrent(this);
        repaint();
    }
    
    //paint
    
    public void paint(Graphics g)
    {
        int fontHeight = font.getHeight();      
        int fontWidth = font.stringWidth("Guess The Word");
        
        if (pinindot == true)
        {
            g.drawImage(image,1,1,0);
        }
        else
        {
            this.paintBg(g);
            this.paintGb(g);
        }
    }
    
    //keyPressed
    
    public void keyPressed(int keyCode)
    {
        if (keyCode == -8)
        {
            temp = 0;
            ctr = 1;
        }
        
        if (keyCode == -4)
        {
            if (perSpace<=4)
            {
                perSpace=perSpace+4;
            }
            else
            {
                perSpace=4;
            }
        }
        if (keyCode == 55 || keyCode == 57) 
        {
            if (temp == keyCode)
            {
                if (ctr < 4)
                {
                    ctr ++;
                }
                else
                {
                ctr = 1;
                }
            }
            else
            {
                temp = keyCode;
                ctr = 1;
            }
        }
        else
        {
            if (temp == keyCode)
            {
                if (ctr!=3)
                {
                    ctr++;
                }
                else
                {
                    ctr = 1; 
                }
            }
            else
            {
                ctr = 1;
            }
            
            temp = keyCode;
        }
        displayChar(keyCode, ctr);
        pinindot = true;
    }
 
    //displayChar
    
    public void displayChar(int keyCode, int ctr2)
    {
        switch(keyCode)
        {
            case -8: 
                keyLetter = ' '; 
                repaint(); 
                break;
            case 50: 
                switch(ctr2)
                {
                    case 1: keyLetter = 'A';
                            try
                            {
                                image = Image.createImage("/A.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint();break;
                    case 2: keyLetter = 'B'; 
                            try
                            {
                                image = Image.createImage("/B.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 3: keyLetter = 'C'; 
                            try
                            {
                                image = Image.createImage("/C.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                }
                break;
            case 51: 
                switch(ctr2)
                {
                    case 1: keyLetter = 'D'; 
                            try
                            {
                                image = Image.createImage("/D.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 2: keyLetter = 'E'; 
                            try
                            {
                                image = Image.createImage("/e.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 3: keyLetter = 'F'; 
                            try
                            {
                                image = Image.createImage("/f.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                }
                break;
            case 52: 
                switch(ctr2)
                {
                    case 1: keyLetter = 'G'; 
                            try
                            {
                                image = Image.createImage("/g.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 2: keyLetter = 'H'; 
                            try
                            {
                                image = Image.createImage("/h.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 3: keyLetter = 'I'; 
                            try
                            {
                                image = Image.createImage("/i.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                }
                break;
            case 53: 
                switch(ctr2)
                {
                    case 1: keyLetter = 'J'; 
                            try
                            {
                                image = Image.createImage("/j.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 2: keyLetter = 'K'; 
                            try
                            {
                                image = Image.createImage("/k.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 3: keyLetter = 'L'; 
                        try
                            {
                                image = Image.createImage("/l.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                }break;
            case 54: 
                switch(ctr2)
                {
                    case 1: keyLetter = 'M'; 
                            try
                            {
                                image = Image.createImage("/m.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 2: keyLetter = 'N'; 
                            try
                            {
                                image = Image.createImage("/n.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 3: keyLetter = 'O'; 
                            try
                            {
                                image = Image.createImage("/o.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                }
                break;
            case 55: 
                switch(ctr2)
                {
                    case 1: keyLetter = 'P'; 
                            try
                            {
                                image = Image.createImage("/p.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 2: keyLetter = 'Q'; 
                            try
                            {
                                image = Image.createImage("/q.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 3: keyLetter = 'R'; 
                            try
                            {
                                image = Image.createImage("/r.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 4: keyLetter = 'S'; 
                            try
                            {
                                image = Image.createImage("/s.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                }
                break;
            case 56: 
                switch(ctr2)
                {
                    case 1: keyLetter = 'T'; 
                            try
                            {
                                image = Image.createImage("/t.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 2: keyLetter = 'U'; 
                            try
                            {
                                image = Image.createImage("/u.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 3: keyLetter = 'V'; 
                            try
                            {
                                image = Image.createImage("/v.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                }
                break;
            case 57:
                switch(ctr2)
                {
                    case 1: keyLetter = 'W'; 
                            try
                            {
                                image = Image.createImage("/w.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 2: keyLetter = 'X'; 
                            try
                            {
                                image = Image.createImage("/x.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 3: keyLetter = 'Y'; 
                            try
                            {
                                image = Image.createImage("/y.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                    case 4: keyLetter = 'Z'; 
                            try
                            {
                                image = Image.createImage("/z.Png");
                            }
                            catch (IOException e)
                            {
                                System.err.println("error");
                            }
                            repaint(); break;
                }
                break;
        }
    }    
    
    //SETLEVEL
    
    public void setLevel(int Level)
    {
//I set the level of the game here, 
//and I believe it's causing any trouble.
    }
    
    
    //PAINTBACKGROUND
    
    public void paintBg(Graphics g)
    {
        g.setColor(109,182,255);  
        g.fillRect(g.getClipX(), g.getClipY(), g.getClipWidth(), g.getClipHeight()); 
        g.fillRect(0, 0, getWidth(), getHeight());
    }
    
    //PAINTGAMEBOARD
    
    public void paintGb(Graphics g)
    {
        
        int GbWidth = 108;
        int GbHeight = 96;
        int ctr1, ctr2, ctr3, ctr4, ctr5, temp;
        
        GbLeft = (getWidth()-GbWidth)/2;
        GbTop = (getHeight()-GbHeight)/2;
        
        checker.GbLeft = GbLeft;
        checker.GbTop = GbTop;
      
        //draw the left big box first
        
        g.setColor(255,182,139);
        g.fillRect(GbLeft, GbTop, 48, GbHeight);
        
        //Draw the small boxes
        temp = GbLeft;
        
        ctr2 = GbLeft;
        ctr3 = GbTop;
        //ctr5 = GbLeft+95;
        
        
        for(ctr4=1;ctr4<=8;ctr4++)
        {
            for(ctr1=1;ctr1<=4;ctr1++)
            {
                g.setColor(109,35,0);
                g.drawLine(ctr2, ctr3, ctr2+11, ctr3);
                g.drawLine(ctr2+60,ctr3, (ctr2+11)+60,ctr3);
                g.drawLine(ctr2, ctr3, ctr2, ctr3+11);
                g.drawLine(ctr2+60, ctr3, ctr2+60, ctr3+11);
                
                g.setColor(255,255,255);
                g.drawLine(ctr2, ctr3+11, ctr2+11, ctr3+11);
                g.drawLine(ctr2+60, ctr3+11, (ctr2+11)+60, ctr3+11);
                g.drawLine(ctr2+11, ctr3+11, ctr2+11, ctr3+1);
                g.drawLine((ctr2+11)+60, ctr3+11, (ctr2+11)+60, ctr3+1);
                ctr2=ctr2 + 12;
            }
            ctr2=GbLeft;
            ctr3=ctr3+12;
        }
    }
}

It's pretty long, isn't it
I'll appreciate your help very much. Thanks.
[ July 13, 2005: Message edited by: Mark Spritzler ]

[Mark Spritzler]

First, we'll put CODE tags around your code so that we can see formatting and read it.

Mark

[Mark Spritzler]

OK, some comments.

1. Why do you have a Graphics g; instance variable. It is never used, nor should it be. Only use the Graphics class that is in the paint method. I see that you pass it to other methods, which I guess is ok for your purposes.

2. The bigger one, and NOT THE source for a NullPointerException

 void start()
    {
        display.setCurrent(this); 

(edited to protect the innocent, namely me.)
Let alone that display is part of your MIDlet, and should be in that class, not in a Canvas class. You are too tightly coupling classes this way.

Mark
[ July 13, 2005: Message edited by: Mark Spritzler ]

[Mark Spritzler]

Other comments.

1. You are not following Sun's coding standards. The open curly braces are in the wrong place.

OK, I see where your assign your display variable, but still say that it shouldn't be in your Canvas class. A canvas class should just be what is displayed on the screen and nothing else. No logic for how the game is played, no MIDlet controlling stuff. Just drawing the screen.

2. OK, could paint be called before you ever assign a value to the image variable?

3. Also, why are you using an png file for each letter in the alphabet instead of drawing letters where you want them. Then you don't need all the keyCode checking stuff, sort of. Actually not sure.

Mark

[Lawrence Buensalida]

thanks for editing the presentation of my "cut & pasted" code.

For that display.setCurrent(this), I have to set the current display to show the things I have here. Actually, the current display is set to the main midlet and I transfered it here. When I remove it, it wouldn't show the game board that I have created inside this class.

[Lawrence Buensalida]

hahaha

Well, I used drawChar first. Unfortunately, the smallest font won't fit inside the box. The screen of my phone (Nokia 3220) is not enough eventhough I set it to full screen. I have to fit 1 letter inside a 1 small box.

Here's some metrics that I used before I shifted:

small font = 10x10 pixels (I assumed this)
1 letterbox = 12x12

result: the screen of my phone is not enough to display all of the boxes.
solution: I have to create images. hehehe so that I can shrink my letterbox size to 11x11 and make the letters appear 9x9.

[Lawrence Buensalida]

Here's a short description of the game board:

The game board is composed of 2 4x8 letterboxes.
width = 4 letterboxes, height = 8 letterboxes.
1 4x8 on the left and 1 on the right.
Left and Right are separated distance equal to width of 1 letterbox.

--
| | 1 letterbox = 12x12 pixels
--

**** **** * = 1 letterbox
**** **** -> this a miniature size of my gameboard
**** ****
**** ****
**** ****
**** ****
**** ****
**** ****

Note: If I'll use the metrics, this game board won't fit my screen.

[Layne Lund]

Can you please post the exact error message you get with the NullPointerException? It should include the line number that causes the exception. (At least it does in J2SE apps. I'm rather new to J2ME myself, so I don't am still figuring out these kinds of details as well.) If it gives the line number, please indicate which one it is.

Layne

[ram vikram]

Hi

try to create the images which are necessary in the constructor .

and keep the try {} catch statements . in paint and keypressed and also in constructor.

and also check to see that may be your are accesing any variables before the creation of Object instance.

[Lawrence Buensalida]

Layne,

Hi, the problem is that there are no error numbers because the error appears on my phone and not while it's being played on the pc. However, I think I already know where the problem is.

Windows didn't see it as an error because it doesn't care whether "A.PNG" is equal to "a.png", get it? But when it's already deployed to run on the phone, that makes a whole lot of difference.

I'm also new to this and thanks to people like Mark, I can pause for a while and ask someone who can make me reflect on my code.

Thanks.