need help on ExecutorService?

[Mohamad Norouzi]

Hi friends,

We have a BeanLocator class in which we look up EJBs needed. this is a utility class that uses InitialContext of the EJB

there are many classes that are not EJBs so we can't inject the EJB services into them. That is why we create a simple locator.

now I am going to increase the performance of accessing this locator. currently the methods of this locator are synchronized and it is created as a singleton.

now this is the code I am using for the better performance. since this is first time I am using ExecutorService and the concept is a bit strange for me I would like you help me if this works fine and whether this is thread safe or not.

thanks in advance

here is the code:

  
public class BeanLocators {
 
private static BeanLocators me = new BeanLocators();
BeanLocator locator = new BeanLocator();

private ExecutorService service = Executors.newCachedThreadPool(new ThreadFactory() {
public Thread newThread(Runnable r) {
return new Thread(r);
};
});


    public static <T> T get(Class<T> klass) {
Future<BeanLocator> f = me.service.submit(new Callable<BeanLocator>() {
public BeanLocator call() throws Exception {
return me.locator;
}
});


try {
return f.get().get(klass);
} catch (InterruptedException e) {
// TODO Auto-generated catch block
e.printStackTrace();
} catch (ExecutionException e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
return null;
    }
 
}  

the client classes will use as follows:

 
MyEJBNo1 ejb1 = BeanLocators.getInstance().get(MyEJBNo1.class);
 
MyEJBNo2 ejb2 = BeanLocators.getInstance().get(MyEJBNo2.class);
 

please note that we can use BeanLocator (without s) individually but because it needs to be initialized so this creation has expensive cost and we need to create it once.

[ July 22, 2008: Message edited by: mohammad norouzee ]
[ July 22, 2008: Message edited by: mohammad norouzee ]

[Mohamad Norouzi]

Any idea?

[Mohamad Norouzi]

Hi friends
I am still waiting for your comment