problem while reading from file

[gaurav chhabra]

sir i have following code


FileReader fr=new FileReader("dheeraj_chat.txt");
int ch;
StringBuffer st=new StringBuffer();
while((ch=fr.read())>0)
st=st.append((char)ch);
System.out.println("string new= "+st.toString());


this code i readingonly first line of the file .....not the rest of file...

plz tell me what to do

thank you
gaurav

[Annie Smith]

Is it necessary to read character by character? You could try using a BufferedReader.

 
BufferedReader in = new BufferedReader(new FileReader("foo.txt"));
String line = null;
StringBuffer sb = new StringBuffer();
while((line = in.readLine()) != null) {
sb.append(line);
}

[ March 31, 2005: Message edited by: Annie Smith ]

[David Harkness]

Originally posted by gaurav chhabra:

while((ch=fr.read())>0)
    st=st.append((char)ch);

While unlikely, if you have a \x00 (null character, not a literal '0' character) in your file, your loop will terminate early. You should change the loop condition to

while ( (ch=fr.read()) != -1 )

Of course, Annie's suggestion of using readLine() from BufferedReader will be easier and perform better.
[ March 31, 2005: Message edited by: David Harkness ]