nested forEach

[Vinod Awar]

Hii all,

i want to display the result of a database query .In the servlet what i did is

   
stmt = con.createStatement();
rs = stmt.executeQuery(query);
                        ResultSetMetaData rsm = rs.getMetaData();
                        int colcount=rsm.getColumnCount();
                        System.out.println("column count: "+colcount);
                        for(int i=1;i<=colcount;i++)
                        {
                             columnNames.put(""+i,rsm.getColumnName(i));
                        }
                        request.setAttribute("columnNames",columnNames);
                        java.util.ArrayList fields=new java.util.ArrayList();
                        java.util.ArrayList rows=new java.util.ArrayList();
while (rs.next()) {
fields.add(rs.getString(1));
                                fields.add(rs.getString(2));
                                fields.add(rs.getString(3));
                                fields.add(rs.getString(4));
                                fields.add(rs.getString(5));
                                rows.add(fields);
                                fields.clear();
                             }
                   request.setAttribute("rows",rows);

and in the jsp i am trying to display them like this

  
 <c:forEach var="item" items="${columnNames}">
   <c:out value="${item.value}"/>
 </c:forEach>
<br><br>Data:
  <c:forEach var="rowData" items="${rows}" varStatus="rowcount">
      <c:forEach var="cellData" items="${rowData}" varStatus="cellcount">
           ${cellData} rowcount: ${rowcount.count} cellCount: ${cellcount.count}
      </c:forEach>
  </c:forEach>

But i can only see the columnnames. is there anything wrong in my nested forEach loop code

Thanks,
Vinod

[Ben Souther]

The problem isn't in your JSP.

You're only creating one "fields" object.
Move the declaration for your 'fields' object into the loop so a new one gets created for each row and try it again.

 
 
java.util.ArrayList rows=new java.util.ArrayList();
while (rs.next()) {
 
       java.util.ArrayList fields=new java.util.ArrayList(); // <-- move to here
 
       fields.add(rs.getString(1));
       fields.add(rs.getString(2));
       fields.add(rs.getString(3));
       fields.add(rs.getString(4));
       fields.add(rs.getString(5));
       rows.add(fields);
       fields.clear();
}
 

[BPSouther: fixed cut and paste error. Thanks Saif!]
[ March 15, 2007: Message edited by: Ben Souther ]

[Muhammad Saifuddin]

Originally posted by Ben Souther:

 
 
while (rs.next()) {
fields.add(rs.getString(1)); // first Line
       java.util.ArrayList fields=new java.util.ArrayList();// second Line       fields.add(rs.getString(2));
       fields.add(rs.getString(3));
       fields.add(rs.getString(4));
       fields.add(rs.getString(5));
       rows.add(fields);
       fields.clear();
}
 

how about Swapping the second line with first line I though it becomes with more clear picture.. ;)

[Ben Souther]

Originally posted by Saif uddin:


how about Swapping the second line with first line I though it becomes with more clear picture.. ;)

Fixed. Thanks

[Vinod Awar]

Thanks Ben and saif