Array Index Out Of Bounds

Good day!
My task is to upload multiple files. I have the following codes which results to Array Index Out Of Bounds exception.

Please give me an advice on how to resolve this.

Thanks

index.jsp

<%@ page language="java" contentType="text/html; charset=ISO-8859-1"
    pageEncoding="ISO-8859-1"%>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
<title>Amkor Strip Map System</title>
</head>
<body>
<font face="Verdana" color="green">  
 
<h3 align="center">Select Strip Map Files to Upload:</h3>
 
<form method="post" action="fileUpload.jsp" name="upform" enctype="multipart/form-data">

<table width="60%" border="0" cellspacing="1" cellpadding="1" align="center" class="style1">
<tr>
<td>
<b><font color="green">File 1:</font>
</b>
</td>
</tr>
<tr>
<td align="center">
<input type="file" name="uploadfile" size="50">
</td>
</tr>
<tr>
<td>
<b><font color="green">File 2:</font>
</b>
</td>
</tr>
<tr>
<td align="center">
<input type="file" name="uploadfile" size="50">
</td>
</tr>
<tr>
<td>
<b><font color="green">File 3:</font>
</b>
</td>
</tr>
<tr>
<td align="center">
<input type="file" name="uploadfile3" size="50">
</td>
</tr>
<p>
</p>
<tr>
<td></td>
</tr>
<tr>
<td align="center">
<input type="hidden" name="todo" value="upload">
<input type="submit" name="Submit" value="Upload">
<input type="reset" name="Reset" value="Cancel">
</td>
</tr>
</table>
</form>
<p>
<a href="view.jsp"><font color="green">Punta ka dito</font></a>
<p>
<a href="index2.jsp"><font color="green">Mag-upload ng marami</font></a>
</font>
</body>
</html>

fileUpload.jsp

<%@ page import="java.io.*" %>
<%@ page import="javax.servlet.http.HttpServletRequest" %>
<%@ page import="javax.servlet.ServletInputStream" %>
<%@ page import="java.io.FileWriter" %>
<%@ page import="java.io.IOException" %>
<%@page import="java.util.Iterator" %>
<%@page import="java.util.List" %>
<%@page import="java.io.File" %>
<%@page import="org.apache.commons.fileupload.servlet.ServletFileUpload"%>
<%@page import="org.apache.commons.fileupload.disk.DiskFileItemFactory"%>
<%@page import="org.apache.commons.fileupload.*"%>
<%
String savePath = "", filepath = "", filename = "";
String contentType = "", fileData = "", strLocalFileName = "";
int startPos = 0;
int endPos = 0;

%>
<%!
//copy specified number of bytes from main data buffer to temp data buffer
void copyByte(byte [] fromBytes, byte [] toBytes, int start, int len)
{
for(int i=start;i<(start+len);i++)
{
toBytes[i - start] = fromBytes[i];
}
}
 %>
 
<%//DITO AKO MAGEEDIT

boolean isMultipart = ServletFileUpload.isMultipartContent(request);
 if (!isMultipart) 
 {
 } 
 else 
 {
   FileItemFactory factory = new DiskFileItemFactory();
   ServletFileUpload upload = new ServletFileUpload(factory);
   List items = null;
   try 
   {
   items = upload.parseRequest(request);
   } 
   catch (FileUploadException e) 
   {
   e.printStackTrace();
   }
   
   Iterator itr = items.iterator();
   while (itr.hasNext()) 
   {

int BOF = 0, EOF = 0;
contentType = request.getContentType();
out.println("<br>Content type is :: " +contentType);
if ((contentType != null) && (contentType.indexOf("multipart/form-data") >= 0)) 
{
DataInputStream in = new DataInputStream(request.getInputStream());
DataInputStream in1 = in;
int formDataLength = request.getContentLength();
byte dataBytes[] = new byte[formDataLength];
int byteRead = 0;
int totalBytesRead = 0;
while (totalBytesRead < formDataLength)
{
byteRead = in1.read(dataBytes, totalBytesRead, formDataLength);
totalBytesRead += byteRead;
}
out.println("<br>totalBytesRead : " + totalBytesRead + "    :   formDataLength = " + formDataLength);

//String file = new String(dataBytes); 
//out.println("<br>File Contents:<br>////////////////////////////////////<br>" + file + "<br>////////////////////////////////<br>");
 
byte[] line = new byte[128];
if (totalBytesRead < 3)
{
  return;//exit if file length is not sufficiently large
}
 
String boundary = "";
String s = "";
int count = 0;
int pos = 0;

//loop for extracting boundary of file
//could also be extracted from request.getContentType()
do
{
copyByte(dataBytes, line, count ,1);//read 1 byte at a time
count+=1;
s = new String(line, 0, 1);
fileData = fileData + s;
pos = fileData.indexOf("Content-Disposition: form-data; name=\""); //set the file name
if(pos != -1)
endPos = pos;
}
while(pos == -1);
boundary = fileData.substring(startPos, endPos);
 
//loop for extracting filename
startPos = endPos;
do
{
copyByte(dataBytes, line, count ,1);//read 1 byte at a time
count+=1;
s = new String(line, 0, 1);
fileData = fileData + s;
pos = fileData.indexOf("filename=\"", startPos); //set the file name
if(pos != -1)
startPos = pos;
}
while(pos == -1);
do
{
copyByte(dataBytes, line, count ,1);//read 1 byte at a time
count+=1;
s = new String(line, 0, 1);
fileData = fileData + s;
pos = fileData.indexOf("Content-Type: ", startPos);
if(pos != -1)
endPos = pos;
}
while(pos == -1);
filename = fileData.substring(startPos + 10, endPos - 3);//to eliminate " from start & end
strLocalFileName = filename;
int index = filename.lastIndexOf("\\");
if(index != -1)
filename = filename.substring(index + 1);
else
filename = filename;

//loop for extracting ContentType
boolean blnNewlnFlag = false;
startPos = endPos;//added length of "Content-Type: "
do
{
copyByte(dataBytes, line, count ,1);//read 1 byte at a time
count+=1;
s = new String(line, 0, 1);
fileData = fileData + s;
pos = fileData.indexOf("\n", startPos);
if(pos != -1)
{
if(blnNewlnFlag == true)
endPos = pos;
else
{
blnNewlnFlag = true;
pos = -1;
}
}
}
while(pos == -1);
contentType = fileData.substring(startPos + 14, endPos);

//loop for extracting actual file data
startPos = count + 1;
do
{
copyByte(dataBytes, line, count ,1);//read 1 byte at a time
count+=1;
s = new String(line, 0, 1);
fileData = fileData + s;
pos = fileData.indexOf(boundary, startPos);//check for end of file data i.e boundry value
}

while(pos == -1);
endPos = count - boundary.length();
//file data extracted
 
out.println("<br><br>0. Local File Name = " + strLocalFileName);
out.println("<br><br>1. filename = " + filename);
out.println("<br>2. contentType = " + contentType);
out.println("<br>3. startPos = " + startPos);
out.println("<br>4. endPos = " + endPos);
out.println("<br>5. boundary = " + boundary);
 
//create destination path & save file there
String appPath = application.getRealPath("/");
out.println("<br>appPath : " + appPath);
String destFolder = appPath + "text/ ";
filename= destFolder + filename;
FileOutputStream fileOut = new FileOutputStream(filename);
fileOut.write(dataBytes, startPos, (endPos - startPos));
fileOut.flush();
fileOut.close();
out.println("<br>File saved as >> " + filename);
//file saved at destination
//out.println("<br>File data : <br><br>**************************<br>" + (new String(dataBytes,startPos, (endPos - startPos))) + "<br><br>**************************");
}// end of IF 
else
{
out.println("Error in uploading ");
}
}//END OF while Loop
}//END OF else (outermost)

%>

ERROR:

HTTP Status 500 -

--------------------------------------------------------------------------------

type Exception report

message

description The server encountered an internal error () that prevented it from fulfilling this request.

exception

org.apache.jasper.JasperException: Exception in JSP: /fileUpload.jsp:25

22: {
23: for(int i=start;i<(start+len);i++)
24: {
25: toBytes[i - start] = fromBytes[i];
26: }
27: }
28: %>

Stacktrace:
org.apache.jasper.servlet.JspServletWrapper.handleJspException(JspServletWrapper.java:467)
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:389)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265)
javax.servlet.http.HttpServlet.service(HttpServlet.java:803)

root cause

java.lang.ArrayIndexOutOfBoundsException: 14051
org.apache.jsp.fileUpload_jsp.copyByte(fileUpload_jsp.java:27)
org.apache.jsp.fileUpload_jsp._jspService(fileUpload_jsp.java:147)
org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98)
javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:328)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265)
javax.servlet.http.HttpServlet.service(HttpServlet.java:803)

You have to allocate the necessary size before copying the data into this array. You should not give it a fix size.

how can I do that?

Oh I see my fault. I'll try in now. Thanks so much for your reply.

Mr. Verre,

I have changed the code

to:

but still, it isn't working. I can't make the array length not fixed.
Please give me some advice.

Thanks.

Dada

Hi,
Why have you given the same name "uploadfile" for two different <input type= "file"....> in your html?

<input type="file" name="uploadfile" size="50">
<input type="file" name="uploadfile" size="50">
<input type="file" name="uploadfile3" size="50">

prakash,
yes, I thought the same here

Hello,

Thanks for your replies.

Earlier, I have already changed that to:

<%@ page language="java" contentType="text/html; charset=ISO-8859-1"
    pageEncoding="ISO-8859-1"%>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
<title>Amkor Strip Map System</title>
</head>
<body>
<font face="Verdana" color="green">  
 
<h3 align="center">Select Strip Map Files to Upload:</h3>
 
<form method="post" action="fileUpload.jsp" name="upform" enctype="multipart/form-data">

<table width="60%" border="0" cellspacing="1" cellpadding="1" align="center" class="style1">
<tr>
<td>
<b><font color="green">File 1:</font>
</b>
</td>
</tr>
<tr>
<td align="center">
<input type="file" name="uploadfile1" size="50">
</td>
</tr>
<tr>
<td>
<b><font color="green">File 2:</font>
</b>
</td>
</tr>
<tr>
<td align="center">
<input type="file" name="uploadfile2" size="50">
</td>
</tr>
<tr>
<td>
<b><font color="green">File 3:</font>
</b>
</td>
</tr>
<tr>
<td align="center">
<input type="file" name="uploadfile3" size="50">
</td>
</tr>
<p>
</p>
<tr>
<td></td>
</tr>
<tr>
<td align="center">
<input type="hidden" name="todo" value="upload">
<input type="submit" name="Submit" value="Upload">
<input type="reset" name="Reset" value="Cancel">
</td>
</tr>
</table>
</form>
<p>
<a href="view.jsp"><font color="green">Punta ka dito</font></a>
<p>
<a href="index2.jsp"><font color="green">Mag-upload ng marami</font></a>
</font>
</body>
</html>

But it still gives me the same error which is:

exception

org.apache.jasper.JasperException: 2235
org.apache.jasper.servlet.JspServletWrapper.handleJspException(JspServletWrapper.java:476)
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:389)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265)
javax.servlet.http.HttpServlet.service(HttpServlet.java:803)

root cause

java.lang.ArrayIndexOutOfBoundsException: 2235
org.apache.jsp.fileUpload_jsp.copyByte(fileUpload_jsp.java:27)
org.apache.jsp.fileUpload_jsp._jspService(fileUpload_jsp.java:152)
org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98)
javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:328)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265)
javax.servlet.http.HttpServlet.service(HttpServlet.java:803)

No, that's not what I meant. You need to know the actual size needed. You are copying bytes into an array, so you need to calculate how many bytes you will insert in the array.

Oh, okay.

I have changed that to:

I used 4096 because the size of the 2 text files that I am uploading is 1KB each.

Still, I am getting the same error.