problem insert with DB2

[Laurent S]

I have this insert procedure

public void insert (NodeInfo ni,DefaultMutableTreeNode parent)
{
DefaultMutableTreeNode newNode = new DefaultMutableTreeNode(ni);
model.insertNodeInto(newNode,parent,parent.getChildCount());
TreeNode[] nodes = model.getPathToRoot(newNode);
TreePath path = new TreePath(nodes);
tree.scrollPathToVisible(path);
tree.setSelectionPath(path);

try
{
String query = "SELECT * FROM CompanyItem";
   ResultSet rs = stmt.executeQuery(query);
   rs.moveToInsertRow();
  rs.updateInt("idItem",ni.getId());
  rs.updateString("type",ni.getType());
  rs.updateString("info",ni.getInfo());
  rs.insertRow();
  rs.close();
query = "SELECT * FROM Hierarchy";
rs = stmt.executeQuery(query);   
   rs.moveToInsertRow();
  rs.updateInt("idChild",ni.getId());
  rs.updateInt("idParent",((NodeInfo)parent.getUserObject()).getId());
  rs.insertRow();  
  rs.close();
}
catch (SQLException e)
{
System.err.println("SQLException: "+e);
}
}

and at the instruction: rs.moveToInsertRow(); i have a error:
Exception occurred during event dispatching:
java.lang.AbstractMethodError
at TreeFrame.insert(TreeEdit.java:308)
at TreeFrame.actionPerformed(TreeEdit.java:350)
at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1450)
at javax.swing.AbstractButton$ForwardActionEvents.actionPerformed(AbstractButton.java:1504)
at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:378)
at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:250)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:216)
at java.awt.Component.processMouseEvent(Component.java:3717)
someone can help me?
[This message has been edited by Laurent S (edited September 27, 2001).]

[Jamie Robertson]

why go through all that trouble and code for an insert? It is faster and more efficient in this case to use traditional SQL:

public void insert (NodeInfo ni,DefaultMutableTreeNode parent){
DefaultMutableTreeNode newNode = new DefaultMutableTreeNode(ni);
model.insertNodeInto(newNode,parent,parent.getChildCount());
TreeNode[] nodes = model.getPathToRoot(newNode);
TreePath path = new TreePath(nodes);
tree.scrollPathToVisible(path);
tree.setSelectionPath(path);
try
{
String query = "INSERT INTO CompanyItem "+
"VALUES("+ni.getID()+", '"+ ni.getType()+
"', '"+ni.getInfo()+"')";
   stmt.executeUpdate(query);   

query = "INSERT INTO Hierarchy "+
"VALUES("+ni.getId())+","+ ((NodeInfo)parent.getUserObject()).getId()+")";
   stmt.executeUpdate(query);   
}
catch (SQLException e)
{
System.err.println("SQLException: "+e);
}
}

Is there any reason you need the programmatic Insert? even better than my above suggestion is to use PreparedStatement instead of Statement.
Jamie

[Jamie Robertson]

as to the original error message: You are using a driver that does not support programmatic updates. What jdk version are you using (ie 1.3.1) and which driver/database...my guess is Access and jdbc dbc bridge? anyways check your driver documentation to see if it supports programmatic updates.(you also may have to update your database odbc driver-->MDAC I believe)
Jamie

[Laurent S]

With the standard way for a insert, you can't insert a string with quote in it...

[Jamie Robertson]

Originally posted by Laurent S:
With the standard way for a insert, you can't insert a string with quote in it...

This is the reason I suggested PreparedStatement! It is great because it deals with all the special characters so us programmers do not!

String query = "INSERT INTO CompanyItem "+
"VALUES(?,?,?)";
PreparedStatement ps=con.prepareStatement(query);   
ps.setInt(1,ni.getID());
ps.setString(2,ni.getType());
ps.setString(3,ni.getInfo());
ps.executeUpdate();
query = "INSERT INTO Hierarchy VALUES (?,?)";
ps=con.prepareStatement(query);
  ps.setInt(1, ni.getId());
ps.setInt(((NodeInfo)parent.getUserObject()).getId());
ps.executeUpdate();

Any ',",%,*, etc special characters should be taken care of if you jdbc driver is correctly implemented. Give it a try,
Jamie

[Laurent S]

Thanx a lot Jamie.
In fact i haven't read your advice before about PreparedStatement. Now it's working with that
For my first question, my driver doesn't support the updatable set function.