help in sql

[Mary Wallace]

I have a sql statement like this

  String qry = "select pin,emp_acct_no,attn_name,address_line1,address_line2,po_box_no,city,state,zip,country_code,email" +
"FROM w_employer WHERE pin='"  + pinnum + " 'AND emp_acct_no="+checkaccountNumber;
System.out.println(qry);
stmt=con.createStatement(); 

pin and account number is not passing the values. system .out print is showing this select pin,emp_acct_no,attn_name,address_line1,address_line2,po_box_no,city,state,zip,country_code,emailFROM w_employer WHERE pin= 'pinum' and emp_acct_no=checkaccountNumber
DB Connection Error(validate accountnumer): java.sql.SQLException: ORA-00923: FROM keyword not found where expected
what Im doing wrong here?

[Joe Ess]

String qry = "select pin,emp_acct_no,attn_name,address_line1,address_line2,po_box_no,city,state,zip,country_code,email" +
"FROM w_employer WHERE pin='" + pinnum + " 'AND emp_acct_no="+checkaccountNumber;

There's no space between "country_code,email" and "FROM". They get concatenated and the SQL compiler can't find the FROM keyword.

[Mary Wallace]

I changed like this and it worked

   String qry = "select pin,emp_acct_no,attn_name,address_line1,address_line2,po_box_no,city,state,zip,country_code,email" + 
      " FROM w_employer WHERE pin='"+pinnum+"'AND emp_acct_no="+ checkaccountNumber; 

i want to change that as a prepared statement like this:

  PreparedStatement findemp = con.prepareStatement
   ("select pin,emp_acct_no,attn_name,address_line1,address_line2,po_box_no,city,state,zip,country_code,email" +
   "FROM w_employer WHERE pin=? and emp_acct_no=?");
   findemp.setString(1,pin);
   findemp.setInt(2,checkaccountNumber);
rs=findemp.executeQuery(); 

but it gave me an error "DB Connection Error(validate pin frm db): java.sql.SQLException: ORA-00923: FROM keyword not found where expected"
what i have to do here?
thanks in advance

[Bear Bibeault]

Did you read Joe's response?

[Mary Wallace]

The problem was not bcoz of the space as Joe suggested.When i rewrote the sql it worked.

[Joe Ess]

Your String query has a space before FROM but the String literal in your prepared statement doesn't have the space. Attention to detail!

[Mary Wallace]

thanks