• Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

Something wrong in returning ResultSet

 
Gorakshanath Pandey
Greenhorn
Posts: 11
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
static ResultSet Query(String sql,Connection conn) throws Exception
{
Statement stmt = conn.createStatement();
ResultSet temprs;
temprs=stmt.executeQuery(sql);
return temprs;
}

Whats wrong while return ResultSet from a function.?
 
Blake Minghelli
Ranch Hand
Posts: 331
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Can you describe the error you are getting? I'm assuming you are getting some kind of an SQLException, but we'll need to know in order to diagnose the problem.
 
Wayne L Johnson
Ranch Hand
Posts: 399
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
The biggest problem is that it becomes very difficult to clean up your resources. There are two separate issues.
First, you have to make sure that every place where this method is called, once the ResultSet is fully processed, that "close()" is called. If you are writing all of the code that access this method, then you have control over that. If you allow other people access to this method, you have to hope that they call "close()", but you have no direct control over it.
Second, even if you manage to call "close()" on every ResultSet that gets returned, how do you close the Statement (stmt)? Your "stmt" variable goes out of scope once the method returns, and so Java can do a little garbage collecting since there are no references to it, but there is no way you can call "close()" on it. So the database can/may/will have resources tied up that are never freed.
So it's a bad idea to do this.
 
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic