aspose file tools*
The moose likes JDBC and the fly likes Setting autoCommit Value Big Moose Saloon
  Search | Java FAQ | Recent Topics | Flagged Topics | Hot Topics | Zero Replies
Register / Login
JavaRanch » Java Forums » Databases » JDBC
Bookmark "Setting autoCommit Value" Watch "Setting autoCommit Value" New topic
Author

Setting autoCommit Value

PNS Subramanian
Ranch Hand

Joined: Jul 13, 2004
Posts: 150
if(!conn.getAutoCommit())
conn.setAutoCommit(true);
if(conn != null && !conn.isClosed())
conn.close();

Do we need to explcitly set autocommit to true before closing the connection ? Considering that the connection object is going to be released to the pool, would not having the statement
conn.setAutoCommit(true);
have any undesirable effect ?
Adeel Ansari
Ranch Hand

Joined: Aug 15, 2004
Posts: 2874

if(!conn.getAutoCommit())
conn.setAutoCommit(true);
if(conn != null && !conn.isClosed())
conn.close();


why do you want to set the autocommit to true, though after settin it you are just closing the connection object nothin else.

other thing is, just have a look after accessing the conn object you are checking whether it is null or not. isn't it wiered.

auto commit is ture by default.
Julian Kennedy
Ranch Hand

Joined: Aug 02, 2004
Posts: 823
I guess that's a good question.

By default you would assume that AutoCommit was on. I assume that you set it to false earlier in your code to perform a transaction. So, assuming that conn.close() in this case just returns the connection to the pool, rather than actually closing it, if you didn't setAutoCommit(true) it would still be false.

The real question is, what does Pool.getConnection() do? Does it reinitialise the connection before allocating to you or does it just give it to you as it is? Well, obviously good pool code would guarantee the connection in a consistent state, and I think it's fair to assume that. Check the documentation for your peace of mind.

Jules
shang qiao
Greenhorn

Joined: Aug 31, 2004
Posts: 1
yes,I guess that's a good question,too.but i think the answer to the question depend on the implements of the ConnectionPoolDataSource,maybe.
 
I agree. Here's the link: http://aspose.com/file-tools
 
subject: Setting autoCommit Value