Out of Sync error

[Reggie McDougal]

Hi there wondering if some one can help

I am having probs with the following code

I have a HashMap storing data which I retrieve and want to write to the database, but the code executes OK but does not write to the DB. and debug tells me that the method addRecord is (out of sync)

Can some one give me a hand with this.

  
public class ProcessData extends HttpServlet {

public void addRecord(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
HttpSession session = request.getSession();
System.out.println( "request Session" );
        FormData data = (FormData)session.getAttribute("allData");
 
    System.out.println( "get object from session" );
    // SET Database Vars
String driver = "oracle.jdbc.driver.OracleDriver";
String url = "jdbc :-o	 racle:thin:@HOST:1521 :mrgreen: WEB";
String username = "";
String password = "";
      // Set the values
String title = data.getDataElement("title");
String first_name = data.getDataElement("first_name");
String last_name = data.getDataElement("last_name");
System.out.println( "assign values" );

       //  get connection and set-up and execuet prepared statement
    Connection conn = null;
    PreparedStatement ps = null;
try {
    System.out.println( "enter try block" );
    Class.forName(driver);
    conn = DriverManager.getConnection(url, username, password);
    System.out.println(conn );
    System.out.println( "get connection" );
String sql = "UPDATE prepaidactivate SET title=?,first_name=?,last_name=?";
      System.out.println( "set sql" );
      ps = conn.prepareStatement(sql);
      ps.setString(1,title);
      ps.setString(2,first_name);
      ps.setString(3,last_name);
      ps.executeUpdate();
      System.out.println( "execute update" );
    }
    catch(Exception e) {
      System.out.println("Error:" + e );
      e.printStackTrace();
    }
    finally {
      handleCleanup(conn,ps,null);
      System.out.println( "finally, cleanup" );
    }
//session.removeAttribute("allData");
//String sendTo = "/Activate?process=thanks";
//RequestDispatcher dispatch = request.getRequestDispatcher(sendTo);
System.out.println("doPost: Go to thanks page");
//dispatch.forward(request, response);
  }  
  
  private void handleCleanup(Connection conn,PreparedStatement ps,ResultSet rs)
  {
  // make sure the connection is returned to the connection pool
  try { 
  if(rs!=null)
  rs.close();
  if(ps!=null)
  ps.close(); 
  if(conn!=null)
  conn.close();
  } catch(SQLException e) {
   System.out.println(e);
  }
  }
 
  
    public void doGet(HttpServletRequest request, HttpServletResponse response) 
throws ServletException, IOException
{
addRecord(request, response); 
}
 
public void doPost(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException
{
addRecord(request, response); 
}
}
 

[David O'Meara]

"Private Parts",
Welcome to the JavaRanch! We're pretty light on rules round these parts, but one rule we take quite seriously is the one on display names. You can read the full version here.

Basically we require your display name to be two words: your first name, a space, then your last name. Obviously fictitious names are not allowed..

Please edit your profile and select a display name which matches the display name rules. PLease do it soon, since accounts with invalid display names get deleted, often without warning.

thanks,
Dave.

[David O'Meara]

Are you sure an exception is not being thrown and you're missing it? Depending on the servlet container you'e using, System.out's may not be retained. That is, they get discarded and not displayed or saved anywhere. Better to look into a logging framework like Log4J.

You're not really handling the exceptions, so it may be better to propagate them ie throw them out of the method. Other than that the code looks fine, but I didn't look too closely.