Having trouble with executeBatch

[Reggie McDougal]

For some reason execute batch will not update the database, now I have tried testing the batch with a ps.setString (1, "testData") and still no cigar, it looks right to me I just can't see why the database is not updating.

error is an ArrayList by the way.

  
 
conn = ds.getConnection();
// perpare our update statement
String sql = "UPDATE ISVALIDNUMBER SET STATUS = 'ERROR' WHERE mobile_phone_number = ?"; 
ps = conn.prepareStatement(sql); 

      try {      
      for(int i = 0; i < error.size(); i++) {
      String aErr = (String) error.get(i);
   
      ps.setString (1, aErr);
      ps.addBatch();
      }
      ps.executeBatch();
      conn.commit();
      logger.debug("Execute Batch:");
  } catch(SQLException e) {
  e.printStackTrace();
  } finally {
  ps.close();
  conn.close();
  logger.debug("Conn Close");

[Nathaniel Stoddard]

I believe setString wants a 0-indexed number as its parameter. So, you should be giving it a 0 instead of 1 -- unless I'm misunderstanding something here ....

[Fisher Daniel]

Hi Reggie,
I think you should add this after you get database connection..

  
conn.setAutoCommit(false);
 
... (the rest of your code)

And Nathaniel, according to JDBC Specification, the setting parameter always start with 1 instead of 0-index.

Correct me if I am wrong...
Hope this help
daniel

[Jeanne Boyarsky]

Daniel is correct. JDBC uses indexes starting with 1.