aspose file tools*
The moose likes JDBC and the fly likes escaping single quotes Big Moose Saloon
  Search | Java FAQ | Recent Topics | Flagged Topics | Hot Topics | Zero Replies
Register / Login
JavaRanch » Java Forums » Databases » JDBC
Bookmark "escaping single quotes" Watch "escaping single quotes" New topic
Author

escaping single quotes

Stephen Huey
Ranch Hand

Joined: Jul 15, 2003
Posts: 618
I didn't write the original database access/pooling code for this web app, and right now we've got an issue with single quotes in data not being escaped properly. I've read that PreparedStatement takes care of this for you, but I've only started using it for a few CLOB/BLOB inserts, etc. Right now, the majority of our updates run through the following method, and this method gets called 45 times in our code:



It seems like a quick and dirty but decent short-term solution could be to just change this to use a PreparedStatement (without any parameters). I don't have much time at the moment, and we just need something that will work without introducing other issues. While I'm at it, should I also change the following method that is used for the majority of our reads (SELECTs) out of the database?





Thanks for the advice...
David Harkness
Ranch Hand

Joined: Aug 07, 2003
Posts: 1646
Originally posted by Stephen Huey:
It seems like a quick and dirty but decent short-term solution could be to just change this to use a PreparedStatement (without any parameters).
This will have zero effect, since it's the parameters that have their quotes (and other special characters) escaped. Unfortunately, you can't just apply the munging to the whole query -- you need to apply it to the parameters individually.

The simplest solution, still using your code above, would be to create a utility method to do the munging and call it from all the places where you call the code above while building the query. This will likely be "good enough" until you can take the time to switch to using prepared statements.
Stephen Huey
Ranch Hand

Joined: Jul 15, 2003
Posts: 618
I appreciate the help!
 
With a little knowledge, a cast iron skillet is non-stick and lasts a lifetime.
 
subject: escaping single quotes