Two Laptop Bag*
The moose likes JDBC and the fly likes Bind Variable? Big Moose Saloon
  Search | Java FAQ | Recent Topics | Flagged Topics | Hot Topics | Zero Replies
Register / Login


Win a copy of Android Security Essentials Live Lessons this week in the Android forum!
JavaRanch » Java Forums » Databases » JDBC
Bookmark "Bind Variable?" Watch "Bind Variable?" New topic
Author

Bind Variable?

Gemini Moses
Ranch Hand

Joined: Jan 04, 2001
Posts: 245
I need help in making the JDBC call in my code more efficient.

I have written XML parser to parse XML file to create appropriate Insert statment from the file.

In method endElement in testcalss I am making call to class InsertData.

Please see below for the code of InsertData.

Can someone help me to make this code efficient. I need to run each insert statement seperately so that even if one of the Insert fails the program continues.
Is use of PrepareStatment OK or do I need to change this? If and how can I use Bind Variables here?

The program runs fine for smaller files but when the file size is huge (9MB ) the program is too slow or fails with memory issues.







Thanks!
Gemini

[ May 23, 2005: Message edited by: Gemini Moses ]

[edited by Jeanne to add code tags]
[ May 23, 2005: Message edited by: Jeanne Boyarsky ]
Jeanne Boyarsky
internet detective
Marshal

Joined: May 26, 2003
Posts: 30130
    
150

Gemini,
You should definitely use a PreparedStatement. Sun's tutorial on this is excellent.

Try inserting some println statements in the code to see what part is taking the most time. Is it the JDBC, XML, etc. (Either way you should use a PreparedStatement though.)


[Blog] [JavaRanch FAQ] [How To Ask Questions The Smart Way] [Book Promos]
Blogging on Certs: SCEA Part 1, Part 2 & 3, Core Spring 3, OCAJP, OCPJP beta, TOGAF part 1 and part 2
Avi Abrami
Ranch Hand

Joined: Oct 11, 2000
Posts: 1121

Gemini,
Use a profiler. See the following Web site for more information on profiling java applications:

http://www.javaperformancetuning.com

Good Luck,
Avi.
 
 
subject: Bind Variable?
 
Similar Threads
problems with JAXP
How can I convert the xml to a string?
SAX and characters() -method
problems with JAXP
Removing newline character from XML input file to SAX parser