insert into method

[Kingsley Mullers]

Hi there, i've written the following method to pass values and insert them into a database, it doesn't seem to work, can't see where i've gone wrong..thanks

public String insertcomplainantDetails (Connection cn, String Companyname,
String Complainantsurname,String Complainantname, String Complainantdepartment,
 String Complainantlocation, String Complainantaddress, long Complainantidnum,
 long Complainantoraclenum,long ComplainantTelnum ,Date ComplainantDate) 
 {
      PreparedStatement pstmt=null;
      DBconn=cn;
      String insertSQL;
      int rows=0;
      StringBuffer strBuff = new StringBuffer();
      
     try {
      
       insertSQL ="insert into complainant ( "
              +"complainantid,"
              +"companyname,"
              +"complainantsurname,"
              +"complainantname, "
              +"complainantdepartment, "
              +"complainantlocation, "
              +"complainantaddress,"
              +"complainantIDnum,"
              +"complainantoraclenum,"
              +"complainantTelnum,"
              +"ComplainantDate) "
     
              + "values (ref_num_seq.nextval,?,?,?,?,?,?,?,?,?,to_date(sysdate,'yyyy-mm-dd') ";
 
     try {  
               pstmt = DBconn.prepareStatement(insertSQL);
      
                //set the values
             
                pstmt.setString(1,"");
                pstmt.setString(2,"");
                pstmt.setString(3,"");
                pstmt.setString(4,"");
                pstmt.setString(5,"");
                pstmt.setString(6,"");
                pstmt.setLong(7,Complainantidnum);
                pstmt.setLong(8,Complainantoraclenum);
                pstmt.setLong(9,ComplainantTelnum);
                pstmt.setDate(10,ComplainantDate);
     
                //insert the rows
                rows=pstmt.executeUpdate();
                if(rows==0)
                {
                  DBconn.rollback();
                 }else{
                  DBconn.commit();
                 }
                // close the pstmt
                pstmt.close();
     
      } catch (SQLException e )  {
          
      } 
    
      } catch(Exception excep) {
         
      } finally {
         pstmt=null;
         insertSQL=null;
         rs=null;
      }
        return null; // not sure what to put in here,whether it returns insertComplainantDetails
 }  

many thanks

[edited to add code tags]
[ August 24, 2005: Message edited by: Jeanne Boyarsky ]

[David Ulicny]

Do you have any exception?

What is this?

DBconn=cn;

[Kingsley Mullers]

DBconn is connection,

error: return type incorrect...
What i'm confused about... is it supposed to return insertcomplainantDetails or should the return type be null?

[vikassheel gupta]

hi
try this
public void mehtod name
and remove the return null;
this statement because i think insert statement will not return any thing thats why this problem occurs
fine