Proper place to initiate DB Pooling

[Dilip kumar]

Hi All,

I'm creating the DB connection pool in the init(). Is this the proper way ? Thanks

Main.java (servlet)

public void init() throws ServletException {
utilClass = new Common();
super.init();
}

Common.java

public Common() {
DB = new DBBean();
}

DBBean.java (implements Serializable)

private static DBBroker broker = null;
 
protected Connection getConnection() throws Exception {
     if(broker == null) {
        broker = DBBroker.getHandle();   
     }
     return broker.getConnection();
}

DBBroker.java

private DBBroker() {
init();
}
 
private void init() {
   logger = Logger.getLogger(this.getClass().getName());
    try {
       InitialContext ctx = new InitialContext();
       ds = (DataSource) ctx.lookup("java:/testDS");        
    } catch(Exception e) {
        logger.error(e);
    }
}
 
public static synchronized DBBroker getHandle() {
    if(broker == null) {
       broker = new DBBroker();
    }
    return broker;
}
 
public synchronized Connection getConnection() throws Exception {
     return ds.getConnection();
}