whts wrong in this statement?

[Keshini Weerasuriya]

Hi.. I'm trying to save changes and update the record. But this doesn't seem to work. Can anyone help?

st.executeUpdate("UPDATE Client " +
"SET (CliId = '"+id+"', Surname = '"+surname+"', FirstName = '"+firstname+"', Title = '"+Gen+"',NICNo = '"+NIC+"' , Image = '"+image+"',Address = '"+Address+"', TelNo = '"+no+"',Email = '"+mail+"')");

[Shailesh Chandra]

Is there any exception ?

Are you issuing a commit, after your update operation.

Just a suggestion, use PreparedStatement.

Shailesh

[Martin Simons]

Well, for one, you don't need parens around the set fields, also a couple
of your field names have "No" in the name, which I assume means number.
You are adding these fields as if they are strings, so check that those
fields are actually character and not number types in the database, and
last, but definately not least, there is no where clause in this update
statement. Do you really wish to update every row in the table with this
information or did you want to only update a specific row?

[Keshini Weerasuriya]

No exceptions.. But the new data doesn't get updated

[Shailesh Chandra]

put the complete method

Shailesh

[Keshini Weerasuriya]

I changed the statement to

String query = "UPDATE Client SET (CliId = '"+id+"', Surname = '"+surname+"', FirstName = '"+firstname+"', Title = '"+Gen+"',NICNo = '"+NIC+"' , Image = '"+image+"',Address = '"+Address+"', TelNo = '"+no+"',Email = '"+mail+"') WHERE CliId = '" +id+ "'";

st.executeUpdate(query);

Now it says
java.sql.SQLException: ORA-00907: missing right parenthesis

[Martin Simons]

I would say remove the parens around the set fields.

[Keshini Weerasuriya]

Thanks Martin.. That worked.. :-)