Transaction Management

[graham king]

Would this be the proper way to handle a self governing transaction?

Or should the (!rs.next()) throw ex; be within the try catch as well?

public void createUser(User user)throws SQLException, NamingException, CreateException{
logger.info("entering createUser");
Connection con = null;
PreparedStatement ps = null;
ResultSet rs = null;
 
try{
con = MSSQLServerDAOFactory.createConnection(AppHelper.SC_SECURITY_DS);

ps = con.prepareStatement("DECLARE @userId int " +
"INSERT INTO users(username, password)VALUES(?,?) " +
"SELECT @@IDENTITY as userId");
int count = 1;
ps.setString(count++,user.getUserName());
ps.setString(count++,user.getPassword());

            int userId = 0;                 
            try {
            con.setAutoCommit(false);
rs = ps.executeQuery();
con.commit();
} catch (SQLException e) {
con.rollback();
throw e;
}
            if(!rs.next()){
            throw new CreateException("Unable to create user!");
            }
            
            userId = rs.getInt(1);
            user.setUserId(userId);
}finally{
AppHelper.closeResultSet(rs);
AppHelper.closeStatement(ps);
AppHelper.releaseConnection(con);
}
logger.info("leaving createUser");
}

Thanks.