Win a copy of Design for the Mind this week in the Design forum!
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

Closing ResultSet questions

 
john mattucci
Ranch Hand
Posts: 331
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I have the following 2 bits of code. Currently I close rs only in finally in addition to all ps and connection. Thank you for your time.

1/


2/

 
Tim LeMaster
Ranch Hand
Posts: 226
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
In my opinion

code 1: Yes you should close the result set before assigning a new ResultSet object to the rs variable.

code 2: Yep same as above. Except in the case I would close the statement also. But I would change it to make sure your prepared statement can be cached. see below.

Of course according to the specs if you close a statement its result set will also be closed so if you are closing your statement in finally this probably isn't much of a problem. But I feel its always best to call close() explicitly on all JDBC objects.

I'd rewrite case 2 to be more like

[ December 06, 2006: Message edited by: Tim LeMaster ]
 
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic