simple error

[Gopi Krrishna]

Given is the simple code to add ip address in the table named ip_table
which it creates..
but i am unable to successfully add the data into the table..
i am getting the error as
"too few parameters. expected 1"

please help

 
import javax.servlet.http.*;
import javax.servlet.*;
import java.util.*;
import java.net.*;
import java.io.*;
import java.sql.*;
 
public class AddIP extends HttpServlet
{
PrintWriter out=null;
String address="120.120.120.120"
public void doPost(HttpServletRequest req,HttpServletResponse res) throws IOException
{
res.setContentType("text/html");
out=res.getWriter();
 
try {
Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
String dataSourceName = "addip";
String dbURL = "jdbc:odbc:" + dataSourceName;
Connection con = DriverManager.getConnection(dbURL, "",""); 
Statement s = con.createStatement();
 
s.execute("create table ip_table ( ip varchar(15) )");
 
s.execute("insert into ip_table values(address)");
s.execute("drop table ip_table");
s.close();
con.close(); 
out.println("<center><b>Server successfully added<b></center><br>");
 
}
catch (Exception err)
{

out.println(err.toString());
}
 

out.close();

}//end doPost
 

}//end Class   

[Roy Simon]

There is a syntax error in your query
//statement.execute("insert into ip_table values(address)")

this should be
string query = "insert into ip_table values('" + address + "')";
statement.execute(query);

Regards
Roy
[ March 08, 2007: Message edited by: Roy Simon ]

[Paul Sturrock]

First question: why are you using the JDBC:ODBC bridge? Does your database not provide a better driver?