calling a SQL function within my java code could somebody tell me what I did wrong?

[noodle hamilton]

Hi all:
I am just trying to call a simple sql func in my java code, and I got

2007-06-08 11:02:25,151 INFO  [STDOUT] [08/Jun/2007 11:02:25:151] WAOEApp - IPFilter -- isFilter - ERROR: java.sql.SQLException: ORA-01008: not all variables bound

here is the sql function

Package WAOE_PKG
 
FUNCTION CHECK_IP_BLOCKING(I_IP_ADDRESS IN IP_BLOCKING.IP_ADDRESS%TYPE)
RETURN VARCHAR2;
 

I tested on the DB Client and the returned values are all correct.

here is a portion of my code that is calling it

 
    System.out.println("in ");
        Connection conn = DbAccess.getConnection();
        CallableStatement cs =null;
        String block = new String();
        try {
            cs = conn.prepareCall("{? = call WAOE_PKG.CHECK_IP_BLOCKING(?)}");
            cs.registerOutParameter(1,Types.VARCHAR);
            cs.setString(1,"'"+ip+"'");
            cs.execute();
            block = cs.getString(1);
            
            
        }
           
        catch (SQLException ex) {
            WAUtility.logError("IPFilter -- isFilter", ex.toString());
        }
        finally {
            try {
                cs.close();
            } catch (SQLException ex) {
                WAUtility.logError("IPFilter -- isFilter", ex.toString());
            }
            DbAccess.closeConnection(conn);
        }

please let me know what I was doing wrong..

Thanks

[noodle hamilton]

ok, never mind i figured it out...
it should be setString(2 instead..

[Jan Cumps]

You're right, it has to be setString(2,...).
Also, you don't need to wrap the ip between single quotes when you bind the parameter.

Regards, Jan