method with SQL parameter

[Dan Parsons]

I am trying to create a method with parameters where one parameter has a prepared statement. Is the below the right direction?

.....
public Preparestatement prepstat;
 
public int insertData(BeanData objref,String mySql)
{
    int mydata = 0;
    try {
    prepstat.connection.preparestatement(mySql);
    prepstat.setString(1,objref.getPerson());
    prepstat.setString(2,objref.getAnimal());
    prepstat.executeUpdate();
    }
    catch(Exception e) {
         e.printStacktrace();
    }
    return mydata;
 }
 
...
public int hitter(BeanData objref,String mySql)
{
.....
String mySql = "insert into tablemain (person, animal) values (?,?)";
insertData(objref,mySql);

[ October 08, 2007: Message edited by: Dan Parsons ]

[Jeanne Boyarsky]

What's the prepareStatement object? Are you holding open a connection for some length of time? How do the prepared statement and connection JDBC objects get close?

[Dan Parsons]

What's the prepareStatement object? Are you holding open a connection for some length of time? How do the prepared statement and connection JDBC objects get close?

Sorry didnt show the connection part and it is in my class file where I am opening in the method with the closing parts in a finally block.

[Jeanne Boyarsky]

I get in now. You are trying to wrap the JDBC APIs in your own object. That's fine.

[Herman Schelti]

hi Dan,

2 questions for you:

-does 'prepstat' have to be a public property?

-the class that you posted, do you want to use it as a singleton?
(because it does not look very thread-safe if all requests use the same 'prepstat'


Herman