Closing DB issue in new method

[Ed Carrington]

I have a method that inserts data into my Oracle 9i database with no problems and no Database closing issues:

public class MainClass
{
 
public PreparedStatement preparer;
public Connection connection;
 
public MainClass()
{
     connection = new DbConnectionClass().getConnection();
}
 
public int inserter(Beann abc)
{
   int dat = 0;
   try
  {
      preparer = connection.prepareStatement("insert into abTable (one,two) values (?,?)");
      preparer.setString(1, abc.getOne());
      preparer.setString(2, abc.getTwo());
      preparer.executeUpdate();
   }
   catch(Exception e)
  {
      e.printStackTrace();
  }
  return dat;
}
 
public int matcher(Beann abc)
{
     try
     {
inserter(abc);
     }
     catch(Exception e)
     {
         e.printStackTrace();
     }
     finally
     { 
        //close the ResultSet ....
        //close the Statement  ....
        //close the Connection  ....
     }
}

Now when I put the method (inserter) in another class called OtherClass, it does insert the data but now I have database closing issues:

public int matcher(Beann abc)
{
     try
     {
         new OtherClass().insert(abc);
     }
     catch(Exception e)
     {
         e.printStackTrace();
     }
     finally
     { 
        //close the ResultSet ....
        //close the Statement  ....
        //close the Connection  ....
     }

In my SQL Plus database resource check I see JDBC Thin Client is opened and not closed after each insert with the above attempt.
This didnt happen when I had the method in the same class.

Please advise.
[ October 15, 2007: Message edited by: Ed Carrington ]

[Scott Selikoff]

Even though this probably sounds excessive, your finally code should be protected line by line as such:

} finally { 
        try { rs.close() } catch (Exception e) {}
        try { stmt.close() } catch (Exception e) {}
        try { conn.close() } catch (Exception e) {}
     }

I've seen people not do this in the past and keep in mind, if an rs.close() or stmt.close() fails then without this type of structure the conn.close() might not be executed.

If it helps I usually add these add as static utility functions so I don't have to write this over and over again.

[Ed Carrington]

Originally posted by Scott Selikoff:
Even though this probably sounds excessive, your finally code should be protected line by line as such:

} finally { 
        try { rs.close() } catch (Exception e) {}
        try { stmt.close() } catch (Exception e) {}
        try { conn.close() } catch (Exception e) {}
     }

I've seen people not do this in the past and keep in mind, if an rs.close() or stmt.close() fails then without this type of structure the conn.close() might not be executed.

If it helps I usually add these add as static utility functions so I don't have to write this over and over again.

Thanks I added as you suggested and still have the database closing issue.
Please advise.